[jira] [Commented] (OAK-1586) Implement checkpoint support in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946435#comment-13946435 ] Chetan Mehrotra commented on OAK-1586: -- Updated the logic to use separate {{settings}} collection in http://svn.apache.org/r1581297 [~julian.resc...@gmx.de] Can you have a look at changes required in RDBDocumentStore (new tables?) to support this Implement checkpoint support in DocumentNodeStore - Key: OAK-1586 URL: https://issues.apache.org/jira/browse/OAK-1586 Project: Jackrabbit Oak Issue Type: Bug Components: mongomk Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Fix For: 0.20 DocumentNodeStore currently does not make any record of checkpoint request. With Revision GC OAK-1341 being implemented this needs to be implemented -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OAK-1586) Implement checkpoint support in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944900#comment-13944900 ] Marcel Reutegger commented on OAK-1586: --- I was wondering if the document may interfere with other code querying the nodes collection, like the data store garbage collection. Other than that, I think the current approach is fine. One alternative that came to my mind: use a regular oak node and use a hidden name like {{:checkpoint}}? Implement checkpoint support in DocumentNodeStore - Key: OAK-1586 URL: https://issues.apache.org/jira/browse/OAK-1586 Project: Jackrabbit Oak Issue Type: Bug Components: mongomk Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Fix For: 0.20 DocumentNodeStore currently does not make any record of checkpoint request. With Revision GC OAK-1341 being implemented this needs to be implemented -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OAK-1586) Implement checkpoint support in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944940#comment-13944940 ] Chetan Mehrotra commented on OAK-1586: -- bq. One alternative that came to my mind: use a regular oak node and use a hidden name like :checkpoint? As discussed offline using a regular id with name like {{:checkpoint }} would make the checkpoint node document avialable to normal Oak related queries and that is not desirable. Using a name like '/checkpoint' keep this node isolated. if it proves to be a problem later we can implement checkpoint support as a regular NodeDocument. For now it serves the prupose Implement checkpoint support in DocumentNodeStore - Key: OAK-1586 URL: https://issues.apache.org/jira/browse/OAK-1586 Project: Jackrabbit Oak Issue Type: Bug Components: mongomk Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Fix For: 0.20 DocumentNodeStore currently does not make any record of checkpoint request. With Revision GC OAK-1341 being implemented this needs to be implemented -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OAK-1586) Implement checkpoint support in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-1586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946106#comment-13946106 ] Jukka Zitting commented on OAK-1586: The simulated clock in the test case looked pretty useful, so I promoted it from the test case to the a {{Clock.Virtual}} class. Implement checkpoint support in DocumentNodeStore - Key: OAK-1586 URL: https://issues.apache.org/jira/browse/OAK-1586 Project: Jackrabbit Oak Issue Type: Bug Components: mongomk Reporter: Chetan Mehrotra Assignee: Chetan Mehrotra Fix For: 0.20 DocumentNodeStore currently does not make any record of checkpoint request. With Revision GC OAK-1341 being implemented this needs to be implemented -- This message was sent by Atlassian JIRA (v6.2#6252)