[jira] [Commented] (OAK-2019) Compact only if needed
[ https://issues.apache.org/jira/browse/OAK-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14108934#comment-14108934 ] Alex Parvulescu commented on OAK-2019: -- merged to 1.0 branch with rev 1620284 Compact only if needed -- Key: OAK-2019 URL: https://issues.apache.org/jira/browse/OAK-2019 Project: Jackrabbit Oak Issue Type: Improvement Components: segmentmk Reporter: Alex Parvulescu Assignee: Alex Parvulescu Fix For: 1.1, 1.0.5 Attachments: 0001-OAK-2019-Compact-only-if-needed.patch, compact-if-needed.patch Add a verification before the TarMK compaction runs to see if there's at least one tar file that needs cleanup. Otherwise skip compaction entirely. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OAK-2019) Compact only if needed
[ https://issues.apache.org/jira/browse/OAK-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105426#comment-14105426 ] Alex Parvulescu commented on OAK-2019: -- applied Jukka's patch with some minor changes - added a 'pause' flag which is not wired yet into the osgi configs, set to true: compaction is skipped by default until we fix OAK-2045 - added a bit of logs around the new compaction check sizes - cleanup will now run even if the compaction check is negative thanks again Jukka! Compact only if needed -- Key: OAK-2019 URL: https://issues.apache.org/jira/browse/OAK-2019 Project: Jackrabbit Oak Issue Type: Improvement Components: segmentmk Reporter: Alex Parvulescu Assignee: Alex Parvulescu Fix For: 1.1, 1.0.5 Attachments: 0001-OAK-2019-Compact-only-if-needed.patch, compact-if-needed.patch Add a verification before the TarMK compaction runs to see if there's at least one tar file that needs cleanup. Otherwise skip compaction entirely. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OAK-2019) Compact only if needed
[ https://issues.apache.org/jira/browse/OAK-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105505#comment-14105505 ] Jukka Zitting commented on OAK-2019: bq. cleanup will now run even if the compaction check is negative +1 Good point! Compact only if needed -- Key: OAK-2019 URL: https://issues.apache.org/jira/browse/OAK-2019 Project: Jackrabbit Oak Issue Type: Improvement Components: segmentmk Reporter: Alex Parvulescu Assignee: Alex Parvulescu Fix For: 1.1, 1.0.5 Attachments: 0001-OAK-2019-Compact-only-if-needed.patch, compact-if-needed.patch Add a verification before the TarMK compaction runs to see if there's at least one tar file that needs cleanup. Otherwise skip compaction entirely. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OAK-2019) Compact only if needed
[ https://issues.apache.org/jira/browse/OAK-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092522#comment-14092522 ] Konrad Windszus commented on OAK-2019: -- So if compaction creates a new Tar containing only non-garbage that leaves the old Tar in a state, where nothing is referenced in it. So IMHO cleanup should be able to remove that old Tar completely (because at that state it only contains garbage). Why is that not the case? Compact only if needed -- Key: OAK-2019 URL: https://issues.apache.org/jira/browse/OAK-2019 Project: Jackrabbit Oak Issue Type: Improvement Components: segmentmk Reporter: Alex Parvulescu Assignee: Alex Parvulescu Attachments: compact-if-needed.patch Add a verification before the TarMK compaction runs to see if there's at least one tar file that needs cleanup. Otherwise skip compaction entirely. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OAK-2019) Compact only if needed
[ https://issues.apache.org/jira/browse/OAK-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092543#comment-14092543 ] Jukka Zitting commented on OAK-2019: The garbage identified by this patch can be reclaimed by a normal cleanup even without compaction, so as such the check isn't too useful (you could just run cleanup instead). Compact only if needed -- Key: OAK-2019 URL: https://issues.apache.org/jira/browse/OAK-2019 Project: Jackrabbit Oak Issue Type: Improvement Components: segmentmk Reporter: Alex Parvulescu Assignee: Alex Parvulescu Attachments: compact-if-needed.patch Add a verification before the TarMK compaction runs to see if there's at least one tar file that needs cleanup. Otherwise skip compaction entirely. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OAK-2019) Compact only if needed
[ https://issues.apache.org/jira/browse/OAK-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14092569#comment-14092569 ] Konrad Windszus commented on OAK-2019: -- Currently the only way to trigger compaction during running Oak (and also the cleanup afterwards I guess) is through the revisionGarbageCollection. Can you extend the information at http://jackrabbit.apache.org/oak/docs/nodestore/segmentmk.html#Segment_Compaction to explain the two different phases (compaction and cleanup)? Compact only if needed -- Key: OAK-2019 URL: https://issues.apache.org/jira/browse/OAK-2019 Project: Jackrabbit Oak Issue Type: Improvement Components: segmentmk Reporter: Alex Parvulescu Assignee: Alex Parvulescu Attachments: compact-if-needed.patch Add a verification before the TarMK compaction runs to see if there's at least one tar file that needs cleanup. Otherwise skip compaction entirely. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (OAK-2019) Compact only if needed
[ https://issues.apache.org/jira/browse/OAK-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14089562#comment-14089562 ] Alex Parvulescu commented on OAK-2019: -- link do thread on oak-dev http://markmail.org/thread/pkwy3f3o23ovz62o Compact only if needed -- Key: OAK-2019 URL: https://issues.apache.org/jira/browse/OAK-2019 Project: Jackrabbit Oak Issue Type: Improvement Components: segmentmk Reporter: Alex Parvulescu Assignee: Alex Parvulescu Attachments: compact-if-needed.patch Add a verification before the TarMK compaction runs to see if there's at least one tar file that needs cleanup. Otherwise skip compaction entirely. -- This message was sent by Atlassian JIRA (v6.2#6252)
