[jira] [Commented] (OAK-2625) Copy Jackrabbit 2 S3 related classes
[ https://issues.apache.org/jira/browse/OAK-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360509#comment-14360509 ] Alex Parvulescu commented on OAK-2625: -- fixed the above with http://svn.apache.org/r1666480 > Copy Jackrabbit 2 S3 related classes > > > Key: OAK-2625 > URL: https://issues.apache.org/jira/browse/OAK-2625 > Project: Jackrabbit Oak > Issue Type: Task > Components: blob >Reporter: Amit Jain >Assignee: Amit Jain > Fix For: 1.1.8 > > > As discussed in http://markmail.org/thread/wuccswpehsybat4v it'll be good to > have the S3 related classes in Oak itself to make it easier to make > improvements. > The classes will be moved to a new module oak-blob-cloud. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-2625) Copy Jackrabbit 2 S3 related classes
[ https://issues.apache.org/jira/browse/OAK-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360454#comment-14360454 ] Alex Parvulescu commented on OAK-2625: -- looks good. 2 minor nitpicks - pom.xml is now missing the license header, you need to add it back - moving the classes left behind some empty packages, I think it's better to remove them. funny enough github doesn't see them [0], but they do exist in svn [1] (same for [2]), weird. [0] https://github.com/apache/jackrabbit-oak/tree/trunk/oak-blob-cloud/src/main/java/org/apache/jackrabbit [1] http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-blob-cloud/src/main/java/org/apache/jackrabbit [2] http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-blob-cloud/src/test/java/org/apache/jackrabbit > Copy Jackrabbit 2 S3 related classes > > > Key: OAK-2625 > URL: https://issues.apache.org/jira/browse/OAK-2625 > Project: Jackrabbit Oak > Issue Type: Task > Components: blob >Reporter: Amit Jain >Assignee: Amit Jain > Fix For: 1.1.8 > > > As discussed in http://markmail.org/thread/wuccswpehsybat4v it'll be good to > have the S3 related classes in Oak itself to make it easier to make > improvements. > The classes will be moved to a new module oak-blob-cloud. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-2625) Copy Jackrabbit 2 S3 related classes
[ https://issues.apache.org/jira/browse/OAK-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360383#comment-14360383 ] Amit Jain commented on OAK-2625: [~alexparvulescu] Could you please review the change? > Copy Jackrabbit 2 S3 related classes > > > Key: OAK-2625 > URL: https://issues.apache.org/jira/browse/OAK-2625 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Amit Jain >Assignee: Amit Jain > Fix For: 1.1.8 > > > As discussed in http://markmail.org/thread/wuccswpehsybat4v it'll be good to > have the S3 related classes in Oak itself to make it easier to make > improvements. > The classes will be moved to a new module oak-blob-cloud. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-2625) Copy Jackrabbit 2 S3 related classes
[ https://issues.apache.org/jira/browse/OAK-2625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360381#comment-14360381 ] Amit Jain commented on OAK-2625: Copied as-is version from jackrabbit-aws-ext with http://svn.apache.org/r1666416 Changed packages names and enabled build with http://svn.apache.org/r1666454 > Copy Jackrabbit 2 S3 related classes > > > Key: OAK-2625 > URL: https://issues.apache.org/jira/browse/OAK-2625 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Amit Jain >Assignee: Amit Jain > Fix For: 1.1.8 > > > As discussed in http://markmail.org/thread/wuccswpehsybat4v it'll be good to > have the S3 related classes in Oak itself to make it easier to make > improvements. > The classes will be moved to a new module oak-blob-cloud. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
