[jira] [Commented] (OAK-3020) Async Update fails after IllegalArgumentException
[
https://issues.apache.org/jira/browse/OAK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616146#comment-14616146
]
Chetan Mehrotra commented on OAK-3020:
--
Patch looks fine. I believe all changes are just removing the
{{CommitFailedException}} from method signatures. The logger needs to be changed
bq. +log.warn(Failed to index the node [{}] + path, ie);
This should be
bq. +log.warn(Failed to index the node [{}] , path, ie);
See [this FAQ|http://www.slf4j.org/faq.html#paramException]
Async Update fails after IllegalArgumentException
-
Key: OAK-3020
URL: https://issues.apache.org/jira/browse/OAK-3020
Project: Jackrabbit Oak
Issue Type: Bug
Affects Versions: 1.2.2
Reporter: Julian Sedding
Assignee: Amit Jain
Fix For: 1.3.3
Attachments: OAK-3020-stacktrace.txt, OAK-3020.patch,
OAK-3020.test.patch
The async index update can fail due to a mismatch between an index definition
and the actual content. If that is the case, it seems that it can no longer
make any progress. Instead it re-indexes the latest changes over and over
again until it hits the problematic property.
Discussion at http://markmail.org/thread/42bixzkrkwv4s6tq
Stacktrace attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3020) Async Update fails after IllegalArgumentException
[ https://issues.apache.org/jira/browse/OAK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616142#comment-14616142 ] Amit Jain commented on OAK-3020: [~chetanm] No was for OAK-2999. But please review the original patch for this as the other patch is based on this. Async Update fails after IllegalArgumentException - Key: OAK-3020 URL: https://issues.apache.org/jira/browse/OAK-3020 Project: Jackrabbit Oak Issue Type: Bug Affects Versions: 1.2.2 Reporter: Julian Sedding Assignee: Amit Jain Fix For: 1.3.3 Attachments: OAK-3020-stacktrace.txt, OAK-3020.patch, OAK-3020.test.patch The async index update can fail due to a mismatch between an index definition and the actual content. If that is the case, it seems that it can no longer make any progress. Instead it re-indexes the latest changes over and over again until it hits the problematic property. Discussion at http://markmail.org/thread/42bixzkrkwv4s6tq Stacktrace attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3020) Async Update fails after IllegalArgumentException
[ https://issues.apache.org/jira/browse/OAK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615095#comment-14615095 ] Chetan Mehrotra commented on OAK-3020: -- [~amitj_76] was the [updated patch|^OAK-3020-v2.patch] meant for this issue Async Update fails after IllegalArgumentException - Key: OAK-3020 URL: https://issues.apache.org/jira/browse/OAK-3020 Project: Jackrabbit Oak Issue Type: Bug Affects Versions: 1.2.2 Reporter: Julian Sedding Assignee: Amit Jain Fix For: 1.3.3 Attachments: OAK-3020-stacktrace.txt, OAK-3020-v2.patch, OAK-3020.patch, OAK-3020.test.patch The async index update can fail due to a mismatch between an index definition and the actual content. If that is the case, it seems that it can no longer make any progress. Instead it re-indexes the latest changes over and over again until it hits the problematic property. Discussion at http://markmail.org/thread/42bixzkrkwv4s6tq Stacktrace attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3020) Async Update fails after IllegalArgumentException
[ https://issues.apache.org/jira/browse/OAK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601147#comment-14601147 ] Davide Giannella commented on OAK-3020: --- I think we should come up with some sort of general management from the AsyncIndexUpdate itself. I don't think it's correct that in case an indexer fails to run with an exception it stops his tasks and or resume from scratch. Async Update fails after IllegalArgumentException - Key: OAK-3020 URL: https://issues.apache.org/jira/browse/OAK-3020 Project: Jackrabbit Oak Issue Type: Bug Affects Versions: 1.2.2 Reporter: Julian Sedding Assignee: Amit Jain Fix For: 1.3.2 Attachments: OAK-3020-stacktrace.txt, OAK-3020.test.patch The async index update can fail due to a mismatch between an index definition and the actual content. If that is the case, it seems that it can no longer make any progress. Instead it re-indexes the latest changes over and over again until it hits the problematic property. Discussion at http://markmail.org/thread/42bixzkrkwv4s6tq Stacktrace attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3020) Async Update fails after IllegalArgumentException
[ https://issues.apache.org/jira/browse/OAK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598915#comment-14598915 ] Amit Jain commented on OAK-3020: Fixed in trunk with http://svn.apache.org/r1687175 (Includes test case by [~jsedding]) [~chetanm] Could you please review the change done. Once reviewed I'll merge to the branches. Async Update fails after IllegalArgumentException - Key: OAK-3020 URL: https://issues.apache.org/jira/browse/OAK-3020 Project: Jackrabbit Oak Issue Type: Bug Affects Versions: 1.2.2 Reporter: Julian Sedding Assignee: Amit Jain Attachments: OAK-3020-stacktrace.txt, OAK-3020.test.patch The async index update can fail due to a mismatch between an index definition and the actual content. If that is the case, it seems that it can no longer make any progress. Instead it re-indexes the latest changes over and over again until it hits the problematic property. Discussion at http://markmail.org/thread/42bixzkrkwv4s6tq Stacktrace attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3020) Async Update fails after IllegalArgumentException
[ https://issues.apache.org/jira/browse/OAK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599135#comment-14599135 ] Julian Sedding commented on OAK-3020: - Thanks Amit! Async Update fails after IllegalArgumentException - Key: OAK-3020 URL: https://issues.apache.org/jira/browse/OAK-3020 Project: Jackrabbit Oak Issue Type: Bug Affects Versions: 1.2.2 Reporter: Julian Sedding Assignee: Amit Jain Fix For: 1.3.2 Attachments: OAK-3020-stacktrace.txt, OAK-3020.test.patch The async index update can fail due to a mismatch between an index definition and the actual content. If that is the case, it seems that it can no longer make any progress. Instead it re-indexes the latest changes over and over again until it hits the problematic property. Discussion at http://markmail.org/thread/42bixzkrkwv4s6tq Stacktrace attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3020) Async Update fails after IllegalArgumentException
[
https://issues.apache.org/jira/browse/OAK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599348#comment-14599348
]
Amit Jain commented on OAK-3020:
My understanding of the issue is that the exceptions are to be handled in the
{{LuceneIndexEditor#addOrUpdate}}. So :
* We can probably catch the {{IllegalArgumentException}} [1] as it most likely
is an application issue.
* The {{IOException}} indicates a lucene issue should be thrown.
* Not sure about {{CommitFailedException}}, it has to be handled for the
{{indexAggregates}} method.
[1]
{code}
+UTF-8
===
---
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexEditor.java
(date 1435134534000)
+++
oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LuceneIndexEditor.java
(revision )
@@ -297,8 +297,7 @@
throw new CommitFailedException(Lucene, 3,
Failed to index the node + path, e);
} catch (IllegalArgumentException ie) {
-throw new CommitFailedException(Lucene, 3,
-Failed to index the node + path, ie);
+log.warn(Lucene failed to index the node + path, ie);
}
return false;
}
{code}
Async Update fails after IllegalArgumentException
-
Key: OAK-3020
URL: https://issues.apache.org/jira/browse/OAK-3020
Project: Jackrabbit Oak
Issue Type: Bug
Affects Versions: 1.2.2
Reporter: Julian Sedding
Assignee: Amit Jain
Fix For: 1.3.2
Attachments: OAK-3020-stacktrace.txt, OAK-3020.test.patch
The async index update can fail due to a mismatch between an index definition
and the actual content. If that is the case, it seems that it can no longer
make any progress. Instead it re-indexes the latest changes over and over
again until it hits the problematic property.
Discussion at http://markmail.org/thread/42bixzkrkwv4s6tq
Stacktrace attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3020) Async Update fails after IllegalArgumentException
[
https://issues.apache.org/jira/browse/OAK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599248#comment-14599248
]
Chetan Mehrotra commented on OAK-3020:
--
Changes look fine. In addition we should probably look into making
{{addDocument}} catch say certain type of exception and move on. As Julian said
that one corrupt node should not bring down the whole indexing flow. Not sure
how much wider net to cast for the exception handling though!
Async Update fails after IllegalArgumentException
-
Key: OAK-3020
URL: https://issues.apache.org/jira/browse/OAK-3020
Project: Jackrabbit Oak
Issue Type: Bug
Affects Versions: 1.2.2
Reporter: Julian Sedding
Assignee: Amit Jain
Fix For: 1.3.2
Attachments: OAK-3020-stacktrace.txt, OAK-3020.test.patch
The async index update can fail due to a mismatch between an index definition
and the actual content. If that is the case, it seems that it can no longer
make any progress. Instead it re-indexes the latest changes over and over
again until it hits the problematic property.
Discussion at http://markmail.org/thread/42bixzkrkwv4s6tq
Stacktrace attached.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3020) Async Update fails after IllegalArgumentException
[ https://issues.apache.org/jira/browse/OAK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597755#comment-14597755 ] Amit Jain commented on OAK-3020: Yes I think we should ignore it. We already ignore the occurrence if the type of the property differs from what is configured and cannot be converted to it. [~chetanm] wdyt? Async Update fails after IllegalArgumentException - Key: OAK-3020 URL: https://issues.apache.org/jira/browse/OAK-3020 Project: Jackrabbit Oak Issue Type: Bug Affects Versions: 1.2.2 Reporter: Julian Sedding Attachments: OAK-3020-stacktrace.txt, OAK-3020.test.patch The async index update can fail due to a mismatch between an index definition and the actual content. If that is the case, it seems that it can no longer make any progress. Instead it re-indexes the latest changes over and over again until it hits the problematic property. Discussion at http://markmail.org/thread/42bixzkrkwv4s6tq Stacktrace attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3020) Async Update fails after IllegalArgumentException
[ https://issues.apache.org/jira/browse/OAK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597601#comment-14597601 ] Julian Sedding commented on OAK-3020: - Another point of view could be to ignore the occurrence of the property, because it does not match the index definition. Not sure what would be the most intuitive behaviour. Async Update fails after IllegalArgumentException - Key: OAK-3020 URL: https://issues.apache.org/jira/browse/OAK-3020 Project: Jackrabbit Oak Issue Type: Bug Affects Versions: 1.2.2 Reporter: Julian Sedding Attachments: OAK-3020-stacktrace.txt, OAK-3020.test.patch The async index update can fail due to a mismatch between an index definition and the actual content. If that is the case, it seems that it can no longer make any progress. Instead it re-indexes the latest changes over and over again until it hits the problematic property. Discussion at http://markmail.org/thread/42bixzkrkwv4s6tq Stacktrace attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3020) Async Update fails after IllegalArgumentException
[ https://issues.apache.org/jira/browse/OAK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597596#comment-14597596 ] Davide Giannella commented on OAK-3020: --- thanks [~jsedding]. Now the question would is: should we drop the node or index, let's say, only the first occurrence of the property? I think the document should be indexed under both the property values but then, don't know how to cope with the ordering. [~chetanm] thoughts? Async Update fails after IllegalArgumentException - Key: OAK-3020 URL: https://issues.apache.org/jira/browse/OAK-3020 Project: Jackrabbit Oak Issue Type: Bug Affects Versions: 1.2.2 Reporter: Julian Sedding Attachments: OAK-3020-stacktrace.txt, OAK-3020.test.patch The async index update can fail due to a mismatch between an index definition and the actual content. If that is the case, it seems that it can no longer make any progress. Instead it re-indexes the latest changes over and over again until it hits the problematic property. Discussion at http://markmail.org/thread/42bixzkrkwv4s6tq Stacktrace attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
