[jira] [Commented] (OAK-3104) Version garbage collector doesn't collect a rolled back document if it was never deleted
[
https://issues.apache.org/jira/browse/OAK-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634792#comment-14634792
]
Vikas Saurabh commented on OAK-3104:
[~mreutegg], there are a couple of changes in NodeDocument which seem to be
formatting change (apart from those for setDeletedOnce). Otherwise, this looks
good.
> Version garbage collector doesn't collect a rolled back document if it was
> never deleted
>
>
> Key: OAK-3104
> URL: https://issues.apache.org/jira/browse/OAK-3104
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Affects Versions: 1.2.2, 1.3.3, 1.0.17
>Reporter: Vikas Saurabh
>Assignee: Marcel Reutegger
>Priority: Minor
> Attachments:
> 0001-OAK-3104-rollback-of-new-documents-should-mark-_dele.patch,
> 0002-OAK-3104-update-DocumentNodeStoreTest.rollback-to-as.patch,
> OAK-3104.patch
>
>
> If a commit gets rolled back it can leave (in case the document was never
> deleted explicitly) a document in a state like:
> {noformat}
> {
>"_id" : "7:/etc/workflow/packages/2014/10/12/rep:ours",
>"_deleted" : {
>},
>"_commitRoot" : {
>},
>"jcr:primaryType" : {
>},
>"_modified" : NumberLong(1413126245),
>"_children" : true,
>"_modCount" : NumberLong(2)
> }
> {noformat}
> If the path is fairly busy, the document can get created naturally later and
> then follow the usual cycle. But, at times, such documents are ephemeral in
> nature and never re-used. In those cases, such documents can remain silently
> without getting collected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3104) Version garbage collector doesn't collect a rolled back document if it was never deleted
[
https://issues.apache.org/jira/browse/OAK-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627665#comment-14627665
]
Vikas Saurabh commented on OAK-3104:
As discussed with [~mreutegg], we should probably set_deletedOnce flag while
rolling back. I'd add a test and patch later.
> Version garbage collector doesn't collect a rolled back document if it was
> never deleted
>
>
> Key: OAK-3104
> URL: https://issues.apache.org/jira/browse/OAK-3104
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: mongomk
>Reporter: Vikas Saurabh
>Priority: Minor
>
> If a commit gets rolled back it can leave (in case the document was never
> deleted explicitly) a document in a state like:
> {noformat}
> {
>"_id" : "7:/etc/workflow/packages/2014/10/12/rep:ours",
>"_deleted" : {
>},
>"_commitRoot" : {
>},
>"jcr:primaryType" : {
>},
>"_modified" : NumberLong(1413126245),
>"_children" : true,
>"_modCount" : NumberLong(2)
> }
> {noformat}
> If the path is fairly busy, the document can get created naturally later and
> then follow the usual cycle. But, at times, such documents are ephemeral in
> nature and never re-used. In those cases, such documents can remain silently
> without getting collected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
