[jira] [Commented] (OAK-3642) Enable failing of commit upon Missing IndexEditor implementation by default
[ https://issues.apache.org/jira/browse/OAK-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189048#comment-15189048 ] Alex Parvulescu commented on OAK-3642: -- I guess #2 looks good, given the crazy amount of changes needed for #1. I'm a bit hesitant to remove the system property switch entirely, could we set the default to something based on a system property? this would allow us to turn off the behavior if needed without code changes. > Enable failing of commit upon Missing IndexEditor implementation by default > --- > > Key: OAK-3642 > URL: https://issues.apache.org/jira/browse/OAK-3642 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.6 > > Attachments: OAK-3642-oak-config.patch, OAK-3642.patch > > > With OAK-3505 we exposed config option to enable failing of commit if any > IndexEditor is missing. The default should be changed to always fail the > commit -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3642) Enable failing of commit upon Missing IndexEditor implementation by default
[
https://issues.apache.org/jira/browse/OAK-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188836#comment-15188836
]
Chetan Mehrotra commented on OAK-3642:
--
[~alex.parvulescu] I see 2 options here
# We change the default - This would require figuring out broken test and
fixing them (> 100)
# OR We expose a setting in {{Oak}} class which is then passed on to
{{IndexUpdate}} regarding fail on missing provider. Then application which
configure Oak can set it. In our case we make use of it in
{{org.apache.jackrabbit.oak.jcr.osgi.RepositoryManager}}
{code}
Oak oak = new Oak()
.with(new OpenSecurityProvider())
.with(new InitialContent())
.with(wb)
.with(wbProvider)
.withFailOnMissingIndexProvider();
{code}
Thoughts?
> Enable failing of commit upon Missing IndexEditor implementation by default
> ---
>
> Key: OAK-3642
> URL: https://issues.apache.org/jira/browse/OAK-3642
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: 1.6
>
> Attachments: OAK-3642-oak-config.patch, OAK-3642.patch
>
>
> With OAK-3505 we exposed config option to enable failing of commit if any
> IndexEditor is missing. The default should be changed to always fail the
> commit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3642) Enable failing of commit upon Missing IndexEditor implementation by default
[ https://issues.apache.org/jira/browse/OAK-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062012#comment-15062012 ] Alex Parvulescu commented on OAK-3642: -- +1 I think we can enable this by default > Enable failing of commit upon Missing IndexEditor implementation by default > --- > > Key: OAK-3642 > URL: https://issues.apache.org/jira/browse/OAK-3642 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.3.13 > > Attachments: OAK-3642.patch > > > With OAK-3505 we exposed config option to enable failing of commit if any > IndexEditor is missing. The default should be changed to always fail the > commit -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3642) Enable failing of commit upon Missing IndexEditor implementation by default
[
https://issues.apache.org/jira/browse/OAK-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063658#comment-15063658
]
Davide Giannella commented on OAK-3642:
---
[~alex.parvulescu], [~chetanm]
for OAK-3768 I'm currently returning {{null}} from the IndexEditorProvider.
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/property/OrderedPropertyIndexEditorProvider.java#L53.
Would that be a problem for this issue? Returning a no-op editor is trivial;
just let me know.
> Enable failing of commit upon Missing IndexEditor implementation by default
> ---
>
> Key: OAK-3642
> URL: https://issues.apache.org/jira/browse/OAK-3642
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: 1.4
>
> Attachments: OAK-3642.patch
>
>
> With OAK-3505 we exposed config option to enable failing of commit if any
> IndexEditor is missing. The default should be changed to always fail the
> commit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3642) Enable failing of commit upon Missing IndexEditor implementation by default
[ https://issues.apache.org/jira/browse/OAK-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061964#comment-15061964 ] Chetan Mehrotra commented on OAK-3642: -- [~alexparvulescu] thoughts on [patch|^OAK-3642.patch] > Enable failing of commit upon Missing IndexEditor implementation by default > --- > > Key: OAK-3642 > URL: https://issues.apache.org/jira/browse/OAK-3642 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.3.13 > > Attachments: OAK-3642.patch > > > With OAK-3505 we exposed config option to enable failing of commit if any > IndexEditor is missing. The default should be changed to always fail the > commit -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-3642) Enable failing of commit upon Missing IndexEditor implementation by default
[
https://issues.apache.org/jira/browse/OAK-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063463#comment-15063463
]
Chetan Mehrotra commented on OAK-3642:
--
bummer ... changing this leads to 98 test failure in oak-core as in many cases
InitialContent is used but ReferenceIndexEditorProvider is not registered
{noformat}
Tests in error:
queryOnStableRevision(org.apache.jackrabbit.oak.api.QueryTest):
org.apache.jackrabbit.oak.api.CommitFailedException: OakIndexUpdate0001:
Missing index provider detected for type [reference] on index
[/oak:index/reference]
testUniqueness(org.apache.jackrabbit.oak.api.UniquePropertyTest):
org.apache.jackrabbit.oak.api.CommitFailedException: OakIndexUpdate0001:
Missing index provider detected for type [reference] on index
[/oak:index/reference]
testAdminConfiguration(org.apache.jackrabbit.oak.security.user.UserInitializerTest):
org.apache.jackrabbit.oak.api.CommitFailedException: OakIndexUpdate0001:
Missing index provider detected for type [reference] on index
[/oak:index/reference]
testAnonymousConfiguration(org.apache.jackrabbit.oak.security.user.UserInitializerTest):
org.apache.jackrabbit.oak.api.CommitFailedException: OakIndexUpdate0001:
Missing index provider detected for type [reference] on index
[/oak:index/reference]
testGetAuthorizable(org.apache.jackrabbit.oak.security.user.UserProviderTest):
org.apache.jackrabbit.oak.api.CommitFailedException: OakIndexUpdate0001:
Missing index provider detected for type [reference] on index
[/oak:index/reference]
{noformat}
Would attempt it some later time
> Enable failing of commit upon Missing IndexEditor implementation by default
> ---
>
> Key: OAK-3642
> URL: https://issues.apache.org/jira/browse/OAK-3642
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: 1.3.13
>
> Attachments: OAK-3642.patch
>
>
> With OAK-3505 we exposed config option to enable failing of commit if any
> IndexEditor is missing. The default should be changed to always fail the
> commit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-3642) Enable failing of commit upon Missing IndexEditor implementation by default
[ https://issues.apache.org/jira/browse/OAK-3642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15008098#comment-15008098 ] Chetan Mehrotra commented on OAK-3642: -- [~alex.parvulescu] Thoughts? > Enable failing of commit upon Missing IndexEditor implementation by default > --- > > Key: OAK-3642 > URL: https://issues.apache.org/jira/browse/OAK-3642 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.3.11 > > > With OAK-3505 we exposed config option to enable failing of commit if any > IndexEditor is missing. The default should be changed to always fail the > commit -- This message was sent by Atlassian JIRA (v6.3.4#6332)
