[jira] [Commented] (OAK-3662) Create bulk createOrUpdate method and use it in Commit

2015-12-02 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15036103#comment-15036103
 ] 

Julian Reschke commented on OAK-3662:
-

We don't have any unit test coverage for the new DocumentStore method, right? 
We really need that, for instance in BasicDocumentStoreTest.

> Create bulk createOrUpdate method and use it in Commit
> --
>
> Key: OAK-3662
> URL: https://issues.apache.org/jira/browse/OAK-3662
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: documentmk
>Reporter: Tomek Rękawek
> Fix For: 1.4
>
> Attachments: OAK-3662.patch
>
>
> The {{DocumentStore#createOrUpdate(Collection, UpdateOp)}} method is invoked 
> in a loop in the {{Commit#applyToDocumentStore()}}, once for each changed 
> node. Investigate if it's possible to implement a batch version of the 
> createOrUpdate method. It should return all documents before they are 
> modified, so the Commit class can discover conflicts (if they are any).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-3662) Create bulk createOrUpdate method and use it in Commit

2015-11-23 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-3662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021831#comment-15021831
 ] 

Tomek Rękawek commented on OAK-3662:


Patch attached.

Branch on github:
https://github.com/trekawek/jackrabbit-oak/tree/OAK-3662

> Create bulk createOrUpdate method and use it in Commit
> --
>
> Key: OAK-3662
> URL: https://issues.apache.org/jira/browse/OAK-3662
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: documentmk
>Reporter: Tomek Rękawek
> Fix For: 1.4
>
> Attachments: OAK-3662.patch
>
>
> The {{DocumentStore#createOrUpdate(Collection, UpdateOp)}} method is invoked 
> in a loop in the {{Commit#applyToDocumentStore()}}, once for each changed 
> node. Investigate if it's possible to implement a batch version of the 
> createOrUpdate method. It should return all documents before they are 
> modified, so the Commit class can discover conflicts (if they are any).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)