[jira] [Commented] (OAK-4154) SynchronizationMBean.syncUsers(...) should optionally not force group sync.
[ https://issues.apache.org/jira/browse/OAK-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280363#comment-15280363 ] angela commented on OAK-4154: - [~baedke], once we have additional clarification on the intended behavior and the corresponding fix, the tests should be pretty straight forward to add based on the work I did for OAK-4264. please note however, that I omitted any kind of tests related to this issue (i.e. omitted tests for all extra methods you added) as I felt that we first need to get some clarification. > SynchronizationMBean.syncUsers(...) should optionally not force group sync. > --- > > Key: OAK-4154 > URL: https://issues.apache.org/jira/browse/OAK-4154 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: auth-external >Reporter: Manfred Baedke >Assignee: Manfred Baedke > Fix For: 1.6 > > > SynchronizationMBean.syncUsers(...) and related methods always force group > synchronization. This may have a huge negative impact on the performance of > these methods. > Additional methods should be added to the interface > org.apache.jackrabbit.oak.spi.security.authentication.external.impl.jmx.SynchronizationMBean, > featuring an additional boolean argument to enable or disable group sync. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OAK-4154) SynchronizationMBean.syncUsers(...) should optionally not force group sync.
[
https://issues.apache.org/jira/browse/OAK-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278053#comment-15278053
]
angela commented on OAK-4154:
-
and btw: the original description states:
{quote}
[...] featuring an additional boolean argument to enable or disable group sync.
{quote}
This is not achieved by the changes you made because
{{SyncContext.setForceGroupSync(boolean force)}} is not the flag to turn on or
off group synchronization. Instead it can be used to _enforce_ the group
synchronization irrespective of the expiration time. In other words:
- upon initial synchronization (not expiration time stored) the groups will be
synced up to the configured depth irrespective of the force-group-sync flag
- if a given group is found to be expired it will be synchronized again
irrespective of the force-group-sync flag
So, either the description is bit misleading or the fix doesn't do what it
promises :-)
May I kindly ask for additional clarification on this in addition to the test?
And again: proper tests would be helpful to identify the subtle differences
between group-expirationtime, force-group-sync, membership sync etc.etc.
Unless this is fully clarify I would opt for reverting the changes made so far.
On an architectural side note: the extra {{forceGroupSync}} looks a bit weired
to me as it's correspondent flag {{forceUserSync}} is missing. In particular as
all the methods not only can be used to sync user accounts but can also be fed
with groupIds, externalGroupIds... that's not obviously from the naming of the
methods but
I happened to spot (with some surprise) while working on OAK-4264.
> SynchronizationMBean.syncUsers(...) should optionally not force group sync.
> ---
>
> Key: OAK-4154
> URL: https://issues.apache.org/jira/browse/OAK-4154
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
> Fix For: 1.6
>
>
> SynchronizationMBean.syncUsers(...) and related methods always force group
> synchronization. This may have a huge negative impact on the performance of
> these methods.
> Additional methods should be added to the interface
> org.apache.jackrabbit.oak.spi.security.authentication.external.impl.jmx.SynchronizationMBean,
> featuring an additional boolean argument to enable or disable group sync.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (OAK-4154) SynchronizationMBean.syncUsers(...) should optionally not force group sync.
[ https://issues.apache.org/jira/browse/OAK-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218521#comment-15218521 ] Manfred Baedke commented on OAK-4154: - Implemented in trunk: r1737141. > SynchronizationMBean.syncUsers(...) should optionally not force group sync. > --- > > Key: OAK-4154 > URL: https://issues.apache.org/jira/browse/OAK-4154 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: auth-ldap >Reporter: Manfred Baedke >Assignee: Manfred Baedke > Fix For: 1.6 > > > SynchronizationMBean.syncUsers(...) and related methods always force group > synchronization. This may have a huge negative impact on the performance of > these methods. > Additional methods should be added to the interface > org.apache.jackrabbit.oak.spi.security.authentication.external.impl.jmx.SynchronizationMBean, > featuring an additional boolean argument to enable or disable group sync. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
