[ https://issues.apache.org/jira/browse/OAK-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251767#comment-15251767 ]
Tomek Rękawek commented on OAK-4266: ------------------------------------ Fixed for trunk in [r1740287|http://svn.apache.org/r1740287]. > NodeDocumentCache#get method should be synchronized > --------------------------------------------------- > > Key: OAK-4266 > URL: https://issues.apache.org/jira/browse/OAK-4266 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk > Reporter: Tomek Rękawek > Assignee: Tomek Rękawek > Fix For: 1.6, 1.5.2 > > > The {{NodeDocumentCache#get(String key, Callable)}} method may modify the > cache if there's no value for the given {{key}}. Therefore, it should be > synchronized using {{NodeDocumentLocks}}, as all the methods modifying the > cache are. > Right now, the {{get()}} method is invoked in 3 different places within the > Oak codebase. All of them are critical sections anyway, so this modification > won't result in a performance decrease. -- This message was sent by Atlassian JIRA (v6.3.4#6332)