[jira] [Commented] (OAK-4641) Using same index definition for both async and sync indexing

2016-08-04 Thread Chetan Mehrotra (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407565#comment-15407565
 ] 

Chetan Mehrotra commented on OAK-4641:
--

+1. Looks fine

> Using same index definition for both async and sync indexing
> 
>
> Key: OAK-4641
> URL: https://issues.apache.org/jira/browse/OAK-4641
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: query
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: 1.6
>
> Attachments: OAK-4641.patch
>
>
> Currently one can set "async" flag on an index definition to indicate wether 
> given index should be effective for synchronous commit or to be used for 
> async indexing. For Hybrid Lucene indexing case OAK-4412 we need to have a 
> way where same index definition gets used in both.
> As discussed on DL [1] for this to be done following changes need to be done
> # Making {{async}} as a multi value property.
> # Introducing a new IndexEditorProvider interface which can accept an 
> IndexingContext instance. This provides access to 
> ## indexing mode - sync or async
> ## index path of the index (see OAK-4152)
> ## CommitInfo (see OAK-4640)
> [1] 
> http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201608.mbox/%3CCAHCW-mk1HzAxy8fk17SzYDcfLYY%3D0HUp93FCYoxpTP37cNgb%2Bg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4641) Using same index definition for both async and sync indexing

2016-08-04 Thread Alex Parvulescu (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407350#comment-15407350
 ] 

Alex Parvulescu commented on OAK-4641:
--

just to clarify {{1}} and {{2}} would _both_ be required, those are not options 
to choose from.

> Using same index definition for both async and sync indexing
> 
>
> Key: OAK-4641
> URL: https://issues.apache.org/jira/browse/OAK-4641
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: query
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: 1.6
>
>
> Currently one can set "async" flag on an index definition to indicate wether 
> given index should be effective for synchronous commit or to be used for 
> async indexing. For Hybrid Lucene indexing case OAK-4412 we need to have a 
> way where same index definition gets used in both.
> As discussed on DL [1] this can be done by
> # Making {{async}} as a multi value property.
> # Introducing a new IndexEditorProvider interface which can accept an 
> IndexingContext instance. This provides access to 
> ## indexing mode - sync or async
> ## index path of the index (see OAK-4152)
> ## CommitInfo (see OAK-4640)
> [1] 
> http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201608.mbox/%3CCAHCW-mk1HzAxy8fk17SzYDcfLYY%3D0HUp93FCYoxpTP37cNgb%2Bg%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)