[jira] [Commented] (OAK-4648) Improve documentation about structure of TAR files

2017-02-01 Thread Andrei Dulceanu (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848448#comment-15848448
 ] 

Andrei Dulceanu commented on OAK-4648:
--

I agree, let's close it.

> Improve documentation about structure of TAR files
> --
>
> Key: OAK-4648
> URL: https://issues.apache.org/jira/browse/OAK-4648
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: doc, segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
>  Labels: documentation
> Fix For: 1.8, 1.6.1
>
> Attachments: OAK-4648.patch
>
>
> Improve the page at [1] to include a picture of the contents of a TAR file, 
> as done for segments in [2], to cover missing parts (e.g. binary references 
> files) and to better align it with latest oak-segment-tar improvements.
> [1] http://jackrabbit.apache.org/oak/docs/nodestore/segment/tar.html
> [2] http://jackrabbit.apache.org/oak/docs/nodestore/segment/records.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OAK-4648) Improve documentation about structure of TAR files

2017-02-01 Thread JIRA

[ 
https://issues.apache.org/jira/browse/OAK-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848445#comment-15848445
 ] 

Michael Dürig commented on OAK-4648:


+1, LGTM

> Improve documentation about structure of TAR files
> --
>
> Key: OAK-4648
> URL: https://issues.apache.org/jira/browse/OAK-4648
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: doc, segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
>  Labels: documentation
> Fix For: 1.8, 1.6.1
>
> Attachments: OAK-4648.patch
>
>
> Improve the page at [1] to include a picture of the contents of a TAR file, 
> as done for segments in [2], to cover missing parts (e.g. binary references 
> files) and to better align it with latest oak-segment-tar improvements.
> [1] http://jackrabbit.apache.org/oak/docs/nodestore/segment/tar.html
> [2] http://jackrabbit.apache.org/oak/docs/nodestore/segment/records.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OAK-4648) Improve documentation about structure of TAR files

2017-02-01 Thread Francesco Mari (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848437#comment-15848437
 ] 

Francesco Mari commented on OAK-4648:
-

I think we can resolve this. [~dulceanu], [~mduerig], what do you think?

> Improve documentation about structure of TAR files
> --
>
> Key: OAK-4648
> URL: https://issues.apache.org/jira/browse/OAK-4648
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: doc, segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
>  Labels: documentation
> Fix For: 1.8, 1.6.1
>
> Attachments: OAK-4648.patch
>
>
> Improve the page at [1] to include a picture of the contents of a TAR file, 
> as done for segments in [2], to cover missing parts (e.g. binary references 
> files) and to better align it with latest oak-segment-tar improvements.
> [1] http://jackrabbit.apache.org/oak/docs/nodestore/segment/tar.html
> [2] http://jackrabbit.apache.org/oak/docs/nodestore/segment/records.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OAK-4648) Improve documentation about structure of TAR files

2017-01-27 Thread Andrei Dulceanu (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842710#comment-15842710
 ] 

Andrei Dulceanu commented on OAK-4648:
--

Committed at r1780547. I will wait for your feedback before resolving this 
issue.

> Improve documentation about structure of TAR files
> --
>
> Key: OAK-4648
> URL: https://issues.apache.org/jira/browse/OAK-4648
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: doc, segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
>  Labels: documentation
> Fix For: 1.6
>
> Attachments: OAK-4648.patch
>
>
> Improve the page at [1] to include a picture of the contents of a TAR file, 
> as done for segments in [2], to cover missing parts (e.g. binary references 
> files) and to better align it with latest oak-segment-tar improvements.
> [1] http://jackrabbit.apache.org/oak/docs/nodestore/segment/tar.html
> [2] http://jackrabbit.apache.org/oak/docs/nodestore/segment/records.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4648) Improve documentation about structure of TAR files

2017-01-27 Thread Francesco Mari (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842644#comment-15842644
 ] 

Francesco Mari commented on OAK-4648:
-

At a first glance, everything seems alright. Please go ahead and commit your 
changes, but don't resolve this issue yet. Let's give me and [~mduerig] a 
possibility to review and edit the changes, if needed.

> Improve documentation about structure of TAR files
> --
>
> Key: OAK-4648
> URL: https://issues.apache.org/jira/browse/OAK-4648
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: doc, segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
>  Labels: documentation
> Fix For: 1.6
>
> Attachments: OAK-4648.patch
>
>
> Improve the page at [1] to include a picture of the contents of a TAR file, 
> as done for segments in [2], to cover missing parts (e.g. binary references 
> files) and to better align it with latest oak-segment-tar improvements.
> [1] http://jackrabbit.apache.org/oak/docs/nodestore/segment/tar.html
> [2] http://jackrabbit.apache.org/oak/docs/nodestore/segment/records.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OAK-4648) Improve documentation about structure of TAR files

2016-08-04 Thread Francesco Mari (JIRA)

[ 
https://issues.apache.org/jira/browse/OAK-4648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407826#comment-15407826
 ] 

Francesco Mari commented on OAK-4648:
-

That's a very nice idea. I would wait a bit until oak-segment-tar reaches a 
more stable state, to avoid making these changes again and again.

> Improve documentation about structure of TAR files
> --
>
> Key: OAK-4648
> URL: https://issues.apache.org/jira/browse/OAK-4648
> Project: Jackrabbit Oak
>  Issue Type: Documentation
>  Components: segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
>
> Improve the page at [1] to include a picture of the contents of a TAR file, 
> as done for segments in [2], to cover missing parts (e.g. binary references 
> files) and to better align it with latest oak-segment-tar improvements.
> [1] http://jackrabbit.apache.org/oak/docs/nodestore/segment/tar.html
> [2] http://jackrabbit.apache.org/oak/docs/nodestore/segment/records.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)