[jira] [Commented] (OAK-5106) Reuse NioEventLoopGroup in standby client

2016-11-14 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-5106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15665324#comment-15665324
 ] 

Michael Dürig commented on OAK-5106:


Thanks [~marett], this fixes the failing build on my end. I cannot comment on 
the particulars of the patch, leaving this to [~frm].

> Reuse NioEventLoopGroup in standby client
> -
>
> Key: OAK-5106
> URL: https://issues.apache.org/jira/browse/OAK-5106
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: segment-tar
>Affects Versions: 1.5.13
>Reporter: Timothee Maret
>Assignee: Timothee Maret
> Fix For: 1.5.14
>
> Attachments: OAK-5106.patch
>
>
> The Standby client code does instantiate a new {{NioEventLoopGroup}} for 
> every cycle (5 seconds). The standby tests do instantiate many 
> {{NioEventLoopGroup}}.
> Although {{NioEventLoopGroup}} are closed properly, each of them consume 
> files and management overhead (seting up/down). An improvement would be to 
> reuse the {{NioEventLoopGroup}} in standby client across polling cycles and 
> reuse {{NioEventLoopGroup}} in the test code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (OAK-5106) Reuse NioEventLoopGroup in standby client

2016-11-14 Thread Timothee Maret (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-5106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15664894#comment-15664894
 ] 

Timothee Maret commented on OAK-5106:
-

IT tests used to run with ~4'000 files opened at the same time. With the patch, 
it is reduced to < 500. 

[~frm], [~mduerig] could you have a look at the patch ?

> Reuse NioEventLoopGroup in standby client
> -
>
> Key: OAK-5106
> URL: https://issues.apache.org/jira/browse/OAK-5106
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: segment-tar
>Affects Versions: 1.5.13
>Reporter: Timothee Maret
>Assignee: Timothee Maret
> Fix For: 1.5.14
>
> Attachments: OAK-5106.patch
>
>
> The Standby client code does instantiate a new {{NioEventLoopGroup}} for 
> every cycle (5 seconds). The standby tests do instantiate many 
> {{NioEventLoopGroup}}.
> Although {{NioEventLoopGroup}} are closed properly, each of them consume 
> files and management overhead (seting up/down). An improvement would be to 
> reuse the {{NioEventLoopGroup}} in standby client across polling cycles and 
> reuse {{NioEventLoopGroup}} in the test code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)