[jira] [Commented] (OAK-5412) Use GCMonitor for revision gc task run in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000543#comment-16000543 ] Marcel Reutegger commented on OAK-5412: --- Fixed occasional test failures in trunk: http://svn.apache.org/r1794310 > Use GCMonitor for revision gc task run in DocumentNodeStore > --- > > Key: OAK-5412 > URL: https://issues.apache.org/jira/browse/OAK-5412 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, documentmk >Reporter: Chetan Mehrotra >Assignee: Marcel Reutegger > Fix For: 1.7.0, 1.8 > > Attachments: OAK-5412.patch > > > DocumentNodeStore should use {{GCMonitor}} to inform interested parties about > GC task progress (similar to how its used in SegmentNodeStore) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-5412) Use GCMonitor for revision gc task run in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994474#comment-15994474 ] Marcel Reutegger commented on OAK-5412: --- Moved the Closer refactoring to OAK-6154. > Use GCMonitor for revision gc task run in DocumentNodeStore > --- > > Key: OAK-5412 > URL: https://issues.apache.org/jira/browse/OAK-5412 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, documentmk >Reporter: Chetan Mehrotra >Assignee: Marcel Reutegger > Fix For: 1.8 > > Attachments: OAK-5412.patch > > > DocumentNodeStore should use {{GCMonitor}} to inform interested parties about > GC task progress (similar to how its used in SegmentNodeStore) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-5412) Use GCMonitor for revision gc task run in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994469#comment-15994469 ] Marcel Reutegger commented on OAK-5412: --- {{LoggingGCMonitor}} is segment-tar specific and cannot be used by {{VersionGarbageCollector}}. Similar functionality in the patch is implemented in {{VersionGarbageCollector.VersionGCMonitor}}, which is combined with the {{GCMonitor}} provided in the {{DocumentMK.Builder}} using a {{DelegatingGCMonitor}} in the {{GCJob}} constructor. > Use GCMonitor for revision gc task run in DocumentNodeStore > --- > > Key: OAK-5412 > URL: https://issues.apache.org/jira/browse/OAK-5412 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, documentmk >Reporter: Chetan Mehrotra >Assignee: Marcel Reutegger > Fix For: 1.8 > > Attachments: OAK-5412.patch > > > DocumentNodeStore should use {{GCMonitor}} to inform interested parties about > GC task progress (similar to how its used in SegmentNodeStore) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-5412) Use GCMonitor for revision gc task run in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994470#comment-15994470 ] Marcel Reutegger commented on OAK-5412: --- {{LoggingGCMonitor}} is segment-tar specific and cannot be used by {{VersionGarbageCollector}}. Similar functionality in the patch is implemented in {{VersionGarbageCollector.VersionGCMonitor}}, which is combined with the {{GCMonitor}} provided in the {{DocumentMK.Builder}} using a {{DelegatingGCMonitor}} in the {{GCJob}} constructor. > Use GCMonitor for revision gc task run in DocumentNodeStore > --- > > Key: OAK-5412 > URL: https://issues.apache.org/jira/browse/OAK-5412 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, documentmk >Reporter: Chetan Mehrotra >Assignee: Marcel Reutegger > Fix For: 1.8 > > Attachments: OAK-5412.patch > > > DocumentNodeStore should use {{GCMonitor}} to inform interested parties about > GC task progress (similar to how its used in SegmentNodeStore) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-5412) Use GCMonitor for revision gc task run in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994451#comment-15994451 ] Chetan Mehrotra commented on OAK-5412: -- I was suggesting to wire it manually i.e. construct a DelegatingGCMonitor which is composed of LoggingGCMonitor and GCMonitorTracker > Use GCMonitor for revision gc task run in DocumentNodeStore > --- > > Key: OAK-5412 > URL: https://issues.apache.org/jira/browse/OAK-5412 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, documentmk >Reporter: Chetan Mehrotra >Assignee: Marcel Reutegger > Fix For: 1.8 > > Attachments: OAK-5412.patch > > > DocumentNodeStore should use {{GCMonitor}} to inform interested parties about > GC task progress (similar to how its used in SegmentNodeStore) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-5412) Use GCMonitor for revision gc task run in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994399#comment-15994399 ] Marcel Reutegger commented on OAK-5412: --- Thanks for the review. Agreed on the separate issue for the refactoring. I'm not sure I understand the second comment related to {{LoggingGCMonitor}}. Do you suggest to register the LoggingGCMonitor with the whiteboard instead of wiring it manually? > Use GCMonitor for revision gc task run in DocumentNodeStore > --- > > Key: OAK-5412 > URL: https://issues.apache.org/jira/browse/OAK-5412 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, documentmk >Reporter: Chetan Mehrotra >Assignee: Marcel Reutegger > Fix For: 1.8 > > Attachments: OAK-5412.patch > > > DocumentNodeStore should use {{GCMonitor}} to inform interested parties about > GC task progress (similar to how its used in SegmentNodeStore) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-5412) Use GCMonitor for revision gc task run in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-5412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994279#comment-15994279 ] Chetan Mehrotra commented on OAK-5412: -- Looks good. # May be break the commit in 2 where ## Refactoring related to use of Closer and ## Changes required for GCMonitor support # From use in Segment it appears that LoggingGCMonitor is not enabled as a service by default and needs to be explicitly used/configured. So may be we need to use DelegatingGCMonitor which used LoggingGCMonitor and GCMonitorTracker (/cc [~mduerig] ) > Use GCMonitor for revision gc task run in DocumentNodeStore > --- > > Key: OAK-5412 > URL: https://issues.apache.org/jira/browse/OAK-5412 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, documentmk >Reporter: Chetan Mehrotra >Assignee: Marcel Reutegger > Fix For: 1.8 > > Attachments: OAK-5412.patch > > > DocumentNodeStore should use {{GCMonitor}} to inform interested parties about > GC task progress (similar to how its used in SegmentNodeStore) -- This message was sent by Atlassian JIRA (v6.3.15#6346)