[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007960#comment-16007960 ] Tomek Rękawek commented on OAK-6136: After discussion on the oak-dev, the name is changed to oak-store-composite. Renamed in [r1794954|https://svn.apache.org/r1794954]. > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: federated >Reporter: Robert Munteanu >Assignee: Julian Sedding > Fix For: 1.7.0, 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998200#comment-15998200 ] Tomek Rękawek commented on OAK-6136: bq. Mabye we can try and ask on oak-dev for more ideas? Done :) > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: federated >Reporter: Robert Munteanu >Assignee: Julian Sedding > Fix For: 1.7.0, 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[
https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998168#comment-15998168
]
Robert Munteanu commented on OAK-6136:
--
[~tomek.rekawek] - no need to wait for my vote :-) I was mostly offline anyway
so that would've been quite hard.
{quote}In our case, the existing service is a node store and each of them has
to be a fully functional and working implementation.{quote}
That is where I think the difference lies between our views. For me a partially
populated node store, even though technically fully functional, is not usable
from a client perspective. Only when multiple node store mounts are put
together can they be exposed. Consider a Sling application with two mounts:
- /libs and /apps
- everything else
Even though both mounts are available to be used independently, they don't make
sense in isolation. The /libs and /apps mount has no content to serve, while
the main mount does not know how to serve content. Only when put together do
they work as intended.
So I am worried that advertising that Oak supports 'federation' will lead to
confusion and to false expectations regarding what this feature actually does.
Another point on multiplexing vs federation - federation is a high-level
concept while multiplexing is a low-level one - which matches the level of our
implementation - the NodeStore work we've done is quite low-level. I am not
attached to multiplexing, but I don't think federation is the right term here.
Mabye we can try and ask on oak-dev for more ideas?
> Extract the multiplexing implementation code into a separate bundle
> ---
>
> Key: OAK-6136
> URL: https://issues.apache.org/jira/browse/OAK-6136
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: federated
>Reporter: Robert Munteanu
>Assignee: Julian Sedding
> Fix For: 1.7.0, 1.8
>
> Attachments:
> 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch,
> OAK-6136.patch
>
>
> Since we already kicked off the m12n effort for 1.8 it would be good to
> separate the multiplexing implementation from oak-core into its own bundle as
> well.
> I will look into providing a patch for the change.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994851#comment-15994851 ] Tomek Rękawek commented on OAK-6136: Hi [~rombert], first of all - my apologies for not waiting for your vote. I thought that two +1 is enough and didn't see you on IM to ask directly, but I should wait anyway. bq. Federation to me see to be about different services becoming interoperable More importantly I think it's about existing services that work in a standalone fashion but can also work together - in a federated mode. \[...\] In our scenario the mounts - those which we assemble - are not really usable by themselves as they only contain a part of the repository. In our case, the existing service is a node store and each of them has to be a fully functional and working implementation. I think the [federated MySQL|https://dev.mysql.com/doc/refman/5.7/en/federated-description.html] engine is quite similar to what we have: * Federated Table <-> mount list * Remote Server <-> partial node store * Remote Table <-> mounted subtree on the partial node store bq. I think multiplexing is a better metaphor. It originally was about combining multiple signals into a single one. I have no experience with telecommunications so I won't comment on that but for me the concept of combining multiple parts into a larger one is closer to what we offer with our implementation. I think that in case of multiplexing, each partial signal represents a value on its own, is independent from the others and is not meant to be used together with them. On the other hand, the multiplexed signal is just a noise and can't be used directly. The only reason why it exists is that it's easy to transport and store. Before using it, it has to be demultiplexed first - and as a result we get the original, partial signals. So, the MultiplexingNodeStore name suggest that we're providing a way to create a few independent node store instances using the same underlying physical node store (which is an interesting exercise as well and shouldn't be too hard, considering our data model). But our case it's the opposite - we want to use the combined store directly and we don't care much how the data are persisted in the partial stores. That's why I still think the "federated" is a better adjective here. WDYT? > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: federated >Reporter: Robert Munteanu >Assignee: Julian Sedding > Fix For: 1.7.0, 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994618#comment-15994618 ] Robert Munteanu commented on OAK-6136: -- I am not sure that federation is the proper term for what we currently have ( and also for what we want to have ) in Oak. Federation to me see to be about different services becoming interoperable More importantly I think it's about existing services that work in a standalone fashion but can also work together - in a federated mode. See - https://dev.mysql.com/doc/refman/5.7/en/federated-storage-engine.html - https://en.wikipedia.org/wiki/Federated_database_system In our scenario the mounts - those which we assemble - are not really usable by themselves as they only contain a part of the repository. I think multiplexing is a better metaphor. It originally was about combining multiple signals into a single one. I have no experience with telecommunications so I won't comment on that but for me the concept of combining multiple parts into a larger one is closer to what we offer with our implementation. So yes, naming is tricky, multiplexing is maybe not the best option, but I think federation gets us further from what we actually do. > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: federated >Reporter: Robert Munteanu >Assignee: Julian Sedding > Fix For: 1.7.0, 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992830#comment-15992830 ] Alex Parvulescu commented on OAK-6136: -- bq. if you think it's a good idea, feel free to rename it as well. I'll leave it to [~chetanm] to decide what is best in this area. > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: federated >Reporter: Robert Munteanu >Assignee: Julian Sedding > Fix For: 1.7.0, 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992823#comment-15992823 ] Tomek Rękawek commented on OAK-6136: The only parts of the code referencing the "multiplexing" keyword is the indexing logic in oak-core and oak-lucene. [~alex.parvulescu], if you think it's a good idea, feel free to rename it as well. > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: federated >Reporter: Robert Munteanu >Assignee: Julian Sedding > Fix For: 1.7.0, 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992818#comment-15992818 ] Tomek Rękawek commented on OAK-6136: Done. The oak-multiplex module was renamed to oak-store-federated in [r1793482|https://svn.apache.org/r1793482]. Also, I've renamed all the class names and doc references. > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: federated >Reporter: Robert Munteanu >Assignee: Julian Sedding > Fix For: 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992777#comment-15992777 ] Chetan Mehrotra commented on OAK-6136: -- bq. The proposed module name: oak-store-federated. +1. Federated store is more apt name and right now we do not have much baggage. So easy to rename. > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Assignee: Julian Sedding > Fix For: 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992756#comment-15992756 ] Michael Dürig commented on OAK-6136: Even better, agreed. > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Assignee: Julian Sedding > Fix For: 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992755#comment-15992755 ] Tomek Rękawek commented on OAK-6136: Since we're here, how about renaming the Multiplexing Node Store to Federated Node Store? "Multiplexing" may give an impression that we allow to create a few separate Oak instances/node stores on a single physical node store, while it's quite the opposite. > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Assignee: Julian Sedding > Fix For: 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992571#comment-15992571 ] Robert Munteanu commented on OAK-6136: -- Makes sense to me, unless we want to add any potential blob store implementation in the same project. > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Assignee: Julian Sedding > Fix For: 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[
https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992564#comment-15992564
]
Michael Dürig commented on OAK-6136:
Would it make sense to name this module {{oak-store-multiplex}}? This name
would imply a bit more about what it is while at the same time placing in next
to {{oak-store-spi}}.
> Extract the multiplexing implementation code into a separate bundle
> ---
>
> Key: OAK-6136
> URL: https://issues.apache.org/jira/browse/OAK-6136
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
>Assignee: Julian Sedding
> Fix For: 1.8
>
> Attachments:
> 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch,
> OAK-6136.patch
>
>
> Since we already kicked off the m12n effort for 1.8 it would be good to
> separate the multiplexing implementation from oak-core into its own bundle as
> well.
> I will look into providing a patch for the change.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988625#comment-15988625 ] Julian Sedding commented on OAK-6136: - [~rombert] sure, I'll do it. > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[
https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988612#comment-15988612
]
Robert Munteanu commented on OAK-6136:
--
[~jsedding] - thanks for the review and the contribution. Would you have time
to commit the patch as well? The full build ({{-PintegrationTesting}}) passed
for me with the attached diff.
> Extract the multiplexing implementation code into a separate bundle
> ---
>
> Key: OAK-6136
> URL: https://issues.apache.org/jira/browse/OAK-6136
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8
>
> Attachments:
> 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch,
> OAK-6136.patch
>
>
> Since we already kicked off the m12n effort for 1.8 it would be good to
> separate the multiplexing implementation from oak-core into its own bundle as
> well.
> I will look into providing a patch for the change.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988574#comment-15988574 ] Julian Sedding commented on OAK-6136: - [~rombert] the merged patch looks fine to me. Thanks. > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch, > OAK-6136.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988526#comment-15988526 ] Julian Sedding commented on OAK-6136: - [~rombert] I have the changes on [a branch on github|https://github.com/code-distillery/jackrabbit-oak/tree/feature/OAK-6136-move-mount-info-to-spi]. Feel free to pull them in. > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[ https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988401#comment-15988401 ] Robert Munteanu commented on OAK-6136: -- [~jsedding] - that sounds good to me. Do you have a patch ready or should I prepare one? > Extract the multiplexing implementation code into a separate bundle > --- > > Key: OAK-6136 > URL: https://issues.apache.org/jira/browse/OAK-6136 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu > Fix For: 1.8 > > Attachments: > 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch > > > Since we already kicked off the m12n effort for 1.8 it would be good to > separate the multiplexing implementation from oak-core into its own bundle as > well. > I will look into providing a patch for the change. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OAK-6136) Extract the multiplexing implementation code into a separate bundle
[
https://issues.apache.org/jira/browse/OAK-6136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986884#comment-15986884
]
Julian Sedding commented on OAK-6136:
-
[~rombert] what about the following
- move SimpleMountInfoProvider and MountInfo to o.a.j.oak.spi.mount with
package private access
- move {{SimpleMountInfoProvider.Builder}} to {{Mounts.Builder}} and
{{SimpleMountInfoProvider.newBuilder()}} to {{Mounts.builder()}}
- add a method to the {{Builder}} to support {{pathsSupportingFragments}} and
refactor usages accordingly
I think having a simple way to build {{MountInfoProvider}}s fits into the
{{Mounts}} class and we hide {{SimpleMountInfoProvider}} and {{MountInfo}}. As
a side-effect we can get rid of the awkward dependency from {{oak-core}} and
{{oak-lucene}} to {{oak-multiplex}}.
WDYT? I'm happy to commit these changes. I can also attach a patch, but it's
noisy due to changes in all consumers of {{SimpleMountInfoProvider}}.
> Extract the multiplexing implementation code into a separate bundle
> ---
>
> Key: OAK-6136
> URL: https://issues.apache.org/jira/browse/OAK-6136
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8
>
> Attachments:
> 0001-OAK-6136-Extract-the-multiplexing-implementation-cod.patch
>
>
> Since we already kicked off the m12n effort for 1.8 it would be good to
> separate the multiplexing implementation from oak-core into its own bundle as
> well.
> I will look into providing a patch for the change.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
