[jira] [Commented] (OAK-6803) Provide a way to for persistent cache to determine which all nodes can be cached
[ https://issues.apache.org/jira/browse/OAK-6803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201577#comment-16201577 ] Chetan Mehrotra commented on OAK-6803: -- Applied the patch with 1811918 and 1811919 > Provide a way to for persistent cache to determine which all nodes can be > cached > > > Key: OAK-6803 > URL: https://issues.apache.org/jira/browse/OAK-6803 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Labels: doc-impacting > Fix For: 1.8 > > Attachments: OAK-6803-v1.patch, OAK-6803-v2.patch > > > Currently persistent cache if enabled for nodes caches all nodes accessed on > the system. It would be better if it can be configured to only cache those > nodes which are not volatile so that caching can be effective > Purpose of this issue is to > * Provide an extension point in PersistentCache logic to check if a node is > to be cached > * Provide an impl which relies on some static OSGi config to determine that > Later we can make this impl dynamic i.e. rely on access pattern to cache imp > stuff -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6803) Provide a way to for persistent cache to determine which all nodes can be cached
[ https://issues.apache.org/jira/browse/OAK-6803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201542#comment-16201542 ] Marcel Reutegger commented on OAK-6803: --- Looks good to me. +1 for applying the patch. > Provide a way to for persistent cache to determine which all nodes can be > cached > > > Key: OAK-6803 > URL: https://issues.apache.org/jira/browse/OAK-6803 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.8 > > Attachments: OAK-6803-v1.patch, OAK-6803-v2.patch > > > Currently persistent cache if enabled for nodes caches all nodes accessed on > the system. It would be better if it can be configured to only cache those > nodes which are not volatile so that caching can be effective > Purpose of this issue is to > * Provide an extension point in PersistentCache logic to check if a node is > to be cached > * Provide an impl which relies on some static OSGi config to determine that > Later we can make this impl dynamic i.e. rely on access pattern to cache imp > stuff -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6803) Provide a way to for persistent cache to determine which all nodes can be cached
[ https://issues.apache.org/jira/browse/OAK-6803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198423#comment-16198423 ] Chetan Mehrotra commented on OAK-6803: -- Missed that. Okie would change createCachePredicate as per below # if default config is found then it would return alwaysTrue # if config array is empty then also alwaysTrue (or should we disable persistent cache then?) # if non empty and non default use a PathFilter > Provide a way to for persistent cache to determine which all nodes can be > cached > > > Key: OAK-6803 > URL: https://issues.apache.org/jira/browse/OAK-6803 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.8 > > Attachments: OAK-6803-v1.patch > > > Currently persistent cache if enabled for nodes caches all nodes accessed on > the system. It would be better if it can be configured to only cache those > nodes which are not volatile so that caching can be effective > Purpose of this issue is to > * Provide an extension point in PersistentCache logic to check if a node is > to be cached > * Provide an impl which relies on some static OSGi config to determine that > Later we can make this impl dynamic i.e. rely on access pattern to cache imp > stuff -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6803) Provide a way to for persistent cache to determine which all nodes can be cached
[ https://issues.apache.org/jira/browse/OAK-6803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198374#comment-16198374 ] Marcel Reutegger commented on OAK-6803: --- Can you also share some benchmark runs that measure the impact of the such a filter? > Provide a way to for persistent cache to determine which all nodes can be > cached > > > Key: OAK-6803 > URL: https://issues.apache.org/jira/browse/OAK-6803 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.8 > > Attachments: OAK-6803-v1.patch > > > Currently persistent cache if enabled for nodes caches all nodes accessed on > the system. It would be better if it can be configured to only cache those > nodes which are not volatile so that caching can be effective > Purpose of this issue is to > * Provide an extension point in PersistentCache logic to check if a node is > to be cached > * Provide an impl which relies on some static OSGi config to determine that > Later we can make this impl dynamic i.e. rely on access pattern to cache imp > stuff -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-6803) Provide a way to for persistent cache to determine which all nodes can be cached
[
https://issues.apache.org/jira/browse/OAK-6803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16198373#comment-16198373
]
Marcel Reutegger commented on OAK-6803:
---
Looks good, but I would also special case the default configuration in
{{createCachePredicate()}} and return {{Predicates.alwaysTrue()}} for that case
as well. IIUC, the special case in the patch is for the empty configuration
list.
> Provide a way to for persistent cache to determine which all nodes can be
> cached
>
>
> Key: OAK-6803
> URL: https://issues.apache.org/jira/browse/OAK-6803
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: 1.8
>
> Attachments: OAK-6803-v1.patch
>
>
> Currently persistent cache if enabled for nodes caches all nodes accessed on
> the system. It would be better if it can be configured to only cache those
> nodes which are not volatile so that caching can be effective
> Purpose of this issue is to
> * Provide an extension point in PersistentCache logic to check if a node is
> to be cached
> * Provide an impl which relies on some static OSGi config to determine that
> Later we can make this impl dynamic i.e. rely on access pattern to cache imp
> stuff
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
