[jira] [Commented] (OAK-715) Don't share name space map between SessionImpl and LocalNameMapper

2024-01-18 Thread Julian Reschke (Jira) 


[ 
https://issues.apache.org/jira/browse/OAK-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808164#comment-17808164
 ] 

Julian Reschke commented on OAK-715:


There are two fundamental problems with this change.

1. It doesn't work consistenty (see OAK-10544).
2. It replaces one type of close coupling (shared map) with an even worse type 
of coupling (assuming that two different layers will choose the same 
replacement prefix).

> Don't share name space map between SessionImpl and LocalNameMapper
> --
>
> Key: OAK-715
> URL: https://issues.apache.org/jira/browse/OAK-715
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: core, jcr
>Reporter: Michael Dürig
>Assignee: Marcel Reutegger
>Priority: Major
> Fix For: 0.7
>
> Attachments: OAK-715.patch
>
>
> Currently {{SessionImpl}} and {{LocalNameMaper}} share and communicate via 
> the shared name space map. This is bad design and even more so since the map 
> is shared across component boundaries and access to the map needs to be 
> explicitly synchronized. See OAK-714. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-715) Don't share name space map between SessionImpl and LocalNameMapper

2023-11-09 Thread Julian Reschke (Jira) 


[ 
https://issues.apache.org/jira/browse/OAK-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784411#comment-17784411
 ] 

Julian Reschke commented on OAK-715:


trunk: (1.9.0) 
[ed904c0f54|https://github.com/apache/jackrabbit-oak/commit/ed904c0f54b728ce865408cc1433c9ccc228ec1b]
 
[d021f362dd|https://github.com/apache/jackrabbit-oak/commit/d021f362dd2047f1226bc5e57285fabd598bd5a4]
 
[e666aaa5bb|https://github.com/apache/jackrabbit-oak/commit/e666aaa5bb94c3fabac66244e9b0e55883e7d65d]
 
[599e1d4cf5|https://github.com/apache/jackrabbit-oak/commit/599e1d4cf522ef22f8da06b703037bd040d6208d]
 
[2913d5f184|https://github.com/apache/jackrabbit-oak/commit/2913d5f184e17d7bfa68cf4fcac973800c02c956]
 
[4588fd595e|https://github.com/apache/jackrabbit-oak/commit/4588fd595eaf42bf4b09d0fedb43edf173d389b7]
 
[fe3c5f5248|https://github.com/apache/jackrabbit-oak/commit/fe3c5f524881e5e626f70b44202976cf631559f9]
 
[fe9ae77dcd|https://github.com/apache/jackrabbit-oak/commit/fe9ae77dcde90adfba3c546633d93b72b6fc04f3]
 
[534f5fd190|https://github.com/apache/jackrabbit-oak/commit/534f5fd190eaa8f34e1d2ad5f596d25defdf94f1]
 
[97bd36850e|https://github.com/apache/jackrabbit-oak/commit/97bd36850e12e13983b900a391a57990f793a6e9]
 
[4e455a8ea0|https://github.com/apache/jackrabbit-oak/commit/4e455a8ea0673bb540a318dc5f8177ac7da1ff52]
 (0.10) 
[9326286a04|https://github.com/apache/jackrabbit-oak/commit/9326286a047bb42687bb21cca96dd622d2089262]
 (0.8) 
[250bcb5ba4|https://github.com/apache/jackrabbit-oak/commit/250bcb5ba4e0e8841d7c4d0378ba7ff85f10ded3]
 
[2f0b933fce|https://github.com/apache/jackrabbit-oak/commit/2f0b933fce22c65b9d0faa952c1179bcc831324b]
 
[ede21a3cb5|https://github.com/apache/jackrabbit-oak/commit/ede21a3cb56dd9e24333a2a0c45963dd8b9e36ce]
 
[b695f60ae5|https://github.com/apache/jackrabbit-oak/commit/b695f60ae5e89a2638281029b62d821b2fff614f]
1.22: (1.9.0) 
[ed904c0f54|https://github.com/apache/jackrabbit-oak/commit/ed904c0f54b728ce865408cc1433c9ccc228ec1b]
 
[d021f362dd|https://github.com/apache/jackrabbit-oak/commit/d021f362dd2047f1226bc5e57285fabd598bd5a4]
 
[e666aaa5bb|https://github.com/apache/jackrabbit-oak/commit/e666aaa5bb94c3fabac66244e9b0e55883e7d65d]
 
[599e1d4cf5|https://github.com/apache/jackrabbit-oak/commit/599e1d4cf522ef22f8da06b703037bd040d6208d]
 
[2913d5f184|https://github.com/apache/jackrabbit-oak/commit/2913d5f184e17d7bfa68cf4fcac973800c02c956]
 
[4588fd595e|https://github.com/apache/jackrabbit-oak/commit/4588fd595eaf42bf4b09d0fedb43edf173d389b7]
 
[fe3c5f5248|https://github.com/apache/jackrabbit-oak/commit/fe3c5f524881e5e626f70b44202976cf631559f9]
 
[fe9ae77dcd|https://github.com/apache/jackrabbit-oak/commit/fe9ae77dcde90adfba3c546633d93b72b6fc04f3]
 
[534f5fd190|https://github.com/apache/jackrabbit-oak/commit/534f5fd190eaa8f34e1d2ad5f596d25defdf94f1]
 
[97bd36850e|https://github.com/apache/jackrabbit-oak/commit/97bd36850e12e13983b900a391a57990f793a6e9]
 
[4e455a8ea0|https://github.com/apache/jackrabbit-oak/commit/4e455a8ea0673bb540a318dc5f8177ac7da1ff52]
 (0.10) 
[9326286a04|https://github.com/apache/jackrabbit-oak/commit/9326286a047bb42687bb21cca96dd622d2089262]
 (0.8) 
[250bcb5ba4|https://github.com/apache/jackrabbit-oak/commit/250bcb5ba4e0e8841d7c4d0378ba7ff85f10ded3]
 
[2f0b933fce|https://github.com/apache/jackrabbit-oak/commit/2f0b933fce22c65b9d0faa952c1179bcc831324b]
 
[ede21a3cb5|https://github.com/apache/jackrabbit-oak/commit/ede21a3cb56dd9e24333a2a0c45963dd8b9e36ce]
 
[b695f60ae5|https://github.com/apache/jackrabbit-oak/commit/b695f60ae5e89a2638281029b62d821b2fff614f]

...in retired branches:
1.10: (1.9.0) 
[ed904c0f54|https://github.com/apache/jackrabbit-oak/commit/ed904c0f54b728ce865408cc1433c9ccc228ec1b]
 
[d021f362dd|https://github.com/apache/jackrabbit-oak/commit/d021f362dd2047f1226bc5e57285fabd598bd5a4]
 
[e666aaa5bb|https://github.com/apache/jackrabbit-oak/commit/e666aaa5bb94c3fabac66244e9b0e55883e7d65d]
 
[599e1d4cf5|https://github.com/apache/jackrabbit-oak/commit/599e1d4cf522ef22f8da06b703037bd040d6208d]
 
[2913d5f184|https://github.com/apache/jackrabbit-oak/commit/2913d5f184e17d7bfa68cf4fcac973800c02c956]
 
[4588fd595e|https://github.com/apache/jackrabbit-oak/commit/4588fd595eaf42bf4b09d0fedb43edf173d389b7]
 
[fe3c5f5248|https://github.com/apache/jackrabbit-oak/commit/fe3c5f524881e5e626f70b44202976cf631559f9]
 
[fe9ae77dcd|https://github.com/apache/jackrabbit-oak/commit/fe9ae77dcde90adfba3c546633d93b72b6fc04f3]
 
[534f5fd190|https://github.com/apache/jackrabbit-oak/commit/534f5fd190eaa8f34e1d2ad5f596d25defdf94f1]
 
[97bd36850e|https://github.com/apache/jackrabbit-oak/commit/97bd36850e12e13983b900a391a57990f793a6e9]
 
[4e455a8ea0|https://github.com/apache/jackrabbit-oak/commit/4e455a8ea0673bb540a318dc5f8177ac7da1ff52]
 (0.10) 
[9326286a04|https://github.com/apache/jackrabbit-oak/commit/9326286a047bb42687bb21cca96dd622d2089262]
 (0.8)

[jira] [Commented] (OAK-715) Don't share name space map between SessionImpl and LocalNameMapper

2013-04-02 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619734#comment-13619734
 ] 

Michael Dürig commented on OAK-715:
---

Nice! Just one minor point, which caught my eye: I'd either make 
{{SessionNameSpaces}} public or {{SessionContext#getNamespaces()}} package 
private.



 Don't share name space map between SessionImpl and LocalNameMapper
 --

 Key: OAK-715
 URL: https://issues.apache.org/jira/browse/OAK-715
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: core, jcr
Reporter: Michael Dürig
Assignee: Marcel Reutegger
 Attachments: OAK-715.patch


 Currently {{SessionImpl}} and {{LocalNameMaper}} share and communicate via 
 the shared name space map. This is bad design and even more so since the map 
 is shared across component boundaries and access to the map needs to be 
 explicitly synchronized. See OAK-714. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (OAK-715) Don't share name space map between SessionImpl and LocalNameMapper

2013-04-02 Thread Marcel Reutegger (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619831#comment-13619831
 ] 

Marcel Reutegger commented on OAK-715:
--

No worries. I don't like this write acess to the mapping on read. I think it 
should be possible to auto generate the prefix in question when the remapping 
happens.

 Don't share name space map between SessionImpl and LocalNameMapper
 --

 Key: OAK-715
 URL: https://issues.apache.org/jira/browse/OAK-715
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: core, jcr
Reporter: Michael Dürig
Assignee: Marcel Reutegger
 Fix For: 0.7

 Attachments: OAK-715.patch


 Currently {{SessionImpl}} and {{LocalNameMaper}} share and communicate via 
 the shared name space map. This is bad design and even more so since the map 
 is shared across component boundaries and access to the map needs to be 
 explicitly synchronized. See OAK-714. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira