[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17014129#comment-17014129 ] Vikas Saurabh commented on OAK-7151: [~thomasm] iirc, I had kept this one open for adding test; which clearly didn't happen. I think this change has passed the test of time at least from regression pov so we should probably resolve it (it has been released long back. Can you please do a quick sanity check and resolve it? > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.24.0 > > Attachments: OAK-7151.patch, OAK-7151.xpath-new-syntax.patch, > OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013768#comment-17013768 ] Julian Reschke commented on OAK-7151: - [~catholicon], ping... > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.22.0 > > Attachments: OAK-7151.patch, OAK-7151.xpath-new-syntax.patch, > OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929146#comment-16929146 ] Thomas Mueller commented on OAK-7151: - [~catholicon] I just saw this is still open... is there any work left? > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.18.0 > > Attachments: OAK-7151.patch, OAK-7151.xpath-new-syntax.patch, > OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443765#comment-16443765 ] Thomas Mueller commented on OAK-7151: - http://svn.apache.org/r1829519 (trunk) - fix and test cases for the above problem with "rep:excerpt()" > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.10 > > Attachments: OAK-7151.patch, OAK-7151.xpath-new-syntax.patch, > OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443740#comment-16443740 ] Thomas Mueller commented on OAK-7151: - Working on a patch for the above problem, plus some test cases for this problem. > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.10 > > Attachments: OAK-7151.patch, OAK-7151.xpath-new-syntax.patch, > OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443738#comment-16443738 ] Thomas Mueller commented on OAK-7151: - This no longer works: {noformat} /jcr:root/tmp/test//element(*, nt:base)[jcr:contains(., 'hello')]/(rep:excerpt()) {noformat} > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.10 > > Attachments: OAK-7151.patch, OAK-7151.xpath-new-syntax.patch, > OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332281#comment-16332281 ] Vikas Saurabh commented on OAK-7151: Thanks for the review [~tmueller]. Have committed [r1821652|https://svn.apache.org/r1821652] and [r1821653|https://svn.apache.org/r1821653] in trunk. Not resolving just yet though as I want to check a few other scenarios. > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.10 > > Attachments: OAK-7151.patch, OAK-7151.xpath-new-syntax.patch, > OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332237#comment-16332237 ] Thomas Mueller commented on OAK-7151: - [~catholicon] looks good to me, except for one typo: "exceprt" > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.10 > > Attachments: OAK-7151.patch, OAK-7151.xpath-new-syntax.patch, > OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327935#comment-16327935 ] Vikas Saurabh commented on OAK-7151: [~tmueller], I've attached [^OAK-7151.xpath-new-syntax.patch]. This one also needs to be applied over [^OAK-7151.patch]. Diff on xpath.txt should be easier to read about implemented syntax. > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.10 > > Attachments: OAK-7151.patch, OAK-7151.xpath-new-syntax.patch, > OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327416#comment-16327416 ] Vikas Saurabh commented on OAK-7151: [~tmueller], good point - would update xpath patch accordingly. > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.10 > > Attachments: OAK-7151.patch, OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327212#comment-16327212 ] Thomas Mueller commented on OAK-7151: - [~catholicon] The syntax "//*[jcr:contains(., 'foo')]/(rep:excerpt(.) | @a | jcr:content/@b)" is to specify multiple column (excerpt, property a, property jcr:content/b). This is already implemented. I see the syntax "rep:excerpt(@foo1,@foo2,rel/@foo3)" would be much shorter than my version, however it looks like it would be one column, while you actually want 3 columns. "rep:excerpt(@foo1) | rep:excerpt(@foo2) | rep:excerpt(rel/@foo3)" is more clearly 3 columns. That's why I would prefer that syntax. I mean, in SQL, you have to write "select lower(firstName), lower(lastName), lower(fullName) from ...", and nobody recommended the alternative syntax "select lower(firstName, lastName, fullName) from ...", even thought that syntax would be shorter - it just looks like "lower" would be a function with 3 parameters, which it is not. > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.10 > > Attachments: OAK-7151.patch, OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327176#comment-16327176 ] Tommaso Teofili commented on OAK-7151: -- I'm +1 on the proposed approach for smarter fetching of excerpts and less useless allocated memory for never used excerpt values coming from unwanted fields. > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.10 > > Attachments: OAK-7151.patch, OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327134#comment-16327134 ] Vikas Saurabh commented on OAK-7151: [~tmueller], won't that be a bit superfluous due to repeating {{rep:excerpt(...)}}? > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.10 > > Attachments: OAK-7151.patch, OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327100#comment-16327100 ] Thomas Mueller commented on OAK-7151: - I think the query should be: {noformat} //*[jcr:contains(., 'foo')/(rep:excerpt(@foo1) | rep:excerpt(@foo2) | rep:excerpt(rel/@foo3)) {noformat} > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.10 > > Attachments: OAK-7151.patch, OAK-7151.xpath.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7151) Support indexed based excerpts on properties
[ https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325629#comment-16325629 ] Vikas Saurabh commented on OAK-7151: Hmm... working on xpath, I realized, we might have to come up with a syntax for xpath to select multiple excerpt fields. Would something like {noformat} //*[jcr:contains(., 'foo')/(rep:excerpt(@foo1,@foo2,rel/@foo3) {noformat} make sense? Or, can we skip that for now? > Support indexed based excerpts on properties > > > Key: OAK-7151 > URL: https://issues.apache.org/jira/browse/OAK-7151 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh > Fix For: 1.10 > > Attachments: OAK-7151.patch > > > As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when > requesting excerpts for properties. > The issue as highlighted in [~teofili]'s comment \[0] is that we at time of > query we don't have information about which all columns/fields would be > required for excerpts. > A possible approach is that the query specified explicitly which columns > would be required in facets (of course, node level excerpt would still be > supported). This issue is to track that improvement. > Note: this is *not* a substitute for OAK-4401 which is about doing saner > highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this > issue excerpt for non-stored fields (properties which aren't configured with > {{useInExcerpt}} in the index definition}, we'd need to fallback to > {{SimpleExcerptProvider}}. > /[~tmueller] > \[0]: > https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857 -- This message was sent by Atlassian JIRA (v6.4.14#64029)