[jira] [Commented] (OAK-7188) guava: ListenableFuture.transform() changes to transformAsync in version 20

2018-04-25 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16452440#comment-16452440
 ] 

Julian Reschke commented on OAK-7188:
-

Unfortunately, removed in Guava 24: 


...and it wasn't even deprecated in version 23.



> guava: ListenableFuture.transform() changes to transformAsync in version 20
> ---
>
> Key: OAK-7188
> URL: https://issues.apache.org/jira/browse/OAK-7188
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: segment-tar
>Reporter: Julian Reschke
>Assignee: Michael Dürig
>Priority: Major
>  Labels: technical_debt
> Fix For: 1.9.0, 1.10
>
> Attachments: OAK-7188.diff, OAK-7188.diff
>
>
> See 
> https://google.github.io/guava/releases/19.0/api/docs/com/google/common/util/concurrent/Futures.html#transform(com.google.common.util.concurrent.ListenableFuture,%20com.google.common.util.concurrent.AsyncFunction)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7188) guava: ListenableFuture.transform() changes to transformAsync in version 20

2018-01-31 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346949#comment-16346949
 ] 

Julian Reschke commented on OAK-7188:
-

a) I don't see how, if the test is supposed to run with Oak versions using both 
old and new Guava - am I missing something?

b) If you can change the test not to need this piece of Guava, that would of 
course be preferable.

> guava: ListenableFuture.transform() changes to transformAsync in version 20
> ---
>
> Key: OAK-7188
> URL: https://issues.apache.org/jira/browse/OAK-7188
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: segment-tar
>Reporter: Julian Reschke
>Priority: Major
> Attachments: OAK-7188.diff, OAK-7188.diff
>
>
> See 
> https://google.github.io/guava/releases/19.0/api/docs/com/google/common/util/concurrent/Futures.html#transform(com.google.common.util.concurrent.ListenableFuture,%20com.google.common.util.concurrent.AsyncFunction)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7188) guava: ListenableFuture.transform() changes to transformAsync in version 20

2018-01-31 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346932#comment-16346932
 ] 

Michael Dürig commented on OAK-7188:


Can't we have a stable test dependency to Guava? If not, I'd prefer to rewrite 
that functionality by other means instead of relying on reflection.

> guava: ListenableFuture.transform() changes to transformAsync in version 20
> ---
>
> Key: OAK-7188
> URL: https://issues.apache.org/jira/browse/OAK-7188
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: segment-tar
>Reporter: Julian Reschke
>Priority: Major
> Attachments: OAK-7188.diff, OAK-7188.diff
>
>
> See 
> https://google.github.io/guava/releases/19.0/api/docs/com/google/common/util/concurrent/Futures.html#transform(com.google.common.util.concurrent.ListenableFuture,%20com.google.common.util.concurrent.AsyncFunction)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7188) guava: ListenableFuture.transform() changes to transformAsync in version 20

2018-01-31 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346920#comment-16346920
 ] 

Julian Reschke commented on OAK-7188:
-

[^OAK-7188.diff] uses the proper method using reflection and should be 
compatible with Guava 15..20 (or more)

> guava: ListenableFuture.transform() changes to transformAsync in version 20
> ---
>
> Key: OAK-7188
> URL: https://issues.apache.org/jira/browse/OAK-7188
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: segment-tar
>Reporter: Julian Reschke
>Priority: Major
> Attachments: OAK-7188.diff, OAK-7188.diff
>
>
> See 
> https://google.github.io/guava/releases/19.0/api/docs/com/google/common/util/concurrent/Futures.html#transform(com.google.common.util.concurrent.ListenableFuture,%20com.google.common.util.concurrent.AsyncFunction)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7188) guava: ListenableFuture.transform() changes to transformAsync in version 20

2018-01-29 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343226#comment-16343226
 ] 

Michael Dürig commented on OAK-7188:


AFAIU the Guava version used for testing is pretty much constant per Oak 
version. So I would suggest to use whatever is the current name they come up 
for what used to be {{ListenableFuture.transform()}}. 

> guava: ListenableFuture.transform() changes to transformAsync in version 20
> ---
>
> Key: OAK-7188
> URL: https://issues.apache.org/jira/browse/OAK-7188
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: segment-tar
>Reporter: Julian Reschke
>Priority: Major
> Attachments: OAK-7188.diff
>
>
> See 
> https://google.github.io/guava/releases/19.0/api/docs/com/google/common/util/concurrent/Futures.html#transform(com.google.common.util.concurrent.ListenableFuture,%20com.google.common.util.concurrent.AsyncFunction)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7188) guava: ListenableFuture.transform() changes to transformAsync in version 20

2018-01-29 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343119#comment-16343119
 ] 

Julian Reschke commented on OAK-7188:
-

Not entirely sure that helps. If we keep the code as is, and configure a 
matching guava version for the tests, we'll have a problem if we want to test 
with a newer guava version. Vice versa: same problem, no?

> guava: ListenableFuture.transform() changes to transformAsync in version 20
> ---
>
> Key: OAK-7188
> URL: https://issues.apache.org/jira/browse/OAK-7188
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: segment-tar
>Reporter: Julian Reschke
>Priority: Major
> Attachments: OAK-7188.diff
>
>
> See 
> https://google.github.io/guava/releases/19.0/api/docs/com/google/common/util/concurrent/Futures.html#transform(com.google.common.util.concurrent.ListenableFuture,%20com.google.common.util.concurrent.AsyncFunction)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7188) guava: ListenableFuture.transform() changes to transformAsync in version 20

2018-01-29 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/OAK-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343041#comment-16343041
 ] 

Michael Dürig commented on OAK-7188:


[~reschke], that occurrence is in a test so there should be a problem to be 
tied to the specific Guava version used by the test runner.

> guava: ListenableFuture.transform() changes to transformAsync in version 20
> ---
>
> Key: OAK-7188
> URL: https://issues.apache.org/jira/browse/OAK-7188
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: segment-tar
>Reporter: Julian Reschke
>Priority: Major
> Attachments: OAK-7188.diff
>
>
> See 
> https://google.github.io/guava/releases/19.0/api/docs/com/google/common/util/concurrent/Futures.html#transform(com.google.common.util.concurrent.ListenableFuture,%20com.google.common.util.concurrent.AsyncFunction)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7188) guava: ListenableFuture.transform() changes to transformAsync in version 20

2018-01-25 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339237#comment-16339237
 ] 

Julian Reschke commented on OAK-7188:
-

[~mduerig] - this is the single place in the project that is not compatible 
with Guava >= 20.0. Any chance it could be rewritten?

> guava: ListenableFuture.transform() changes to transformAsync in version 20
> ---
>
> Key: OAK-7188
> URL: https://issues.apache.org/jira/browse/OAK-7188
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: segment-tar
>Reporter: Julian Reschke
>Priority: Major
> Attachments: OAK-7188.diff
>
>
> See 
> https://google.github.io/guava/releases/19.0/api/docs/com/google/common/util/concurrent/Futures.html#transform(com.google.common.util.concurrent.ListenableFuture,%20com.google.common.util.concurrent.AsyncFunction)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)