[jira] [Commented] (OAK-7198) Index rule with REGEX_ALL_PROPS includes relative node
[
https://issues.apache.org/jira/browse/OAK-7198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373552#comment-16373552
]
Vikas Saurabh commented on OAK-7198:
Backported to 1.8 in [r1825101|https://svn.apache.org/r1825101].
This issue led to OOM whlie doing {{--doc-traversal-mode}} based oak-run
indexing on mongo. The issue was that due to this issue
{{ChildNodeStateProvider}} tried to find a child node named {{\^\[\^\ }} and
read quite big tree in memory from the dumped documents.
> Index rule with REGEX_ALL_PROPS includes relative node
> --
>
> Key: OAK-7198
> URL: https://issues.apache.org/jira/browse/OAK-7198
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.8.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.9.0, 1.10, 1.8.3
>
> Attachments: OAK-7198.patch
>
>
> A lucene index with an index rule that includes properties with
> {{LuceneIndexConstants.REGEX_ALL_PROPS}} also includes some child node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7198) Index rule with REGEX_ALL_PROPS includes relative node
[
https://issues.apache.org/jira/browse/OAK-7198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346319#comment-16346319
]
Chetan Mehrotra commented on OAK-7198:
--
Thanks [~mreutegg] for digging into this. See "^[^\" nodes being looked up in
quite a few logs but did not got time to dig it deeper. Current support for
regex is limited to immediate property so this looks fine.
Later when we plan to support regex for relative property OAK-5187 we can have
a more generic approach
> Index rule with REGEX_ALL_PROPS includes relative node
> --
>
> Key: OAK-7198
> URL: https://issues.apache.org/jira/browse/OAK-7198
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.8.0
>Reporter: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10
>
> Attachments: OAK-7198.patch
>
>
> A lucene index with an index rule that includes properties with
> {{LuceneIndexConstants.REGEX_ALL_PROPS}} also includes some child node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7198) Index rule with REGEX_ALL_PROPS includes relative node
[
https://issues.apache.org/jira/browse/OAK-7198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341969#comment-16341969
]
Vikas Saurabh commented on OAK-7198:
[~mreutegg], thanks for reporting this. Unfortunately, I am also not very
comfortable with aggregation expectation - I'd rather [~chetanm] takes a shot
at reviewing.
> Index rule with REGEX_ALL_PROPS includes relative node
> --
>
> Key: OAK-7198
> URL: https://issues.apache.org/jira/browse/OAK-7198
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.8.0
>Reporter: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10
>
> Attachments: OAK-7198.patch
>
>
> A lucene index with an index rule that includes properties with
> {{LuceneIndexConstants.REGEX_ALL_PROPS}} also includes some child node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7198) Index rule with REGEX_ALL_PROPS includes relative node
[
https://issues.apache.org/jira/browse/OAK-7198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339251#comment-16339251
]
Marcel Reutegger commented on OAK-7198:
---
Proposed fix in [^OAK-7198.patch]. I'm not sure this fixes all the edge cases
with the REGEX_ALL_PROPS.
[~chetanm], [~catholicon] can you please review?
> Index rule with REGEX_ALL_PROPS includes relative node
> --
>
> Key: OAK-7198
> URL: https://issues.apache.org/jira/browse/OAK-7198
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.8.0
>Reporter: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10
>
> Attachments: OAK-7198.patch
>
>
> A lucene index with an index rule that includes properties with
> {{LuceneIndexConstants.REGEX_ALL_PROPS}} also includes some child node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7198) Index rule with REGEX_ALL_PROPS includes relative node
[
https://issues.apache.org/jira/browse/OAK-7198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339206#comment-16339206
]
Marcel Reutegger commented on OAK-7198:
---
Extended the test with more checks: http://svn.apache.org/r1822201
> Index rule with REGEX_ALL_PROPS includes relative node
> --
>
> Key: OAK-7198
> URL: https://issues.apache.org/jira/browse/OAK-7198
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.8.0
>Reporter: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10
>
>
> A lucene index with an index rule that includes properties with
> {{LuceneIndexConstants.REGEX_ALL_PROPS}} also includes some child node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7198) Index rule with REGEX_ALL_PROPS includes relative node
[
https://issues.apache.org/jira/browse/OAK-7198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337888#comment-16337888
]
Marcel Reutegger commented on OAK-7198:
---
Added an ignored test: http://svn.apache.org/r1822121
When enabled, fails with:
{noformat}
Expected: is an empty collection
but: <[^[^\]>
at
org.apache.jackrabbit.oak.plugins.index.lucene.IndexDefinitionTest.regexAllProps(IndexDefinitionTest.java:1209)
{noformat}
It seems the first part of the all props regex is treated as node name.
> Index rule with REGEX_ALL_PROPS includes relative node
> --
>
> Key: OAK-7198
> URL: https://issues.apache.org/jira/browse/OAK-7198
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.8.0
>Reporter: Marcel Reutegger
>Priority: Minor
> Fix For: 1.10
>
>
> A lucene index with an index rule that includes properties with
> {{LuceneIndexConstants.REGEX_ALL_PROPS}} also includes some child node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
