[jira] [Commented] (OAK-7213) Avoid call for child node when bundle contains all children
[
https://issues.apache.org/jira/browse/OAK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343202#comment-16343202
]
Marcel Reutegger commented on OAK-7213:
---
Added an ignored test: http://svn.apache.org/r1822496
> Avoid call for child node when bundle contains all children
> ---
>
> Key: OAK-7213
> URL: https://issues.apache.org/jira/browse/OAK-7213
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Labels: bundling
> Fix For: 1.10
>
>
> When nodes are bundled in a document, the DocumentNodeStore keeps track of
> whether all children are included in a document. The presence of the hidden
> {{:doc-has-child-non-bundled}} property indicates there are non bundled child
> nodes. For the case when a document contains all children in the bundle, the
> DocumentNodeStore still does a find call on the DocumentStore when asked for
> an unknown child node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7213) Avoid call for child node when bundle contains all children
[
https://issues.apache.org/jira/browse/OAK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343225#comment-16343225
]
Marcel Reutegger commented on OAK-7213:
---
Proposed fix in [^OAK-7213.patch]. [~chetanm], can you please review?
> Avoid call for child node when bundle contains all children
> ---
>
> Key: OAK-7213
> URL: https://issues.apache.org/jira/browse/OAK-7213
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Labels: bundling
> Fix For: 1.10
>
> Attachments: OAK-7213.patch
>
>
> When nodes are bundled in a document, the DocumentNodeStore keeps track of
> whether all children are included in a document. The presence of the hidden
> {{:doc-has-child-non-bundled}} property indicates there are non bundled child
> nodes. For the case when a document contains all children in the bundle, the
> DocumentNodeStore still does a find call on the DocumentStore when asked for
> an unknown child node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7213) Avoid call for child node when bundle contains all children
[
https://issues.apache.org/jira/browse/OAK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346310#comment-16346310
]
Chetan Mehrotra commented on OAK-7213:
--
Changes look good. Some more info - for bundling root
{{bundlingContext.hasOnlyBundledChildren()}} relies on "_children" flag while
for any child node it relies on the {{:doc-has-child-non-bundled}}
> Avoid call for child node when bundle contains all children
> ---
>
> Key: OAK-7213
> URL: https://issues.apache.org/jira/browse/OAK-7213
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Labels: bundling
> Fix For: 1.9.0, 1.10
>
> Attachments: OAK-7213.patch
>
>
> When nodes are bundled in a document, the DocumentNodeStore keeps track of
> whether all children are included in a document. The presence of the hidden
> {{:doc-has-child-non-bundled}} property indicates there are non bundled child
> nodes. For the case when a document contains all children in the bundle, the
> DocumentNodeStore still does a find call on the DocumentStore when asked for
> an unknown child node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7213) Avoid call for child node when bundle contains all children
[
https://issues.apache.org/jira/browse/OAK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346878#comment-16346878
]
Marcel Reutegger commented on OAK-7213:
---
Thanks for the review. I added an additional assertion to the test to check for
the {{_children}} flag.
In trunk: http://svn.apache.org/r1822802
> Avoid call for child node when bundle contains all children
> ---
>
> Key: OAK-7213
> URL: https://issues.apache.org/jira/browse/OAK-7213
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Labels: bundling
> Fix For: 1.9.0, 1.10
>
> Attachments: OAK-7213.patch
>
>
> When nodes are bundled in a document, the DocumentNodeStore keeps track of
> whether all children are included in a document. The presence of the hidden
> {{:doc-has-child-non-bundled}} property indicates there are non bundled child
> nodes. For the case when a document contains all children in the bundle, the
> DocumentNodeStore still does a find call on the DocumentStore when asked for
> an unknown child node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7213) Avoid call for child node when bundle contains all children
[
https://issues.apache.org/jira/browse/OAK-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872293#comment-16872293
]
Julian Reschke commented on OAK-7213:
-
trunk: (1.9.0) [r1822802|http://svn.apache.org/r1822802]
[r1822638|http://svn.apache.org/r1822638]
[r1822496|http://svn.apache.org/r1822496]
> Avoid call for child node when bundle contains all children
> ---
>
> Key: OAK-7213
> URL: https://issues.apache.org/jira/browse/OAK-7213
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Labels: bundling
> Fix For: 1.9.0, 1.10.0
>
> Attachments: OAK-7213.patch
>
>
> When nodes are bundled in a document, the DocumentNodeStore keeps track of
> whether all children are included in a document. The presence of the hidden
> {{:doc-has-child-non-bundled}} property indicates there are non bundled child
> nodes. For the case when a document contains all children in the bundle, the
> DocumentNodeStore still does a find call on the DocumentStore when asked for
> an unknown child node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
