[jira] [Commented] (OAK-8995) Remove support for lucene custom scorer
[ https://issues.apache.org/jira/browse/OAK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088781#comment-17088781 ] Julian Reschke commented on OAK-8995: - trunk: [r1876580|http://svn.apache.org/r1876580] [r1876547|http://svn.apache.org/r1876547] [r1876546|http://svn.apache.org/r1876546] > Remove support for lucene custom scorer > --- > > Key: OAK-8995 > URL: https://issues.apache.org/jira/browse/OAK-8995 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene, oak-search >Reporter: Fabrizio Fortino >Priority: Major > Fix For: 1.28.0 > > Attachments: OAK-8995-1.patch, OAK-8995-2.patch, OAK-8995-3.patch > > > The custom scorer exposes the Lucene API directly. This needs to be removed > in order to support remote index services (solr, elasticsearch). Since this > feature does not seem to be used, we can safely remove it. > > [https://github.com/apache/jackrabbit-oak/tree/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8995) Remove support for lucene custom scorer
[ https://issues.apache.org/jira/browse/OAK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084835#comment-17084835 ] Julian Reschke commented on OAK-8995: - This will break any downstream code that imports this package. > Remove support for lucene custom scorer > --- > > Key: OAK-8995 > URL: https://issues.apache.org/jira/browse/OAK-8995 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene, oak-search >Reporter: Fabrizio Fortino >Priority: Major > Fix For: 1.28.0 > > Attachments: OAK-8995-1.patch, OAK-8995-2.patch, OAK-8995-3.patch > > > The custom scorer exposes the Lucene API directly. This needs to be removed > in order to support remote index services (solr, elasticsearch). Since this > feature does not seem to be used, we can safely remove it. > > [https://github.com/apache/jackrabbit-oak/tree/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8995) Remove support for lucene custom scorer
[ https://issues.apache.org/jira/browse/OAK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084792#comment-17084792 ] Fabrizio Fortino commented on OAK-8995: --- [~reschke] an analysis that has been done in the past showed no use of this feature at all. We have deprecated it in version 1.24.0. Thanks for pointing out the package is still among the exported ones. I think it needs to be removed to complete the task. Patch [^OAK-8995-3.patch] removes it from Export-Package. Could you apply it in svn? > Remove support for lucene custom scorer > --- > > Key: OAK-8995 > URL: https://issues.apache.org/jira/browse/OAK-8995 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene, oak-search >Reporter: Fabrizio Fortino >Priority: Major > Fix For: 1.28.0 > > Attachments: OAK-8995-1.patch, OAK-8995-2.patch, OAK-8995-3.patch > > > The custom scorer exposes the Lucene API directly. This needs to be removed > in order to support remote index services (solr, elasticsearch). Since this > feature does not seem to be used, we can safely remove it. > > [https://github.com/apache/jackrabbit-oak/tree/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8995) Remove support for lucene custom scorer
[ https://issues.apache.org/jira/browse/OAK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084656#comment-17084656 ] Julian Reschke commented on OAK-8995: - I note that this seems to entirely remove a previously exported package. Did you consider the potential compat impact? > Remove support for lucene custom scorer > --- > > Key: OAK-8995 > URL: https://issues.apache.org/jira/browse/OAK-8995 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene, oak-search >Reporter: Fabrizio Fortino >Priority: Major > Fix For: 1.28.0 > > Attachments: OAK-8995-1.patch, OAK-8995-2.patch > > > The custom scorer exposes the Lucene API directly. This needs to be removed > in order to support remote index services (solr, elasticsearch). Since this > feature does not seem to be used, we can safely remove it. > > [https://github.com/apache/jackrabbit-oak/tree/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8995) Remove support for lucene custom scorer
[ https://issues.apache.org/jira/browse/OAK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084555#comment-17084555 ] Mohit Kataria commented on OAK-8995: Score package removed via [http://svn.apache.org/viewvc?view=revision&revision=1876580] > Remove support for lucene custom scorer > --- > > Key: OAK-8995 > URL: https://issues.apache.org/jira/browse/OAK-8995 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene, oak-search >Reporter: Fabrizio Fortino >Priority: Major > Fix For: 1.28.0 > > Attachments: OAK-8995-1.patch, OAK-8995-2.patch > > > The custom scorer exposes the Lucene API directly. This needs to be removed > in order to support remote index services (solr, elasticsearch). Since this > feature does not seem to be used, we can safely remove it. > > [https://github.com/apache/jackrabbit-oak/tree/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8995) Remove support for lucene custom scorer
[ https://issues.apache.org/jira/browse/OAK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084550#comment-17084550 ] Mohit Kataria commented on OAK-8995: removing package manually. > Remove support for lucene custom scorer > --- > > Key: OAK-8995 > URL: https://issues.apache.org/jira/browse/OAK-8995 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene, oak-search >Reporter: Fabrizio Fortino >Priority: Major > Fix For: 1.28.0 > > Attachments: OAK-8995-1.patch, OAK-8995-2.patch > > > The custom scorer exposes the Lucene API directly. This needs to be removed > in order to support remote index services (solr, elasticsearch). Since this > feature does not seem to be used, we can safely remove it. > > [https://github.com/apache/jackrabbit-oak/tree/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8995) Remove support for lucene custom scorer
[ https://issues.apache.org/jira/browse/OAK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084548#comment-17084548 ] Fabrizio Fortino commented on OAK-8995: --- [~ngupta] [~mkataria] I think there was some problem in applying the patch. The package *org/apache/jackrabbit/oak/plugins/index/lucene/score* is still there and all the files in it are empty. Could you remove it at all? > Remove support for lucene custom scorer > --- > > Key: OAK-8995 > URL: https://issues.apache.org/jira/browse/OAK-8995 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene, oak-search >Reporter: Fabrizio Fortino >Priority: Major > Fix For: 1.28.0 > > Attachments: OAK-8995-1.patch, OAK-8995-2.patch > > > The custom scorer exposes the Lucene API directly. This needs to be removed > in order to support remote index services (solr, elasticsearch). Since this > feature does not seem to be used, we can safely remove it. > > [https://github.com/apache/jackrabbit-oak/tree/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8995) Remove support for lucene custom scorer
[
https://issues.apache.org/jira/browse/OAK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084524#comment-17084524
]
Nitin Gupta commented on OAK-8995:
--
[~fabrizio.fort...@gmail.com] , [~mkataria] - there seems some problem with
the file removals.
Notice
[https://github.com/apache/jackrabbit-oak/blob/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score/ScorerProvider.java]
is still present as an empty file.
If I notice the svn update logs, it shows these files as updated and not
removed -
{code:java}
U
oak-lucene\src\main\java\org\apache\jackrabbit\oak\plugins\index\lucene\score\ScorerProvider.java
U
oak-lucene\src\main\java\org\apache\jackrabbit\oak\plugins\index\lucene\score\ScorerProviderFactory.java
U
oak-lucene\src\main\java\org\apache\jackrabbit\oak\plugins\index\lucene\score\impl\ScorerProviderFactoryImpl.java
U
oak-lucene\src\main\java\org\apache\jackrabbit\oak\plugins\index\lucene\score\package-info.java
{code}
As a result rat check fails.
Try doing a mvn clean install -Prat in oak-lucene.
> Remove support for lucene custom scorer
> ---
>
> Key: OAK-8995
> URL: https://issues.apache.org/jira/browse/OAK-8995
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: lucene, oak-search
>Reporter: Fabrizio Fortino
>Priority: Major
> Fix For: 1.28.0
>
> Attachments: OAK-8995-1.patch, OAK-8995-2.patch
>
>
> The custom scorer exposes the Lucene API directly. This needs to be removed
> in order to support remote index services (solr, elasticsearch). Since this
> feature does not seem to be used, we can safely remove it.
>
> [https://github.com/apache/jackrabbit-oak/tree/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8995) Remove support for lucene custom scorer
[ https://issues.apache.org/jira/browse/OAK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084010#comment-17084010 ] Mohit Kataria commented on OAK-8995: Patch merged: # remove support for lucene custom scorer: [http://svn.apache.org/viewvc?view=revision&revision=1876546] # polish code of changed classes: [http://svn.apache.org/viewvc?view=revision&revision=1876547] CC: [~fabrizio.fort...@gmail.com] > Remove support for lucene custom scorer > --- > > Key: OAK-8995 > URL: https://issues.apache.org/jira/browse/OAK-8995 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene, oak-search >Reporter: Fabrizio Fortino >Priority: Major > Fix For: 1.24.0 > > Attachments: OAK-8995-1.patch, OAK-8995-2.patch > > > The custom scorer exposes the Lucene API directly. This needs to be removed > in order to support remote index services (solr, elasticsearch). Since this > feature does not seem to be used, we can safely remove it. > > [https://github.com/apache/jackrabbit-oak/tree/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8995) Remove support for lucene custom scorer
[ https://issues.apache.org/jira/browse/OAK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083987#comment-17083987 ] Fabrizio Fortino commented on OAK-8995: --- Code changes have already been discussed/reviewed in [https://github.com/oak-indexing/jackrabbit-oak/pull/105] [~ngupta] [~tihom88] [~thomasm] could you please apply the following patches in svn in 2 separate commits: * [^OAK-8995-1.patch] remove support for lucene custom scorer * [^OAK-8995-2.patch] polish code of changed classes > Remove support for lucene custom scorer > --- > > Key: OAK-8995 > URL: https://issues.apache.org/jira/browse/OAK-8995 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene, oak-search >Reporter: Fabrizio Fortino >Priority: Major > Fix For: 1.24.0 > > Attachments: OAK-8995-1.patch, OAK-8995-2.patch > > > The custom scorer exposes the Lucene API directly. This needs to be removed > in order to support remote index services (solr, elasticsearch). Since this > feature does not seem to be used, we can safely remove it. > > [https://github.com/apache/jackrabbit-oak/tree/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score] -- This message was sent by Atlassian Jira (v8.3.4#803005)
