[jira] [Commented] (OAK-9331) JavaDoc generation fails on Java 15

2021-03-19 Thread Julian Reschke (Jira) 


[ 
https://issues.apache.org/jira/browse/OAK-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17304748#comment-17304748
 ] 

Julian Reschke commented on OAK-9331:
-

This is a change in Javadoc's behavior that is incompatible with Java 8. If you 
make it pass with Java 15, it will fail for Java 8. See 
.

> JavaDoc generation fails on Java 15
> ---
>
> Key: OAK-9331
> URL: https://issues.apache.org/jira/browse/OAK-9331
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-9331-01.patch
>
>
> {{mvn javadoc:javadoc}} fails on Java 15 with:
> {noformat}
> /apache/jackrabbit-oak/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/PrincipalConfiguration.java:48:
>  error: unexpected heading used: , compared to implicit preceding 
> heading: 
> [ERROR]  * Backwards compatibility with Jackrabbit 2.x
> [ERROR]^
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-9331) JavaDoc generation fails on Java 15

2021-01-21 Thread Fabrizio Fortino (Jira) 


[ 
https://issues.apache.org/jira/browse/OAK-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269322#comment-17269322
 ] 

Fabrizio Fortino commented on OAK-9331:
---

[~adulceanu] I think that merging the latest changes from trunk will make the 
errors go away. Some class modifiers have been changed with this commit 
([https://github.com/apache/jackrabbit-oak/commit/8e6049c06a27b5dae87eb2c84daee2ac9df6739e)]
 but it seems you only have partial changes.

> JavaDoc generation fails on Java 15
> ---
>
> Key: OAK-9331
> URL: https://issues.apache.org/jira/browse/OAK-9331
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-9331-01.patch
>
>
> {{mvn javadoc:javadoc}} fails on Java 15 with:
> {noformat}
> /apache/jackrabbit-oak/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/PrincipalConfiguration.java:48:
>  error: unexpected heading used: , compared to implicit preceding 
> heading: 
> [ERROR]  * Backwards compatibility with Jackrabbit 2.x
> [ERROR]^
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-9331) JavaDoc generation fails on Java 15

2021-01-21 Thread Andrei Dulceanu (Jira) 


[ 
https://issues.apache.org/jira/browse/OAK-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269257#comment-17269257
 ] 

Andrei Dulceanu commented on OAK-9331:
--

BTW, I tried fixing JavaDoc for Java 15 following the recommendations at [0].

[0] https://bugs.openjdk.java.net/browse/JDK-8220379

> JavaDoc generation fails on Java 15
> ---
>
> Key: OAK-9331
> URL: https://issues.apache.org/jira/browse/OAK-9331
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Major
> Attachments: OAK-9331-01.patch
>
>
> {{mvn javadoc:javadoc}} fails on Java 15 with:
> {noformat}
> /apache/jackrabbit-oak/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/PrincipalConfiguration.java:48:
>  error: unexpected heading used: , compared to implicit preceding 
> heading: 
> [ERROR]  * Backwards compatibility with Jackrabbit 2.x
> [ERROR]^
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OAK-9331) JavaDoc generation fails on Java 15

2021-01-21 Thread Andrei Dulceanu (Jira) 


[ 
https://issues.apache.org/jira/browse/OAK-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269256#comment-17269256
 ] 

Andrei Dulceanu commented on OAK-9331:
--

Applying [^OAK-9331-01.patch] almost all issues go away, except this one:
{noformat}
 [ERROR] Exit code: 1 - 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexer.java:23:
 error: ElasticDocument is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR] import 
org.apache.jackrabbit.oak.plugins.index.elastic.index.ElasticDocument;
[ERROR] ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexer.java:24:
 error: ElasticDocumentMaker is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR] import 
org.apache.jackrabbit.oak.plugins.index.elastic.index.ElasticDocumentMaker;
[ERROR] ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexer.java:44:
 error: ElasticDocument is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR] private final FulltextIndexWriter indexWriter;
[ERROR]   ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexer.java:48:
 error: ElasticDocument is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR]   FulltextIndexWriter 
indexWriter) {
[ERROR]   ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexer.java:110:
 error: ElasticDocument is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR] private void writeToIndex(ElasticDocument doc, String path) throws 
IOException {
[ERROR]   ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexer.java:114:
 error: ElasticDocumentMaker is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR] private ElasticDocumentMaker 
newDocumentMaker(IndexDefinition.IndexingRule indexingRule, String path) {
[ERROR] ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexerProvider.java:25:
 error: ElasticDocument is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR] import 
org.apache.jackrabbit.oak.plugins.index.elastic.index.ElasticDocument;
[ERROR] ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexerProvider.java:26:
 error: ElasticIndexWriterFactory is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR] import 
org.apache.jackrabbit.oak.plugins.index.elastic.index.ElasticIndexWriterFactory;
[ERROR] ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexerProvider.java:47:
 error: ElasticIndexWriterFactory is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR] private final ElasticIndexWriterFactory indexWriterFactory;
[ERROR]   ^
[ERROR]
[ERROR] Command line was: 
/Library/Java/JavaVirtualMachines/zulu-15.jdk/Contents/Home/bin/javadoc 
@options @packages{noformat}
[~fabrizio.fort...@gmail.com], could you take a look at it, please? Once the 
issue spotted, you could add a patch to this issue (not applying the changes on 
trunk yet, see below).

OTOH, it seems that the changes done to be Java 15 compliant are not backwards 
compatible, therefore when attempting {{mvn javadoc:javadoc}} with Java 8 I get 
this:
{noformat}
 [ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/PrincipalConfiguration.java:48:
 error: header