[jira] [Commented] (OAK-9773) DefaultSyncContext#syncMembership() compares external ids case-sensitively
[ https://issues.apache.org/jira/browse/OAK-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17565865#comment-17565865 ] Manfred Baedke commented on OAK-9773: - Linked OAK-7469 because that particular patch made the issue apparent. > DefaultSyncContext#syncMembership() compares external ids case-sensitively > --- > > Key: OAK-9773 > URL: https://issues.apache.org/jira/browse/OAK-9773 > Project: Jackrabbit Oak > Issue Type: Bug > Components: auth-external >Affects Versions: 1.42.0, 1.22.10 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Major > Fix For: 1.44.0, 1.22.12 > > Attachments: OAK-9773.patch > > > DefaultSyncContext#syncMembership() uses ids of Authorizables as keys in > HashMaps. Since UserManagerImpl#getAuthorizable(String) works > case-insensitively, this leads to misbehavior. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-9773) DefaultSyncContext#syncMembership() compares external ids case-sensitively
[
https://issues.apache.org/jira/browse/OAK-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17561432#comment-17561432
]
Manfred Baedke commented on OAK-9773:
-
Changed that to
{code}log.warn("The existing group {} and the external group {} have
identifiers that only differ by case. Since the identifiers are compared
case-insensitively, the existing authorizable will be considered to match the
external group.", grp.getID(), extGroup.getId());{code}
trunk:
https://github.com/apache/jackrabbit-oak/commit/72fd3d043a76f3b5c8e72d79fdc0e9207f21bae7
1.22:
https://github.com/apache/jackrabbit-oak/commit/72ea92e42739e27f4eb645f737f0ecee939e70ec
> DefaultSyncContext#syncMembership() compares external ids case-sensitively
> ---
>
> Key: OAK-9773
> URL: https://issues.apache.org/jira/browse/OAK-9773
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: auth-external
>Affects Versions: 1.42.0, 1.22.10
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Major
> Fix For: 1.44.0, 1.22.12
>
> Attachments: OAK-9773.patch
>
>
> DefaultSyncContext#syncMembership() uses ids of Authorizables as keys in
> HashMaps. Since UserManagerImpl#getAuthorizable(String) works
> case-insensitively, this leads to misbehavior.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OAK-9773) DefaultSyncContext#syncMembership() compares external ids case-sensitively
[ https://issues.apache.org/jira/browse/OAK-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17560970#comment-17560970 ] Manfred Baedke commented on OAK-9773: - Thx [~angela]! I'll fix it. > DefaultSyncContext#syncMembership() compares external ids case-sensitively > --- > > Key: OAK-9773 > URL: https://issues.apache.org/jira/browse/OAK-9773 > Project: Jackrabbit Oak > Issue Type: Bug > Components: auth-external >Affects Versions: 1.42.0, 1.22.10 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Major > Fix For: 1.44.0, 1.22.12 > > Attachments: OAK-9773.patch > > > DefaultSyncContext#syncMembership() uses ids of Authorizables as keys in > HashMaps. Since UserManagerImpl#getAuthorizable(String) works > case-insensitively, this leads to misbehavior. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-9773) DefaultSyncContext#syncMembership() compares external ids case-sensitively
[ https://issues.apache.org/jira/browse/OAK-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17559179#comment-17559179 ] Manfred Baedke commented on OAK-9773: - 1.22: https://github.com/apache/jackrabbit-oak/commit/4fe2a6a8fa83ef2a23c2ab2471a200f43960f2e7 > DefaultSyncContext#syncMembership() compares external ids case-sensitively > --- > > Key: OAK-9773 > URL: https://issues.apache.org/jira/browse/OAK-9773 > Project: Jackrabbit Oak > Issue Type: Bug > Components: auth-external >Affects Versions: 1.42.0 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Major > Labels: candidate_oak_1_22 > Fix For: 1.44.0 > > Attachments: OAK-9773.patch > > > DefaultSyncContext#syncMembership() uses ids of Authorizables as keys in > HashMaps. Since UserManagerImpl#getAuthorizable(String) works > case-insensitively, this leads to misbehavior. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OAK-9773) DefaultSyncContext#syncMembership() compares external ids case-sensitively
[ https://issues.apache.org/jira/browse/OAK-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557542#comment-17557542 ] Manfred Baedke commented on OAK-9773: - PR merged. > DefaultSyncContext#syncMembership() compares external ids case-sensitively > --- > > Key: OAK-9773 > URL: https://issues.apache.org/jira/browse/OAK-9773 > Project: Jackrabbit Oak > Issue Type: Bug > Components: auth-external >Affects Versions: 1.42.0 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Major > Labels: candidate_oak_1_22 > Attachments: OAK-9773.patch > > > DefaultSyncContext#syncMembership() uses ids of Authorizables as keys in > HashMaps. Since UserManagerImpl#getAuthorizable(String) works > case-insensitively, this leads to misbehavior. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OAK-9773) DefaultSyncContext#syncMembership() compares external ids case-sensitively
[ https://issues.apache.org/jira/browse/OAK-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553574#comment-17553574 ] Manfred Baedke commented on OAK-9773: - Added unit test and logging. > DefaultSyncContext#syncMembership() compares external ids case-sensitively > --- > > Key: OAK-9773 > URL: https://issues.apache.org/jira/browse/OAK-9773 > Project: Jackrabbit Oak > Issue Type: Bug > Components: auth-external >Affects Versions: 1.42.0 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Major > Labels: candidate_oak_1_22 > Attachments: OAK-9773.patch > > > DefaultSyncContext#syncMembership() uses ids of Authorizables as keys in > HashMaps. Since UserManagerImpl#getAuthorizable(String) works > case-insensitively, this leads to misbehavior. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OAK-9773) DefaultSyncContext#syncMembership() compares external ids case-sensitively
[ https://issues.apache.org/jira/browse/OAK-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17552656#comment-17552656 ] Manfred Baedke commented on OAK-9773: - PR: https://github.com/apache/jackrabbit-oak/pull/590. Unit test is coming. > DefaultSyncContext#syncMembership() compares external ids case-sensitively > --- > > Key: OAK-9773 > URL: https://issues.apache.org/jira/browse/OAK-9773 > Project: Jackrabbit Oak > Issue Type: Bug > Components: auth-external >Affects Versions: 1.42.0 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Major > Labels: candidate_oak_1_22 > Attachments: OAK-9773.patch > > > DefaultSyncContext#syncMembership() uses ids of Authorizables as keys in > HashMaps. Since UserManagerImpl#getAuthorizable(String) works > case-insensitively, this leads to misbehavior. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OAK-9773) DefaultSyncContext#syncMembership() compares external ids case-sensitively
[ https://issues.apache.org/jira/browse/OAK-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538858#comment-17538858 ] Angela Schreiber commented on OAK-9773: --- [~baedke], could you create a PR and invite everyone involved for a review? thanks a lot. > DefaultSyncContext#syncMembership() compares external ids case-sensitively > --- > > Key: OAK-9773 > URL: https://issues.apache.org/jira/browse/OAK-9773 > Project: Jackrabbit Oak > Issue Type: Bug > Components: auth-external >Affects Versions: 1.42.0 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Major > Labels: candidate_oak_1_22 > Attachments: OAK-9773.patch > > > DefaultSyncContext#syncMembership() uses ids of Authorizables as keys in > HashMaps. Since UserManagerImpl#getAuthorizable(String) works > case-insensitively, this leads to misbehavior. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OAK-9773) DefaultSyncContext#syncMembership() compares external ids case-sensitively
[ https://issues.apache.org/jira/browse/OAK-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17538845#comment-17538845 ] Manfred Baedke commented on OAK-9773: - Patch provided by [~ypoireault]. > DefaultSyncContext#syncMembership() compares external ids case-sensitively > --- > > Key: OAK-9773 > URL: https://issues.apache.org/jira/browse/OAK-9773 > Project: Jackrabbit Oak > Issue Type: Bug > Components: auth-external >Affects Versions: 1.42.0 >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Major > Labels: candidate_oak_1_22 > Attachments: OAK-9773.patch > > > DefaultSyncContext#syncMembership() uses ids of Authorizables as keys in > HashMaps. Since UserManagerImpl#getAuthorizable(String) works > case-insensitively, this leads to misbehavior. -- This message was sent by Atlassian Jira (v8.20.7#820007)
