[jira] [Updated] (OAK-5025) Speed up ACE node name generation
[ https://issues.apache.org/jira/browse/OAK-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-5025: Attachment: ace_creation_status_quo_withsave.txt ace_creation_index.txt ace_creation_index_withsave.txt ace_creation_random_withsave.txt ace_creation_random.txt ace_creation_status_quo.txt > Speed up ACE node name generation > - > > Key: OAK-5025 > URL: https://issues.apache.org/jira/browse/OAK-5025 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.5.12 >Reporter: Alex COLLIGNON >Assignee: angela >Priority: Minor > Labels: performance > Fix For: 1.6 > > Attachments: OAK-5025-ACE-name-generation-benchmarks.patch, > OAK-5025-ACE-random-nodename-generation.patch, ace_creation_index.txt, > ace_creation_index_withsave.txt, ace_creation_random.txt, > ace_creation_random_withsave.txt, ace_creation_status_quo.txt, > ace_creation_status_quo_withsave.txt > > > Currently, > {{o.a.j.oak.security.authorization.accesscontrol.Util#generateAceName}} is > traversing all the existing ACE of a certain node in order to generate > continuous numbering (allow0, allow1, allow2). > While that certainly helps to produce human readable names, it represents > quite a performance bottleneck when the number of existing ACE starts to grow. > Since the naming is a pure implementation detail, my proposal is to keep the > continuous numbering for the first hundreds of nodes and then use a random > number to generate unique names in a faster fashion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-5025) Speed up ACE node name generation
[ https://issues.apache.org/jira/browse/OAK-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex COLLIGNON updated OAK-5025: Attachment: OAK-5025-ACE-random-nodename-generation.patch OAK-5025-ACE-name-generation-benchmarks.patch Attaching a patch using a (pseudo-)random generator to create the ACE nodename. This strategy avoids the children traversal. I am also attaching a new benchmark. > Speed up ACE node name generation > - > > Key: OAK-5025 > URL: https://issues.apache.org/jira/browse/OAK-5025 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.5.12 >Reporter: Alex COLLIGNON >Assignee: angela >Priority: Minor > Labels: performance > Fix For: 1.6 > > Attachments: OAK-5025-ACE-name-generation-benchmarks.patch, > OAK-5025-ACE-random-nodename-generation.patch > > > Currently, > {{o.a.j.oak.security.authorization.accesscontrol.Util#generateAceName}} is > traversing all the existing ACE of a certain node in order to generate > continuous numbering (allow0, allow1, allow2). > While that certainly helps to produce human readable names, it represents > quite a performance bottleneck when the number of existing ACE starts to grow. > Since the naming is a pure implementation detail, my proposal is to keep the > continuous numbering for the first hundreds of nodes and then use a random > number to generate unique names in a faster fashion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-5025) Speed up ACE node name generation
[ https://issues.apache.org/jira/browse/OAK-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-5025: Fix Version/s: 1.6 > Speed up ACE node name generation > - > > Key: OAK-5025 > URL: https://issues.apache.org/jira/browse/OAK-5025 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.5.12 >Reporter: Alex COLLIGNON >Assignee: angela >Priority: Minor > Labels: performance > Fix For: 1.6 > > > Currently, > {{o.a.j.oak.security.authorization.accesscontrol.Util#generateAceName}} is > traversing all the existing ACE of a certain node in order to generate > continuous numbering (allow0, allow1, allow2). > While that certainly helps to produce human readable names, it represents > quite a performance bottleneck when the number of existing ACE starts to grow. > Since the naming is a pure implementation detail, my proposal is to keep the > continuous numbering for the first hundreds of nodes and then use a random > number to generate unique names in a faster fashion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-5025) Speed up ACE node name generation
[ https://issues.apache.org/jira/browse/OAK-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-5025: Labels: performance (was: ) > Speed up ACE node name generation > - > > Key: OAK-5025 > URL: https://issues.apache.org/jira/browse/OAK-5025 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.5.12 >Reporter: Alex COLLIGNON >Assignee: angela >Priority: Minor > Labels: performance > > Currently, > {{o.a.j.oak.security.authorization.accesscontrol.Util#generateAceName}} is > traversing all the existing ACE of a certain node in order to generate > continuous numbering (allow0, allow1, allow2). > While that certainly helps to produce human readable names, it represents > quite a performance bottleneck when the number of existing ACE starts to grow. > Since the naming is a pure implementation detail, my proposal is to keep the > continuous numbering for the first hundreds of nodes and then use a random > number to generate unique names in a faster fashion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-5025) Speed up ACE node name generation
[ https://issues.apache.org/jira/browse/OAK-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela updated OAK-5025: Component/s: (was: security) core > Speed up ACE node name generation > - > > Key: OAK-5025 > URL: https://issues.apache.org/jira/browse/OAK-5025 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.5.12 >Reporter: Alex COLLIGNON >Priority: Minor > > Currently, > {{o.a.j.oak.security.authorization.accesscontrol.Util#generateAceName}} is > traversing all the existing ACE of a certain node in order to generate > continuous numbering (allow0, allow1, allow2). > While that certainly helps to produce human readable names, it represents > quite a performance bottleneck when the number of existing ACE starts to grow. > Since the naming is a pure implementation detail, my proposal is to keep the > continuous numbering for the first hundreds of nodes and then use a random > number to generate unique names in a faster fashion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OAK-5025) Speed up ACE node name generation
[ https://issues.apache.org/jira/browse/OAK-5025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex COLLIGNON updated OAK-5025: Priority: Minor (was: Major) > Speed up ACE node name generation > - > > Key: OAK-5025 > URL: https://issues.apache.org/jira/browse/OAK-5025 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: security >Affects Versions: 1.5.12 >Reporter: Alex COLLIGNON >Priority: Minor > > Currently, > {{o.a.j.oak.security.authorization.accesscontrol.Util#generateAceName}} is > traversing all the existing ACE of a certain node in order to generate > continuous numbering (allow0, allow1, allow2). > While that certainly helps to produce human readable names, it represents > quite a performance bottleneck when the number of existing ACE starts to grow. > Since the naming is a pure implementation detail, my proposal is to keep the > continuous numbering for the first hundreds of nodes and then use a random > number to generate unique names in a faster fashion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)