[jira] [Updated] (OAK-5055) o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
[
https://issues.apache.org/jira/browse/OAK-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-5055:
Fix Version/s: 1.6
> o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
>
>
> Key: OAK-5055
> URL: https://issues.apache.org/jira/browse/OAK-5055
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Affects Versions: 1.5.12
>Reporter: Timothee Maret
>Assignee: Timothee Maret
> Fix For: 1.6, 1.5.13
>
> Attachments: OAK-5055.patch, OAK-5055.patch, OAK-5055.patch
>
>
> According to the API [0], the method {{RevisionGC#startRevisionGC}} should
> {code}
> @return the status of the operation right after it was initiated
> {code}
> However, it does return {{succeeded}} on every call, see [1].
> I believe this should either compute the actual state, or return
> {{initiated}} or {{running}}.
> Same applies for {{cancelRevisionGC}}.
> [0]
> https://github.com/apache/jackrabbit-oak/blob/18d69e6f590064585414f12bda724f48f3d5843f/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGCMBean.java#L34-L40
> [1]
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L105
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L123
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-5055) o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
[
https://issues.apache.org/jira/browse/OAK-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated OAK-5055:
Attachment: OAK-5055.patch
Attaching a patch that
* expose the {{initiated(id,message)}} like methods
* return the {{initiated}} status when starting an async action
* return the same gcOp id except when starting the async action fails (because
there already is an action running or because there was none running)
> o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
>
>
> Key: OAK-5055
> URL: https://issues.apache.org/jira/browse/OAK-5055
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Affects Versions: 1.5.12
>Reporter: Timothee Maret
>Assignee: Timothee Maret
> Fix For: 1.5.13
>
> Attachments: OAK-5055.patch, OAK-5055.patch, OAK-5055.patch
>
>
> According to the API [0], the method {{RevisionGC#startRevisionGC}} should
> {code}
> @return the status of the operation right after it was initiated
> {code}
> However, it does return {{succeeded}} on every call, see [1].
> I believe this should either compute the actual state, or return
> {{initiated}} or {{running}}.
> Same applies for {{cancelRevisionGC}}.
> [0]
> https://github.com/apache/jackrabbit-oak/blob/18d69e6f590064585414f12bda724f48f3d5843f/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGCMBean.java#L34-L40
> [1]
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L105
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L123
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-5055) o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
[
https://issues.apache.org/jira/browse/OAK-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated OAK-5055:
Attachment: OAK-5055.patch
Attaching a patch returning {{initiated}}.
> o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
>
>
> Key: OAK-5055
> URL: https://issues.apache.org/jira/browse/OAK-5055
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Affects Versions: 1.5.12
>Reporter: Timothee Maret
>Assignee: Timothee Maret
> Fix For: 1.5.13
>
> Attachments: OAK-5055.patch, OAK-5055.patch
>
>
> According to the API [0], the method {{RevisionGC#startRevisionGC}} should
> {code}
> @return the status of the operation right after it was initiated
> {code}
> However, it does return {{succeeded}} on every call, see [1].
> I believe this should either compute the actual state, or return
> {{initiated}} or {{running}}.
> Same applies for {{cancelRevisionGC}}.
> [0]
> https://github.com/apache/jackrabbit-oak/blob/18d69e6f590064585414f12bda724f48f3d5843f/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGCMBean.java#L34-L40
> [1]
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L105
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L123
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-5055) o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
[
https://issues.apache.org/jira/browse/OAK-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Dürig updated OAK-5055:
---
Fix Version/s: 1.5.13
> o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
>
>
> Key: OAK-5055
> URL: https://issues.apache.org/jira/browse/OAK-5055
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Affects Versions: 1.5.12
>Reporter: Timothee Maret
>Assignee: Timothee Maret
> Fix For: 1.5.13
>
> Attachments: OAK-5055.patch
>
>
> According to the API [0], the method {{RevisionGC#startRevisionGC}} should
> {code}
> @return the status of the operation right after it was initiated
> {code}
> However, it does return {{succeeded}} on every call, see [1].
> I believe this should either compute the actual state, or return
> {{initiated}} or {{running}}.
> Same applies for {{cancelRevisionGC}}.
> [0]
> https://github.com/apache/jackrabbit-oak/blob/18d69e6f590064585414f12bda724f48f3d5843f/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGCMBean.java#L34-L40
> [1]
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L105
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L123
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-5055) o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
[
https://issues.apache.org/jira/browse/OAK-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated OAK-5055:
Attachment: OAK-5055.patch
Attaching a svn compatible patch.
[~mduerig] could you have a look ?
> o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
>
>
> Key: OAK-5055
> URL: https://issues.apache.org/jira/browse/OAK-5055
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Affects Versions: 1.5.12
>Reporter: Timothee Maret
>Assignee: Timothee Maret
> Attachments: OAK-5055.patch
>
>
> According to the API [0], the method {{RevisionGC#startRevisionGC}} should
> {code}
> @return the status of the operation right after it was initiated
> {code}
> However, it does return {{succeeded}} on every call, see [1].
> I believe this should either compute the actual state, or return
> {{initiated}} or {{running}}.
> Same applies for {{cancelRevisionGC}}.
> [0]
> https://github.com/apache/jackrabbit-oak/blob/18d69e6f590064585414f12bda724f48f3d5843f/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGCMBean.java#L34-L40
> [1]
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L105
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L123
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (OAK-5055) o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
[
https://issues.apache.org/jira/browse/OAK-5055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothee Maret updated OAK-5055:
Flags: Patch
> o.a.j.o.s.s.RevisionGC returns status that don't comply with the API
>
>
> Key: OAK-5055
> URL: https://issues.apache.org/jira/browse/OAK-5055
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Affects Versions: 1.5.12
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>
> According to the API [0], the method {{RevisionGC#startRevisionGC}} should
> {code}
> @return the status of the operation right after it was initiated
> {code}
> However, it does return {{succeeded}} on every call, see [1].
> I believe this should either compute the actual state, or return
> {{initiated}} or {{running}}.
> Same applies for {{cancelRevisionGC}}.
> [0]
> https://github.com/apache/jackrabbit-oak/blob/18d69e6f590064585414f12bda724f48f3d5843f/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGCMBean.java#L34-L40
> [1]
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L105
> https://github.com/apache/jackrabbit-oak/blob/e873825b92faf14b7ef52130c36e6466edcef6b0/oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/RevisionGC.java#L123
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
