Re: [Ocfs2-devel] [PATCH] ocfs2/cluster: neaten a member of o2net_msg_handler

2017-12-05 Thread Joseph Qi 


On 17/12/5 13:47, Changwei Ge wrote:
> It's odd that o2net_msg_handler::nh_func_data is declared as type
> o2net_msg_handler_func*.
> So neaten it.
> 
> Signed-off-by: Changwei Ge 
Reviewed-by: Joseph Qi 

> ---
>   fs/ocfs2/cluster/tcp_internal.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/cluster/tcp_internal.h 
> b/fs/ocfs2/cluster/tcp_internal.h
> index b95e7df5b76a..0276f7f8d5e6 100644
> --- a/fs/ocfs2/cluster/tcp_internal.h
> +++ b/fs/ocfs2/cluster/tcp_internal.h
> @@ -196,7 +196,7 @@ struct o2net_msg_handler {
>   u32 nh_msg_type;
>   u32 nh_key;
>   o2net_msg_handler_func  *nh_func;
> - o2net_msg_handler_func  *nh_func_data;
> + void*nh_func_data;
>   o2net_post_msg_handler_func
>   *nh_post_func;
>   struct kref nh_kref;
> 

___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH] ocfs2/cluster: neaten a member of o2net_msg_handler

2017-12-04 Thread alex chen 
Hi Changwei,

Thank you for your patch.

On 2017/12/5 13:47, Changwei Ge wrote:
> It's odd that o2net_msg_handler::nh_func_data is declared as type
> o2net_msg_handler_func*.
> So neaten it.
> 
> Signed-off-by: Changwei Ge 
Reviewed-by: Alex Chen 
> ---
>   fs/ocfs2/cluster/tcp_internal.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ocfs2/cluster/tcp_internal.h 
> b/fs/ocfs2/cluster/tcp_internal.h
> index b95e7df5b76a..0276f7f8d5e6 100644
> --- a/fs/ocfs2/cluster/tcp_internal.h
> +++ b/fs/ocfs2/cluster/tcp_internal.h
> @@ -196,7 +196,7 @@ struct o2net_msg_handler {
>   u32 nh_msg_type;
>   u32 nh_key;
>   o2net_msg_handler_func  *nh_func;
> - o2net_msg_handler_func  *nh_func_data;
> + void*nh_func_data;
>   o2net_post_msg_handler_func
>   *nh_post_func;
>   struct kref nh_kref;
> 


___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

[Ocfs2-devel] [PATCH] ocfs2/cluster: neaten a member of o2net_msg_handler

2017-12-04 Thread Changwei Ge 
It's odd that o2net_msg_handler::nh_func_data is declared as type
o2net_msg_handler_func*.
So neaten it.

Signed-off-by: Changwei Ge 
---
  fs/ocfs2/cluster/tcp_internal.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ocfs2/cluster/tcp_internal.h 
b/fs/ocfs2/cluster/tcp_internal.h
index b95e7df5b76a..0276f7f8d5e6 100644
--- a/fs/ocfs2/cluster/tcp_internal.h
+++ b/fs/ocfs2/cluster/tcp_internal.h
@@ -196,7 +196,7 @@ struct o2net_msg_handler {
u32 nh_msg_type;
u32 nh_key;
o2net_msg_handler_func  *nh_func;
-   o2net_msg_handler_func  *nh_func_data;
+   void*nh_func_data;
o2net_post_msg_handler_func
*nh_post_func;
struct kref nh_kref;
-- 
2.11.0

___
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel