Re: [Ocfs2-devel] [PATCH v2] ocfs2: clean dead code in suballoc.c
On 2017/12/13 12:03, Joseph Qi wrote: > > > On 17/12/13 11:51, Changwei Ge wrote: >> Stack variable fe is no longer used, so trim it to save some cpu cycles >> and stack space. >> >> -BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb, >> ocfs2_blocks_to_clusters(bitmap_inode->i_sb, start_blk))); > > Still malformed. You have to disable auto wrap length in your editor. Hi Joseph, Thanks for your tips, I will send a revised patch later. Thanks, Changwei > > Thanks, > Joseph > >> +BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb, >> +ocfs2_blocks_to_clusters(bitmap_inode->i_sb, >> + start_blk))); ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel
Re: [Ocfs2-devel] [PATCH v2] ocfs2: clean dead code in suballoc.c
On 17/12/13 11:51, Changwei Ge wrote: > Stack variable fe is no longer used, so trim it to save some cpu cycles > and stack space. > > Signed-off-by: Changwei Ge > --- > fs/ocfs2/suballoc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c > index 71f22c8fbffd..508422b0032f 100644 > --- a/fs/ocfs2/suballoc.c > +++ b/fs/ocfs2/suballoc.c > @@ -2566,16 +2566,16 @@ static int _ocfs2_free_clusters(handle_t *handle, > int status; > u16 bg_start_bit; > u64 bg_blkno; > - struct ocfs2_dinode *fe; > > /* You can't ever have a contiguous set of clusters >* bigger than a block group bitmap so we never have to worry >* about looping on them. >* This is expensive. We can safely remove once this stuff has >* gotten tested really well. */ > - BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb, > ocfs2_blocks_to_clusters(bitmap_inode->i_sb, start_blk))); Still malformed. You have to disable auto wrap length in your editor. Thanks, Joseph > + BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb, > + ocfs2_blocks_to_clusters(bitmap_inode->i_sb, > + start_blk))); > > - fe = (struct ocfs2_dinode *) bitmap_bh->b_data; > > ocfs2_block_to_cluster_group(bitmap_inode, start_blk, &bg_blkno, >&bg_start_bit); > ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel
[Ocfs2-devel] [PATCH v2] ocfs2: clean dead code in suballoc.c
Stack variable fe is no longer used, so trim it to save some cpu cycles and stack space. Signed-off-by: Changwei Ge --- fs/ocfs2/suballoc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c index 71f22c8fbffd..508422b0032f 100644 --- a/fs/ocfs2/suballoc.c +++ b/fs/ocfs2/suballoc.c @@ -2566,16 +2566,16 @@ static int _ocfs2_free_clusters(handle_t *handle, int status; u16 bg_start_bit; u64 bg_blkno; - struct ocfs2_dinode *fe; /* You can't ever have a contiguous set of clusters * bigger than a block group bitmap so we never have to worry * about looping on them. * This is expensive. We can safely remove once this stuff has * gotten tested really well. */ - BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb, ocfs2_blocks_to_clusters(bitmap_inode->i_sb, start_blk))); + BUG_ON(start_blk != ocfs2_clusters_to_blocks(bitmap_inode->i_sb, + ocfs2_blocks_to_clusters(bitmap_inode->i_sb, +start_blk))); - fe = (struct ocfs2_dinode *) bitmap_bh->b_data; ocfs2_block_to_cluster_group(bitmap_inode, start_blk, &bg_blkno, &bg_start_bit); -- 2.11.0 ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel
