-Original Message-
From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf
Of Marcel Holtmann
Sent: Thursday, March 11, 2010 12:59 AM
To: ofono@ofono.org
Subject: Re: [PATCH 1/1] install data file
Hi Martin,
Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index fcee5e6..007d5b9 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -45,7 +45,7 @@ INCLUDES = -I$(top_srcdir)/src -I$(top_builddir)/src
CLEANFILES = src/control.moc $(nodist_src_phonesim_SOURCES)
-EXTRA_DIST = src/controlbase.ui src/default.xml src/GSMSpecification.xml
+dist_pkgdata_DATA = src/controlbase.ui src/moblin.xml
src/GSMSpecification.xml
this looks wrong. You should not be installing src/controlbase.ui and
don't bother installing GSMSpecification.xml. I just put that into the
source code for reference.
Also if you wanna install default.xml, then it needs to be installed
in /etc/phonesim/ and not just somewhere.
I am afraid that I am not be persuaded. ;-)
I think *.xml is the data file containing the AT commands simulation data, and
not the config file. So I think it is not suitable to put it at /etc.
And the proper place is data directory, /usr/share/phonesim. And install
GSMSpecification.xml there is convenient for user to reference, they need not
find the source package.
Think of wpa_s package, they will put all the types of conf example at example
directory
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
