Re: Reg: Supporting Operator Preferred List in oFono

[Sankar]

Hi Denis,


On Wed, Mar 23, 2011 at 7:56 PM, Denis Kenzior  wrote:

> Hi Sankar,
>
> On 03/23/2011 06:52 AM, Sankar wrote:
> > Hi ,
> >
> > I would like to know if there is any proposal to support the Operator
> > Preferred List in oFono. This is being a key feature, allowing the user
> > to add/delete/modify the PLMNSel, PLMNWact files on the card, which are
> > used by the Baseband during the network registration procedures.
> >
>
> This is not (and unlikely to be) a priority feature.  These lists are
> mostly managed by the modem and do not need oFono's intervention.

I agree lists are used by Modem, but definitely oFono's intervention is
required if the user wants to modify this list.

>


> If you need this feature then I suggest you add a task to the TODO list
> and go about finding someone to implement it ;)
>
I will explore this. I have not added any TODOs before.

>
> Regards,
> -Denis
>
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: [PATCH 2/6] stk-api.txt: Describe new d-bus APIs related to BIP commands.

[Denis Kenzior]

Hi Philippe,

On 03/22/2011 07:51 AM, Philippe Nunes wrote:
> ---
>  doc/stk-api.txt |   27 ++-
>  1 files changed, 26 insertions(+), 1 deletions(-)
> 
> diff --git a/doc/stk-api.txt b/doc/stk-api.txt
> index 529c734..772e4ce 100644
> --- a/doc/stk-api.txt
> +++ b/doc/stk-api.txt
> @@ -96,6 +96,7 @@ Methods byte RequestSelection(string title, 
> byte icon_id,
>   an error given below.
>  
>   Possible Errors: [service].Error.SimToolkit.GoBack
> +  [service].Error.SimToolkit.EndSession
>  
>   Implementation notes:
>  
> @@ -111,6 +112,7 @@ Methods   byte RequestSelection(string title, 
> byte icon_id,
>   cleared prior to the display of this text.
>  
>   Possible Errors: [service].Error.SimToolkit.GoBack
> +  [service].Error.SimToolkit.EndSession
>[service].Error.SimToolkit.Busy
>  
>   Implementation notes:
> @@ -154,6 +156,7 @@ Methods   byte RequestSelection(string title, 
> byte icon_id,
>   should be opaque.
>  
>   Possible Errors: [service].Error.SimToolkit.GoBack
> +  [service].Error.SimToolkit.EndSession
>  
>   Implementation notes:
>  
> @@ -171,6 +174,7 @@ Methods   byte RequestSelection(string title, 
> byte icon_id,
>   are expected.
>  
>   Possible Errors: [service].Error.SimToolkit.GoBack
> +  [service].Error.SimToolkit.EndSession
>  
>   string RequestKey(string alpha, byte icon_id)
>  
> @@ -179,6 +183,7 @@ Methods   byte RequestSelection(string title, 
> byte icon_id,
>   for the request.
>  
>   Possible Errors: [service].Error.SimToolkit.GoBack
> +  [service].Error.SimToolkit.EndSession
>  
>   string RequestDigit(string alpha, byte icon_id)
>  
> @@ -186,12 +191,14 @@ Methods byte RequestSelection(string title, 
> byte icon_id,
>   expected.
>  
>   Possible Errors: [service].Error.SimToolkit.GoBack
> +  [service].Error.SimToolkit.EndSession
>  
>   boolean RequestConfirmation(string alpha, byte icon_id)
>  
>   Asks the agent to get confirmation from the user.
>  
>   Possible Errors: [service].Error.SimToolkit.GoBack
> +  [service].Error.SimToolkit.EndSession
>  

That's great that you're fixing up the possible errors in the
documentation, but they really need to be in a separate patch.

>   boolean ConfirmCallSetup(string information, byte icon_id)
>  
> @@ -245,6 +252,7 @@ Methods   byte RequestSelection(string title, 
> byte icon_id,
>   Possible Errors: [service].Error.SimToolkit.EndSession
>  
>   void DisplayActionInformation(string text, byte icon_id)
> + [noreply]
>  

Why are you marking this noreply when we do actually expect one?

>   Supplies a text string and/or icon concerning the
>   current activity in the terminal and UICC.  The
> @@ -260,6 +268,23 @@ Methods  byte RequestSelection(string title, 
> byte icon_id,
>   confirmation message to oFono and then should open
>   the launch browser with the given url.
>  
> + boolean ConfirmOpenChannel(string information, byte icon_id)
> +
> + Asks the agent to request user to confirm the channel
> + set-up.
> +
> + Possible Errors: [service].Error.SimToolkit.EndSession
> +
> + void DisplayChannelActivity(string text, byte icon_id)
> +
> + Supplies a text string and/or icon concerning the
> + current activity linked to the channel set-up. The
> + text should be displayed to the user on screen
> + until the call is canceled using Cancel() or until the
> + user decides to end the session.
> +

Why can we not re-use DisplayActionInformation here?

> + Possible Errors: [service].Error.SimToolkit.EndSession
> +
>   void Cancel() [noreply]
>  
>   Asks the agent to cancel any ongoing operation in
> @@ -270,6 +295,6 @@ Methods   byte RequestSelection(string title, 
> byte icon_id,
>   void Release() [noreply]
>  
>   Agent is being released, possibly because of oFono
> - terminating, SimToolkit interface torn down or modem
> +

Re: buildroot

[Marcel Holtmann]

Hi Lucas,

> > first mail, please be gentle. I wish to create a new rootfs for my ARM920T
> > microcontroller based device using BUILDROOT. The device has a serial port
> > attached huawei 3G modem that could theoretically be used with stock
> > chap/ppp. I do vividly remember though my aggreviance with this before
> > finding wvdial, a simple, easy-to-use package to configure, initialize,
> > start, and monitor the pppd. Unfortunately, wvdial just can not be added to
> > my buidroot created rootFS. My question to the listmembers is twofold:
> > 1) am I right to assume that ofono is more than capable replacing my old
> > friend vwdial as shown here:
> > http://ofono.org/wiki/how-work-newly-bought-3g-key
> 
> Yes, but make sure to use udev instead of mdev (AFAIR mdev is the
> default in buildroot).

you just need libudev actually, but it does depend on udev.

> Other problem is that buildroot uses uClibc. Denis, do you know if
> there's any problem in building oFono with uClibc?

There might be small problems, but none that can not be fixed. To be
fair, I have not yet tried to get it all compiled with uClibc.

> If there is, you'd need to provide your own toolchain (take one from
> CodeSourcery).
> 
> 
> > 2) if so, is there a makefile I could use to add ofono to my otherwise
> > functional buildroot conf?
> 
> oFono uses autotools for building. If you are using the git
> repository, you need to run './bootstrap && ./configure' first. Then
> you'll have a Makefile.

If you use a packaged tarball, then only ./configure is sufficient.

However this question might be more targeted to a buildroot specific .mk
file and no, we do not have that.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: [PATCH 5/6] stkutil: Complete the TLV parsing/builder to support BIP commands

[Denis Kenzior]

Hi Philippe,

On 03/22/2011 07:51 AM, Philippe Nunes wrote:
> ---
>  src/stkutil.c |  300 
> +
>  src/stkutil.h |  141 +++
>  2 files changed, 402 insertions(+), 39 deletions(-)
> 
> diff --git a/src/stkutil.c b/src/stkutil.c
> index c64cb7a..b03dfb4 100644
> --- a/src/stkutil.c
> +++ b/src/stkutil.c
> @@ -1264,8 +1264,22 @@ static gboolean parse_dataobj_bearer_description(
>  
>   data = comprehension_tlv_iter_get_data(iter);
>   bd->type = data[0];
> - bd->len = len - 1;
> - memcpy(bd->pars, data + 1, bd->len);
> +
> + if (bd->type == STK_BEARER_TYPE_GPRS_UTRAN) {
> + if (len < 7)
> + return FALSE;
> +
> + bd->parameters.gprs.precedence = data[1];
> + bd->parameters.gprs.delay = data[2];
> + bd->parameters.gprs.reliability = data[3];
> + bd->parameters.gprs.peak = data[4];
> + bd->parameters.gprs.mean = data[5];
> + bd->parameters.gprs.pdp_type = data[6];

Please do me a favor and insert an empty line here.  I like the blocks
to be grouped logically, especially the bigger ones.

> + return TRUE;
> + }
> +
> + bd->parameters.other.len = len - 1;
> + memcpy(bd->parameters.other.pars, data + 1, bd->parameters.other.len);
>  
>   return TRUE;
>  }
> @@ -1356,7 +1370,11 @@ static gboolean parse_dataobj_other_address(
>  
>   data = comprehension_tlv_iter_get_data(iter);
>   oa->type = data[0];
> - memcpy(&oa->addr, data + 1, len - 1);
> +
> + if (oa->type == STK_ADDRESS_IPV4)
> + memcpy(&oa->addr.ipv4, data + 1, 4);
> + else
> + memcpy(&oa->addr.ipv6, data + 1, 16);

You might want to be more paranoid here, don't assume that just because
oa->type != STK_ADDRESS_IPV4 it will be IPv6.

>  
>   return TRUE;
>  }
> @@ -1604,16 +1622,33 @@ static gboolean parse_dataobj_esn(struct 
> comprehension_tlv_iter *iter,
>  static gboolean parse_dataobj_network_access_name(
>   struct comprehension_tlv_iter *iter, void *user)
>  {
> - struct stk_network_access_name *nan = user;
> + struct stk_network_access_name *apn = user;
>   const unsigned char *data;
>   unsigned int len = comprehension_tlv_iter_get_length(iter);
> + size_t label_size;

Why is unsigned char not sufficient?

>  
> - if (len == 0)
> + if ((len == 0) || (len > 100))

Please don't do this, unnecessary parentheses are a distraction.  Learn
the precedence of operators or do like I do it: use a cheat sheet.

>   return FALSE;
>  
>   data = comprehension_tlv_iter_get_data(iter);
> - nan->len = len;
> - memcpy(nan->name, data, len);
> + /*
> +  * As specified in TS 23 003 Section 9
> +  * The APN consists of one or more labels. Each label is coded as
> +  * a one octet length field followed by that number of octets coded
> +  * as 8 bit ASCII characters
> +  */
> +
> + while (len) {
> + label_size = *data;
> + data++;
> + strncat((char *)apn->name, (char *)data, label_size);
> + data += label_size;
> + len -= label_size + 1;
> + if (len)

doc/coding-style.txt, item M1

> + strcat((char *)apn->name, ".");
> + }
> +
> + apn->len = strlen((const char *)apn->name);

Overall this code is pretty inefficient and not paranoid enough.

For paranoidness: you need to be making sure that label_size is sane and
not going to take you past your tlv length.

For efficiency: use memcpy and direct assignment instead of strncat.
While strncat is certainly fast, it still forces you to scan the entire
dest string to find its length.

>  
>   return TRUE;
>  }
> @@ -3274,7 +3309,68 @@ static enum stk_command_parse_result 
> parse_launch_browser(
>   STK_DATA_OBJECT_TYPE_INVALID);
>  }
>  
> -/* TODO: parse_open_channel */
> +static void destroy_open_channel(struct stk_command *command)
> +{
> + g_free(command->open_channel.alpha_id);
> + g_free(command->open_channel.text_usr);
> + g_free(command->open_channel.text_passwd);
> +}
> +
> +static enum stk_command_parse_result parse_open_channel(
> + struct stk_command *command,
> + struct comprehension_tlv_iter *iter)
> +{
> + struct stk_command_open_channel *obj = &command->open_channel;
> + enum stk_command_parse_result status;
> +
> + if (command->qualifier >= 0x08)
> + return STK_PARSE_RESULT_DATA_NOT_UNDERSTOOD;

I know you're only parsing a particular type of Open Channel, but it
might be a good idea to check this once that type has been determined.

> +
> + if (command->src != STK_DEVICE_IDENTITY_TYPE_UICC)
> + return STK_PARSE_RESULT_DATA_NOT_UNDERSTOOD;
> +
> + if (command->dst != STK_DEVICE_IDENTITY_TYPE_T

Re: buildroot

[Lucas De Marchi]

On Wed, Mar 23, 2011 at 1:01 PM, Jerry Casette  wrote:
> Hello List,
>
> first mail, please be gentle. I wish to create a new rootfs for my ARM920T
> microcontroller based device using BUILDROOT. The device has a serial port
> attached huawei 3G modem that could theoretically be used with stock
> chap/ppp. I do vividly remember though my aggreviance with this before
> finding wvdial, a simple, easy-to-use package to configure, initialize,
> start, and monitor the pppd. Unfortunately, wvdial just can not be added to
> my buidroot created rootFS. My question to the listmembers is twofold:
> 1) am I right to assume that ofono is more than capable replacing my old
> friend vwdial as shown here:
> http://ofono.org/wiki/how-work-newly-bought-3g-key

Yes, but make sure to use udev instead of mdev (AFAIR mdev is the
default in buildroot).

Other problem is that buildroot uses uClibc. Denis, do you know if
there's any problem in building oFono with uClibc?

If there is, you'd need to provide your own toolchain (take one from
CodeSourcery).


> 2) if so, is there a makefile I could use to add ofono to my otherwise
> functional buildroot conf?

oFono uses autotools for building. If you are using the git
repository, you need to run './bootstrap && ./configure' first. Then
you'll have a Makefile.


regards,

Lucas De Marchi
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: [PATCH] common: fix buffer length in phone_number_to_string

[Denis Kenzior]

Hi Frédéric,

On 03/23/2011 12:16 PM, Frédéric Danis wrote:
> update buffer length related to OFONO_MAX_PHONE_NUMBER_LENGTH change
> 78c1e96bf9601b5e5d31d04413baa1265a1c284f
> ---
>  src/common.c |   10 +-
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 

Nice catch.  Patch has been applied, thanks.

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: [PATCH] gatserver: add ATZ command

[Denis Kenzior]

Hi Olivier,

On 03/23/2011 11:31 AM, Olivier Guiter wrote:
> ---
>  gatchat/gatserver.c |   53 +-
>  1 files changed, 35 insertions(+), 18 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: [PATCH] modem: add AT+GCAP command

[Denis Kenzior]

Hi Olivier,

On 03/23/2011 11:08 AM, Olivier Guiter wrote:
> ---
>  src/modem.c |7 +++
>  1 files changed, 7 insertions(+), 0 deletions(-)

Patch has been applied, thanks.

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

[PATCH] common: fix buffer length in phone_number_to_string

[Frédéric Danis]

update buffer length related to OFONO_MAX_PHONE_NUMBER_LENGTH change
78c1e96bf9601b5e5d31d04413baa1265a1c284f
---
 src/common.c |   10 +-
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/common.c b/src/common.c
index 520360c..e65a677 100644
--- a/src/common.c
+++ b/src/common.c
@@ -422,16 +422,16 @@ int mmi_service_code_to_bearer_class(int code)
 
 const char *phone_number_to_string(const struct ofono_phone_number *ph)
 {
-   static char buffer[64];
+   static char buffer[OFONO_MAX_PHONE_NUMBER_LENGTH + 2];
 
if (ph->type == 145 && (strlen(ph->number) > 0) &&
ph->number[0] != '+') {
buffer[0] = '+';
-   strncpy(buffer + 1, ph->number, 62);
-   buffer[63] = '\0';
+   strncpy(buffer + 1, ph->number, OFONO_MAX_PHONE_NUMBER_LENGTH);
+   buffer[OFONO_MAX_PHONE_NUMBER_LENGTH + 1] = '\0';
} else {
-   strncpy(buffer, ph->number, 63);
-   buffer[63] = '\0';
+   strncpy(buffer, ph->number, OFONO_MAX_PHONE_NUMBER_LENGTH + 1);
+   buffer[OFONO_MAX_PHONE_NUMBER_LENGTH + 1] = '\0';
}
 
return buffer;
-- 
1.7.1

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

[PATCH] gatserver: add ATZ command

[Olivier Guiter]

---
 gatchat/gatserver.c |   53 +-
 1 files changed, 35 insertions(+), 18 deletions(-)

diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c
index 4a211ad..57cc58e 100644
--- a/gatchat/gatserver.c
+++ b/gatchat/gatserver.c
@@ -279,6 +279,24 @@ static gboolean get_result_value(GAtServer *server, 
GAtResult *result,
return TRUE;
 }
 
+static void v250_settings_create(struct v250_settings *v250)
+{
+   v250->s0 = 0;
+   v250->s3 = '\r';
+   v250->s4 = '\n';
+   v250->s5 = '\b';
+   v250->s6 = 2;
+   v250->s7 = 50;
+   v250->s8 = 2;
+   v250->s10 = 2;
+   v250->echo = TRUE;
+   v250->quiet = FALSE;
+   v250->is_v1 = TRUE;
+   v250->res_format = 0;
+   v250->c109 = 1;
+   v250->c108 = 0;
+}
+
 static void s_template_cb(GAtServerRequestType type, GAtResult *result,
GAtServer *server, char *sreg,
const char *prefix, int min, int max)
@@ -446,6 +464,22 @@ static void at_c108_cb(GAtServer *server, 
GAtServerRequestType type,
at_template_cb(type, result, server, &server->v250.c108, "&D", 0, 2, 2);
 }
 
+static void at_z_cb(GAtServer *server, GAtServerRequestType type,
+   GAtResult *result, gpointer user_data)
+{
+
+   switch (type) {
+   case G_AT_SERVER_REQUEST_TYPE_COMMAND_ONLY:
+   v250_settings_create(&server->v250);
+   g_at_server_send_final(server, G_AT_SERVER_RESULT_OK);
+   break;
+
+   default:
+   g_at_server_send_final(server, G_AT_SERVER_RESULT_ERROR);
+   break;
+   }
+}
+
 static inline gboolean is_extended_command_prefix(const char c)
 {
switch (c) {
@@ -1073,24 +1107,6 @@ static void server_resume(GAtServer *server)
g_at_io_set_read_handler(server->io, new_bytes, server);
 }
 
-static void v250_settings_create(struct v250_settings *v250)
-{
-   v250->s0 = 0;
-   v250->s3 = '\r';
-   v250->s4 = '\n';
-   v250->s5 = '\b';
-   v250->s6 = 2;
-   v250->s7 = 50;
-   v250->s8 = 2;
-   v250->s10 = 2;
-   v250->echo = TRUE;
-   v250->quiet = FALSE;
-   v250->is_v1 = TRUE;
-   v250->res_format = 0;
-   v250->c109 = 1;
-   v250->c108 = 0;
-}
-
 static void at_notify_node_destroy(gpointer data)
 {
struct at_command *node = data;
@@ -1117,6 +1133,7 @@ static void basic_command_register(GAtServer *server)
g_at_server_register(server, "S10", at_s10_cb, NULL, NULL);
g_at_server_register(server, "&C", at_c109_cb, NULL, NULL);
g_at_server_register(server, "&D", at_c108_cb, NULL, NULL);
+   g_at_server_register(server, "Z", at_z_cb, NULL, NULL);
 }
 
 GAtServer *g_at_server_new(GIOChannel *io)
-- 
1.7.1

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

[PATCH] modem: add AT+GCAP command

[Olivier Guiter]

---
 src/modem.c |7 +++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/modem.c b/src/modem.c
index 26468e8..655994b 100644
--- a/src/modem.c
+++ b/src/modem.c
@@ -1386,6 +1386,12 @@ static void gmr_cb(struct ofono_emulator *em,
attr_template(em, req, info->revision);
 }
 
+static void gcap_cb(struct ofono_emulator *em,
+   struct ofono_emulator_request *req, void *userdata)
+{
+   attr_template(em, req, "+GCAP: +CGSM");
+}
+
 static void dun_watch(struct ofono_atom *atom,
enum ofono_atom_watch_condition cond, void *data)
 {
@@ -1397,6 +1403,7 @@ static void dun_watch(struct ofono_atom *atom,
ofono_emulator_add_handler(em, "+GMI", gmi_cb, data, NULL);
ofono_emulator_add_handler(em, "+GMM", gmm_cb, data, NULL);
ofono_emulator_add_handler(em, "+GMR", gmr_cb, data, NULL);
+   ofono_emulator_add_handler(em, "+GCAP", gcap_cb, data, NULL);
 }
 
 int ofono_devinfo_driver_register(const struct ofono_devinfo_driver *d)
-- 
1.7.1

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

buildroot

[Jerry Casette]

Hello List,

first mail, please be gentle. I wish to create a new rootfs for my ARM920T
microcontroller based device using BUILDROOT. The device has a serial port
attached huawei 3G modem that could theoretically be used with stock
chap/ppp. I do vividly remember though my aggreviance with this before
finding wvdial, a simple, easy-to-use package to configure, initialize,
start, and monitor the pppd. Unfortunately, wvdial just can not be added to
my buidroot created rootFS. My question to the listmembers is twofold:
1) am I right to assume that ofono is more than capable replacing my old
friend vwdial as shown here:
http://ofono.org/wiki/how-work-newly-bought-3g-key
2) if so, is there a makefile I could use to add ofono to my otherwise
functional buildroot conf?

Any help would be much appreciated.

TIA,
Jerry O_O
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: [PATCH 1/1] stk: Fix getenv failure case

[Denis Kenzior]

Hi Jeevaka,

On 03/23/2011 06:42 AM, Jeevaka Badrappan wrote:
> ---
>  src/stk.c |6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 

Patch has been applied, thanks.

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: USSD network initiated support

[Denis Kenzior]

Hi Bertrand,

On 03/23/2011 06:10 AM, Aygon, Bertrand wrote:
> Hi,
> 
>  
> 
> In doc/overview.txt , I could see that there is some work in progress
> about USSD network initiated. But I couldn’t find anything about if in
> the TODO.
> 
> 

doc/overview.txt is out of date...

> 
> Does that means that USSD network initiated support is just something
> that we should work on, but no one is looking into? Or is someone
> working on it, but the TODO has not been updated?
> 
> 

Network initiated USSD has been available for about a year now, it was
available before the existence of doc/features.txt.

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: Reg: Supporting Operator Preferred List in oFono

[Denis Kenzior]

Hi Sankar,

On 03/23/2011 06:52 AM, Sankar wrote:
> Hi ,
> 
> I would like to know if there is any proposal to support the Operator
> Preferred List in oFono. This is being a key feature, allowing the user
> to add/delete/modify the PLMNSel, PLMNWact files on the card, which are
> used by the Baseband during the network registration procedures.
> 

This is not (and unlikely to be) a priority feature.  These lists are
mostly managed by the modem and do not need oFono's intervention.

If you need this feature then I suggest you add a task to the TODO list
and go about finding someone to implement it ;)

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Reg: Supporting Operator Preferred List in oFono

[Sankar]

Hi ,

I would like to know if there is any proposal to support the Operator
Preferred List in oFono. This is being a key feature, allowing the user to
add/delete/modify the PLMNSel, PLMNWact files on the card, which are used by
the Baseband during the network registration procedures.

Thanks,
Sankar.
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

[PATCH 0/1] Handle getenv failure case

[Jeevaka Badrappan]

Hi,

If ofono is started before setting the LANG enviroment variable, then
call to getenv fails. This results in the failure of test case
Provide Local Information - Language setting(27.22.4.15 seq 1.5).

Plan is to default to en when the getenv fails. Warning message has
also been added. Distribution will be informed to start ofono after
the locale is set.

Regards,
Jeevaka

Jeevaka Badrappan (1):
  stk: Fix getenv failure case

 src/stk.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

[PATCH 1/1] stk: Fix getenv failure case

[Jeevaka Badrappan]

---
 src/stk.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/stk.c b/src/stk.c
index 68b6240..94ad396 100644
--- a/src/stk.c
+++ b/src/stk.c
@@ -2177,8 +2177,9 @@ static void get_lang(struct stk_response *rsp, struct 
ofono_stk *stk)
 
l = getenv("LANG");
if (l == NULL) {
-   rsp->result.type = STK_RESULT_TYPE_NOT_CAPABLE;
-   goto out;
+   l = "en";
+   ofono_warn("LANG environment variable not set"
+   " - defaulting to en");
}
 
memcpy(lang, l, 2);
@@ -2187,7 +2188,6 @@ static void get_lang(struct stk_response *rsp, struct 
ofono_stk *stk)
rsp->result.type = STK_RESULT_TYPE_SUCCESS;
rsp->provide_local_info.language = lang;
 
-out:
if (stk_respond(stk, rsp, stk_command_cb))
stk_command_cb(&failure, stk);
 }
-- 
1.7.0.4

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

USSD network initiated support

[Aygon, Bertrand]

Hi,

In doc/overview.txt , I could see that there is some work in progress about 
USSD network initiated. But I couldn't find anything about if in the TODO.

Does that means that USSD network initiated support is just something that we 
should work on, but no one is looking into? Or is someone working on it, but 
the TODO has not been updated?

Thanks,

Bertrand.

--
Bertrand Aygon  Engineering Manager
bertrand.ay...@intel.comOpen 
Source Technology Center, Intel Corporation

-
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris, 
92196 Meudon Cedex, France
Registration Number:  302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

RE: ConnectionContext on Nokia 6760s-1

[claudio Degioanni]

On Tue, 2011-03-22 at 18:57 +, mika.liljeb...@nokia.com wrote:
> Hi Claudio,
> 
> > Hi,
> > 
> > We have tried to attach an Nokia 6760s-1, for using it like 3G modem.
> > Ofono manages correctly the mobile phone creating /isiusb0/
> > and /isiusb0/context1 and i think it uses the isi modem driver.
> > 
> > Next we have activated the pdp context, but it returns the following
> > dbus exception 
> > 
> > org.ofono.Error.NotAttached GPRS is not attached
> 
> This basically means that oFono thinks the modem is not attached to the GPRS 
> service. Did you set the modem online before trying this (e.g. by running the 
> online-modem script from the test directory)?
> 
> > is it possible to use the nokia phone as 3G modem?
> 
> Should be possible, although it may be that the driver needs minor 
> modifications for 6760. Depends on the ISI interface versions of the modem 
> firmware.
> 
> If it won't work, you can set the OFONO_ISI_DEBUG and OFONO_ISI_TRACE 
> environment variables to get more verbose logging. We'd need the full log 
> output to check what is going wrong.
> 
> Br,

Hi Mikal,

I have used the enable modem script in test directory using 

claudio@claudio-ThinkPad-R61:~/workspace/ofono/ofono-0.44/test
$ ./online-modem 
Setting modem /isiusb0 online...

But i obtain the same 

error org.ofono.Error.NotAttached GPRS is not attached

Attached to this mail there is the log of ofono with OFONO_ISI_DEBUG
OFONO_ISI_TRACE variables enable.

Any suggestion can how resolve the problem ?

regs

> 
>   MikaL
> ___
> ofono mailing list
> ofono@ofono.org
> http://lists.ofono.org/listinfo/ofono

ofonod[8681]: plugins/isiusb.c:phonet_status_cb() Link usbpn0 (13) is up
ofonod[8681]: gisi: Ping sent COMMON (0x831de48) [res=0x15]
ofonod[8681]: PN_MTC (0x15): MTC_COMMON_MESSAGE [id=0xF0 utid=0x01 len=8]:
ofonod[8681]: * 01 F0 13 11 11 00 00 00 : .
ofonod[8681]: gisi: Success COMMON to 0x831de48 [res=0x15, id=0xF0, utid=0x01]
ofonod[8681]: plugins/isiusb.c:reachable_cb() QSO: PN_MTC [0x15] v017.017
ofonod[8681]: gisi: Subscribed for IND (0x831a200) [res=0x15, id=0xC0]
ofonod[8681]: PN_MTC (0x15): MTC_STATE_QUERY_REQ [id=0x02 utid=0x02 len=4]:
ofonod[8681]: * 02 02 00 00 : .
ofonod[8681]: PN_MTC (0x15): MTC_STATE_QUERY_RESP [id=0x65 utid=0x02 len=4]:
ofonod[8681]: * 02 65 01 01 : ..e..
ofonod[8681]: gisi: Success RESP to 0x831de48 [res=0x15, id=0x65, utid=0x02]
ofonod[8681]: plugins/isiusb.c:mtc_query_cb() Modem state: current=MTC_NORMAL 
(0x01) target=MTC_NORMAL (0x01)
ofonod[8681]: src/modem.c:modem_change_state() old state: 0, new state: 1
ofonod[8681]: plugins/isiusb.c:isiusb_pre_sim() (0x831a960) with usbpn0
ofonod[8681]: gisi: Subscribed for IND (0x831c130) [res=0x09, id=0xEF]
ofonod[8681]: gisi: Ping sent COMMON (0x831d518) [res=0x09]
ofonod[8681]: gisi: Ping sent COMMON (0x8315b98) [res=0x1B]
ofonod[8681]: gisi: Ping sent COMMON (0x831e228) [res=0x01]
ofonod[8681]: PN_SIM (0x09): SIM_COMMON_MESSAGE [id=0xF0 utid=0x01 len=4]:
ofonod[8681]: * 01 F0 00 FA : .
ofonod[8681]: gisi: Success COMMON to 0x831d518 [res=0x09, id=0xF0, utid=0x01]
ofonod[8681]: drivers/isimodem/sim.c:sim_reachable_cb() QSO: PN_SIM [0x09] 
v-01.-01
ofonod[8681]: PN_SIM (0x09): SIM_NETWORK_INFO_REQ [id=0x19 utid=0x02 len=4]:
ofonod[8681]: * 02 19 2F 00 : .../.
ofonod[8681]: PN_PHONE_INFO (0x1B): INFO_COMMON_MESSAGE [id=0xF0 utid=0x01 
len=8]:
ofonod[8681]: * 01 F0 13 06 01 00 00 00 : .
ofonod[8681]: gisi: Success COMMON to 0x8315b98 [res=0x1B, id=0xF0, utid=0x01]
ofonod[8681]: drivers/isimodem/devinfo.c:reachable_cb() QSO: PN_PHONE_INFO 
[0x1B] v006.001
ofonod[8681]: PN_PHONE_INFO (0x1B): INFO_PRODUCT_INFO_READ_REQ [id=0x15 
utid=0x02 len=3]:
ofonod[8681]: * 02 15 07: 
ofonod[8681]: PN_CALL (0x01): CALL_COMMON_MESSAGE [id=0xF0 utid=0x01 len=8]:
ofonod[8681]: * 01 F0 13 07 01 55 55 55 : ..UUU
ofonod[8681]: gisi: Success COMMON to 0x831e228 [res=0x01, id=0xF0, utid=0x01]
ofonod[8681]: drivers/isimodem/voicecall.c:isi_call_verify_cb() QSO: PN_CALL 
[0x01] v007.001
ofonod[8681]: gisi: Subscribed for IND (0x831a930) [res=0x01, id=0x0F]
ofonod[8681]: gisi: Subscribed for IND (0x831d518) [res=0x01, id=0x0C]
ofonod[8681]: PN_CALL (0x01): CALL_STATUS_REQ [id=0x0D utid=0x02 len=8]:
ofonod[8681]: * 02 0D F0 01 1C 04 02 00 : .
ofonod[8681]: PN_SIM (0x09): SIM_NETWORK_INFO_RESP [id=0x1A utid=0x02 len=8]:
ofonod[8681]: * 02 1A 2F 01 22 F2 88 00 : .../."...
ofonod[8681]: gisi: Success RESP to 0x831e250 [res=0x09, id=0x1A, utid=0x02]
ofonod[8681]: src/sim.c:ofono_sim_add_state_watch() 0x831e298
ofonod[8681]: src/sim.c:ofono_sim_add