Re: Trouble compiling ... Re: ofono fails to compile on gcc-6.3
Hi Denis, > CC drivers/rilmodem/network-registration.o > drivers/rilmodem/network-registration.c:40:32: error: unknown option > after ‘#pragma GCC diagnostic’ kind [-Werror=pragmas] >#pragma GCC diagnostic ignored "-Wrestrict" > cc1: error: unrecognized command line option ‘-Wno-format-truncation’ > [-Werror] > cc1: all warnings being treated as errors > > I commented out #pragma, and this allows compilation to > continue... until I hit same issue in > drivers/rilmodem/call-forwarding.c:41:32: >>> >>> Yeah, I'm not sure what to do with these. Marcel put in the #pragmas to >>> silence some warnings on GCC 8.x, but it seems GCC 6 doesn't know about >>> these #pragma directives and complains. >> /* Test for GCC > 3.2.0 */ >> #if __GNUC__ > 3 || \ >> (__GNUC__ == 3 && (__GNUC_MINOR__ > 2 || \ >>(__GNUC_MINOR__ == 2 && \ >> __GNUC_PATCHLEVEL__ >> > 0)) >> #pragma... >> #endif >> ? > > Marcel is taking care of the build system so I let him comment, but that > would be fine with me. Maybe you want to send something like this to the list > as a patch? > > Of course the real fix is to rewrite rilmodem properly so none of this is > needed... > >> Would it be possible to get reasonable error message when ell is not >> found? >> "ell not found, you need to install it, please see README file"? It >> took me a while to figure out... > > Sounds like a good idea. Marcel? we can try to improve the ELL detection especially since we now have internal vs external. However I need to look into this for all projects and not just oFono. So we might start with iwd here. Regards Marcel ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono
Re: [PATCH] fix compilation on gcc-6.3
Hi Pavel, On 12/29/2018 04:24 PM, Pavel Machek wrote: gcc-6 fails to compile ofono due to #pragma directives. Limit them to gcc versions where they are needed. Applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono
Re: [PATCH] document getting of ell, point people at useful docs
Hi Pavel, > Currently there's README and HACKING... each describing part of what > needs to be done to build ofono. > > Provide some cross-links and fix build example. > > diff --git a/HACKING b/HACKING > index 15ea291..b1bd599 100644 > --- a/HACKING > +++ b/HACKING > @@ -45,7 +45,8 @@ bootstrap-configure since it could export development > specific settings. > So the normal steps to checkout, build and install such a repository is > like this: > > - Checkout repository > + Checkout repositories > +# git clone git://git.kernel.org/pub/scm/libs/ell/ell.git > # git clone git://git.kernel.org/pub/scm/network/ofono/ofono.git > # cd ofono > so coming to think about it, I would actually make this a pre-step. Checkout Embedded Linux Library # git clone .. Also this documentation is primarily for maintainers and the few that deal with making the tarballs. Which is pretty much just me. > diff --git a/README b/README > index 45bb2e9..04a50a5 100644 > --- a/README > +++ b/README > @@ -16,11 +16,14 @@ To configure run: > ./configure --prefix=/usr --mandir=/usr/share/man \ > --sysconfdir=/etc --localstatedir=/var > > -Configure automatically searches for all required components and packages. > +Configure automatically searches for all required components and > +packages, except ell, mentioned below. > Nope. Since ELL is actually optional. It is clearly described just a few lines below. > To compile and install run: > make && make install > > +See "HACKING" file for details and step-by-step examples. > + And that is wrong as well. HACKING is for the developers and people just installing oFono should not look at that. In addition HACKING is not included in the tarballs (while README is) and so you not reference a file from README that is not in the tarballs. Regards Marcel ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono
