Re: [PATCH] rilmodem: set proto type during setting initial attach apn

[Denis Kenzior]

Hi JongSeok,

On 7/20/20 4:16 AM, JongSeok Won wrote:

Added the protocol type of initial attach apn depends on protocol
type in LTE Atom.
---
  drivers/rilmodem/lte.c | 6 --
  1 file changed, 4 insertions(+), 2 deletions(-)



Applied, thanks.

Regards,
-Denis

___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org

Re: [PATCH 1/2] netmon: support cell type LTE

[Denis Kenzior]

Hi JongSeok,

On 7/20/20 3:40 AM, JongSeok Won wrote:

---
  include/netmon.h |  3 +++
  src/netmon.c | 24 +++-
  2 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/include/netmon.h b/include/netmon.h
index a99d6ca9..53f9d393 100644
--- a/include/netmon.h
+++ b/include/netmon.h
@@ -72,6 +72,9 @@ enum ofono_netmon_info {
OFONO_NETMON_INFO_EARFCN, /* int */
OFONO_NETMON_INFO_EBAND, /* int */
OFONO_NETMON_INFO_CQI, /* int */
+   OFONO_NETMON_INFO_PCI, /* int */
+   OFONO_NETMON_INFO_TAC, /* int */
+   OFONO_NETMON_INFO_SNR, /* int */
OFONO_NETMON_INFO_INVALID,
  };
  
diff --git a/src/netmon.c b/src/netmon.c

index 9eacb3ca..320c8425 100644
--- a/src/netmon.c
+++ b/src/netmon.c
@@ -138,7 +138,7 @@ static void netmon_cell_info_dict_append(DBusMessageIter 
*dict,
intval = va_arg(*arglist, int);
  
  			CELL_INFO_DICT_APPEND(dict, "TimingAdvance",

-   intval, uint8_t, DBUS_TYPE_BYTE);
+   intval, uint32_t, DBUS_TYPE_UINT32);


This breaks the NetworkMonitor API since the signature for that particular 
property is documented as a 'byte'.  From what I recall this value has a range 
of 0..63 ?



break;
  
  		case OFONO_NETMON_INFO_PSC:

@@ -213,6 +213,28 @@ static void netmon_cell_info_dict_append(DBusMessageIter 
*dict,
intval, uint8_t, DBUS_TYPE_BYTE);
break;
  
+		case OFONO_NETMON_INFO_PCI:

+   intval = va_arg(*arglist, int);
+
+   CELL_INFO_DICT_APPEND(dict, "PhysicalCellId",
+   intval, uint16_t, DBUS_TYPE_UINT16);
+   break;
+
+   case OFONO_NETMON_INFO_TAC:
+   intval = va_arg(*arglist, int);
+
+   CELL_INFO_DICT_APPEND(dict, "TrackingAreaCode",
+   intval, uint16_t, DBUS_TYPE_UINT16);
+   break;
+
+   case OFONO_NETMON_INFO_SNR:
+   intval = va_arg(*arglist, int);
+
+   ofono_dbus_dict_append(dict, "SingalToNoiseRatio",
+   DBUS_TYPE_INT32, );
+
+   break;
+
case OFONO_NETMON_INFO_INVALID:
break;
}



These should also be documented in doc/networkmonitor-api.txt.

Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org

Re: [PATCH] rilmodem: fix typo error in netmon.c

[Denis Kenzior]

Hi JongSeok,

On 7/20/20 2:34 AM, JongSeok Won wrote:

---
  drivers/rilmodem/netmon.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)



Applied, thanks.

Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org