[PATCH 1/1] remove obsolete m4 macro

[Nikhil Jha]

As per https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html
LT_INIT should be used instead.
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 3655a112..06ba5290 100644
--- a/configure.ac
+++ b/configure.ac
@@ -28,7 +28,7 @@ m4_define([_LT_AC_TAGCONFIG], [])
 m4_ifdef([AC_LIBTOOL_TAGS], [AC_LIBTOOL_TAGS([])])
 
 AC_DISABLE_STATIC
-AC_PROG_LIBTOOL
+LT_INIT
 
 AC_ARG_ENABLE(optimization, AC_HELP_STRING([--disable-optimization],
[disable code optimization through compiler]), [
-- 
2.26.2
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org

Re: [PATCH 1/2] atmodem: Detect usage of AT+CGEREP

[Denis Kenzior]

Hi Lars,


So in theory this could be written like:
int max = -1;
iter_open_list();

while (iter_next_range(, , )) {
if (max2 > max)
max = max2;
}

iter_close_list();


I can do this and it does indeed work! :-)

This may be my personal thing, but I find this not very intuitive and
hard to read.

To make this more intuitive can we:
* move your proposed while loop to a new function
* name that function ...iter_next_range_or_list (or something like that)
* put that function into gatresult.c


I'm confused.  iter_next_range specifically handles ranges as defined by ITU 
v.250.  See section 5.7.3.1 "Range of Values".


Here's a small quote:
"If more than one value is supported, then the values may be listed 
individually, separated by comma characters (IA5 2/12), or, when a continuous 
range of values is supported, by the first value in the range, followed by a 
hyphen character (IA5 2/13), followed by the last value in the range. The 
specification of single values and ranges of values may be intermixed within a 
single information text. In all cases, the supported values shall be indicated 
in ascending order."


The only thing the user has to do is open up a list, since some modems get this 
wrong and don't enclose the entire set in '()'



* and in the new at_cgerep_test_cb just use this function ?


How would you return the set of supported settings?  I guess you could use 
something like l_uintset, but even knowing the valid theoretical range is tricky.




I can imagine this new function can be of use at other places as well.
What do you think ?


Given my confusion above, no idea?

Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org

Re: [PATCH v2] atmodem: Signal quality on quectel serial modems

[Denis Kenzior]

Hi Lars,

On 8/21/20 4:24 AM, poesc...@lemonage.de wrote:

From: Lars Poeschel 

As the default way of getting the signal quality with +CIND is also
unstable on quectel serial modems (the same as on quectel EC21). In fact
the signal quality is only updated on cell changes. Those trigger a
manual AT+CSQ in ofono and get an update this way, but the URCs do not
work.
So we implement a quectelish way here as well. The quectelish way is
very similar to the way ifx modems work. We can reuse their csq_notify
function.
---
  drivers/atmodem/network-registration.c | 24 +---
  1 file changed, 21 insertions(+), 3 deletions(-)



Applied, thanks.

Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org