Re: [PATCH 2/3] radio-settings: Add handling of dual mode technology preference

[Denis Kenzior]

Hi Sean,

On 5/31/21 6:49 AM, Sean Nyekjaer wrote:

Allow setting of "lte,gsm" mode,
for modems that doesn't support ANY mode.
---
  src/radio-settings.c | 6 ++
  1 file changed, 6 insertions(+)

diff --git a/src/radio-settings.c b/src/radio-settings.c
index 7283aa98..e2e5f33b 100644
--- a/src/radio-settings.c
+++ b/src/radio-settings.c
@@ -79,6 +79,9 @@ static const char *radio_access_mode_to_string(enum 
ofono_radio_access_mode m)
if (m == (OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_UMTS))
return "lte,umts";
  
+	if (m = (OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_GSM))


I think you meant '==' here, so I fixed that.


+   return "lte,gsm";
+
return NULL;
  }
  
@@ -104,6 +107,9 @@ static gboolean radio_access_mode_from_string(const char *str,

} else if (g_str_equal(str, "lte,umts")) {
*mode = 
OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_UMTS;
return TRUE;
+   } else if (g_str_equal(str, "lte,gsm")) {
+   *mode = OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_GSM;
+   return TRUE;
}
  
  	return FALSE;




All three patches applied, thanks.

Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org

canon.cpm/ijsetup

[ij start canon]

Hello, we have a very good printer at a reasonable rate, you can enjoy ultimate 
comfort with this printer with high-quality performance. Canon is the best 
brand among all brand printers.  Canon is one of the reputed brands of 
printers. Canon offers hi-tech and excellent printer models. Canon printers are 
designed for small, home office printers for fast, high-quality document 
printing. If you need any information or you want to buy this printer, you can 
get it from my site.
https://ijstartcannonx.com/
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org