Re: Bug/Oversight in gatchat/gatresult.c with negative numbers

2021-07-27 Thread Alex J Lennon

Hi Sebastian,

Please see below:

On 27/07/2021 15:38, Denis Kenzior wrote:

Hi Alex,

On 7/20/21 11:11 AM, Alex J Lennon wrote:

Hi all,

I'm doing a bit of work with Ofono again, extending support for a 
Quectel EG91 - handling additional cell strength information which 
seems necessary for LTE.


I'm using Quectel's AT+QCOPS which is returning some negative signal 
strengths and after some investigation I've spotted that 
gatresult::g_at_result_iter_next_number() doesn't handle negative 
numbers.


AT commands do not have a concept of negative numbers.  v.250 Section 
5.3.1:
 may be a string of one or more characters from "0" through 
"9" representing a decimal
integer value. Commands that expect a  are noted in the 
description of the command (see

clause 6).

I don't recall any other vendor using negative values in AT commands.

If you want to add a negative number parser to GAtChat, then please 
make it a separate method, so that it is very clear that a vendor 
'extension' is being worked around.


Regards,
-Denis



The team at Ofono are suggesting that Quectel (EG91) should not be 
returning negative numbers in AT command responses


These are returned to an AT+QCOPS command where signal strength is given.

Can you comment?

Thanks,

Alex
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org


Re: Bug/Oversight in gatchat/gatresult.c with negative numbers

2021-07-27 Thread Denis Kenzior

Hi Alex,

On 7/20/21 11:11 AM, Alex J Lennon wrote:

Hi all,

I'm doing a bit of work with Ofono again, extending support for a Quectel EG91 - 
handling additional cell strength information which seems necessary for LTE.


I'm using Quectel's AT+QCOPS which is returning some negative signal strengths 
and after some investigation I've spotted that 
gatresult::g_at_result_iter_next_number() doesn't handle negative numbers.


AT commands do not have a concept of negative numbers.  v.250 Section 5.3.1:
 may be a string of one or more characters from "0" through "9" 
representing a decimal
integer value. Commands that expect a  are noted in the description of 
the command (see

clause 6).

I don't recall any other vendor using negative values in AT commands.

If you want to add a negative number parser to GAtChat, then please make it a 
separate method, so that it is very clear that a vendor 'extension' is being 
worked around.


Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org


Re: [PATCH] gemalto: radio-settings: cleanup

2021-07-27 Thread Denis Kenzior

Hi Sergey,

On 7/23/21 12:00 PM, Sergey Matyukevich wrote:

Enum ofono_radio_access_mode has been replaced by unsigned int.
This change allows to move handling of all the modes into
'switch' in the function gemalto_set_rat_mode.
---
  drivers/gemaltomodem/radio-settings.c | 15 ++-
  1 file changed, 6 insertions(+), 9 deletions(-)



Applied, thanks.

Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org


dainasmith

2021-07-27 Thread daina24421
If you are facing any issues regarding Canon printer setup, Ij.start.canon .you 
will get an instant online solution. For more details visit this
https://ijstartcaanon.com/
https://ijstartcaanon.com/canon-com-ijsetup/
https://www.canonijcommsetup.com/
https://www.canonijcommsetup.com/ij-start-canon/
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org


Research for additional information related to your topic

2021-07-27 Thread ronthomsoncc
It can help if you did a bit of research on topics related to the one you are 
writing on. Social science is a subject that has been widely studied, and a lot 
of concepts overlap one another. Thus, researching for additional information 
can help you solve and answer questions with ease. If you find yourself 
struggling to research properly, you can always reach out to assignment experts 
and help them solve your social science, computer science, or even your math 
assignment help. 

https://myassignmenthelp.com/mathematics_assignment_help.html
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org