RE: [PATCH] isimodem: Improper handling of missed call
Hi Aki, I'm Nicolas Paccou, I'm in charge of validating the changes applied in new oFono release. Unfortunately, I have not the hardware to be able to regress your patch: Add support for UICC SIM driver for ISI modems I wanted to know if you have tested your patch on an ISI modem ? If yes, can you tell me if the result is ok ? If not, do you able to test it and tell me the result please ? Thanks, Nicolas -Original Message- From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of Aki Niemi Sent: Tuesday, June 14, 2011 10:30 AM To: ofono@ofono.org Subject: Re: [PATCH] isimodem: Improper handling of missed call Hi Arun, 2011/5/30 Arun Ravindran arun...@gmail.com: Can you post logs on such a successful case, if you have any around? tested once again, its working for me. I have attached the log here. But here i am using as n900 modem and not as isiusb . It seems to be working for me now using the isiusb plugin. So I pushed the patch along with the WS fixes. Sorry for the delay. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono - Intel Corporation SAS (French simplified joint stock company) Registered headquarters: Les Montalets- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
RE: [PATCH] ifxmodem: emergency number list support
Hi Jeevaka,
I'm Nicolas Paccou, I'm in charge of validating the changes applied in new
oFono release.
Unfortunately, I have not the hardware to be able to regress your patch: Add
support for handling IFX emergency number list
I wanted to know if you have tested your patch on IFX modem ?
If yes, can you tell me if the result is ok ?
If not, do you able to test it and tell me the result please ?
Thanks,
Nicolas
-Original Message-
From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of
Jeevaka Badrappan
Sent: Wednesday, June 08, 2011 5:45 PM
To: ofono@ofono.org
Subject: [PATCH] ifxmodem: emergency number list support
---
drivers/ifxmodem/voicecall.c | 95 ++
1 files changed, 95 insertions(+), 0 deletions(-)
diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c
index 87a48e6..0aa83e4 100644
--- a/drivers/ifxmodem/voicecall.c
+++ b/drivers/ifxmodem/voicecall.c
@@ -42,11 +42,13 @@
#include ifxmodem.h
static const char *none_prefix[] = { NULL };
+static const char *xlema_prefix[] = { +XLEMA:, NULL };
struct voicecall_data {
GSList *calls;
unsigned int local_release;
GAtChat *chat;
+ char **en_list;
};
struct release_id_req {
@@ -786,6 +788,93 @@ static void xcolp_notify(GAtResult *result, gpointer
user_data)
ofono_voicecall_notify(vc, call);
}
+static void xlema_notify(GAtResult *result, gpointer user_data)
+{
+ struct ofono_voicecall *vc = user_data;
+ struct voicecall_data *vd = ofono_voicecall_get_data(vc);
+ GAtResultIter iter;
+ int index, total_cnt;
+ const char *number;
+ int count = (vd-en_list == NULL) ? 0 : g_strv_length(vd-en_list);
+
+ g_at_result_iter_init(iter, result);
+
+ if (!g_at_result_iter_next(iter, +XLEMA:))
+ return;
+
+ if (!g_at_result_iter_next_number(iter, index))
+ return;
+
+ if (!g_at_result_iter_next_number(iter, total_cnt))
+ return;
+
+ if (!g_at_result_iter_next_string(iter, number))
+ return;
+
+ /* Skip the category, valid in simpresent and mcc fields */
+
+ if (vd-en_list == NULL)
+ vd-en_list = g_new0(char *, total_cnt + 1);
+
+ vd-en_list[count] = g_strdup(number);
+
+ if (index != total_cnt)
+ return;
+
+ ofono_voicecall_en_list_notify(vc, vd-en_list);
+
+ g_strfreev(vd-en_list);
+ vd-en_list = NULL;
+}
+
+static void xlema_read(gboolean ok, GAtResult *result, gpointer user_data)
+{
+ struct ofono_voicecall *vc = user_data;
+ struct voicecall_data *vd = ofono_voicecall_get_data(vc);
+ GAtResultIter iter;
+ int num = 0;
+ int index, total_cnt;
+ const char *number;
+
+ if (!ok) {
+ DBG(Emergency number list read failed);
+ return;
+ }
+
+ g_at_result_iter_init(iter, result);
+
+ while (g_at_result_iter_next(iter, +XLEMA:))
+ num += 1;
+
+ vd-en_list = g_new0(char *, num + 1);
+
+ num = 0;
+ g_at_result_iter_init(iter, result);
+
+ while (g_at_result_iter_next(iter, +XLEMA:)) {
+ if (!g_at_result_iter_next_number(iter, index))
+ continue;
+
+ if (!g_at_result_iter_next_number(iter, total_cnt))
+ continue;
+
+ if (!g_at_result_iter_next_string(iter, number))
+ continue;
+
+ /* Skip the category, valid in simpresent and mcc fields */
+ g_at_result_iter_skip_next(iter);
+ g_at_result_iter_skip_next(iter);
+ g_at_result_iter_skip_next(iter);
+
+ vd-en_list[num++] = g_strdup(number);
+ }
+
+ ofono_voicecall_en_list_notify(vc, vd-en_list);
+
+ g_strfreev(vd-en_list);
+ vd-en_list = NULL;
+}
+
static void ifx_voicecall_initialized(gboolean ok, GAtResult *result,
gpointer user_data)
{
@@ -802,6 +891,10 @@ static void ifx_voicecall_initialized(gboolean ok,
GAtResult *result,
g_at_chat_register(vd-chat, +XCALLSTAT:, xcallstat_notify,
FALSE, vc, NULL);
g_at_chat_register(vd-chat, +XCOLP:, xcolp_notify, FALSE, vc, NULL);
+ g_at_chat_register(vd-chat, +XLEMA:, xlema_notify, FALSE, vc, NULL);
+ /* Enable emergency number list notification */
+ g_at_chat_send(vd-chat, AT+XLEMA=1, xlema_prefix, xlema_read, vc,
+ NULL);
ofono_voicecall_register(vc);
}
@@ -840,6 +933,8 @@ static void ifx_voicecall_remove(struct ofono_voicecall *vc)
g_slist_foreach(vd-calls, (GFunc) g_free, NULL);
g_slist_free(vd-calls);
+ g_strfreev(vd-en_list);
+
ofono_voicecall_set_data(vc, NULL);
RE: [PATCH v3] Add basic Telit UC864-G support:
Hi Bernard,
I'm Nicolas Paccou, I'm in charge of validating the changes applied in new
oFono release.
Unfortunately, I have not the hardware to be able to regress your patch: Add
support for Telit UC864-G devices
I wanted to know if you have tested your patch on Telit UC864-G devices ?
If yes, can you tell me if the result is ok ?
If not, do you able to test it and tell me the result please ?
Thanks,
Nicolas
-Original Message-
From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of
Bernhard Guillon
Sent: Wednesday, June 08, 2011 5:42 PM
To: ofono@ofono.org
Subject: Re: [PATCH v3] Add basic Telit UC864-G support:
On Tue, 7 Jun 2011, Marcel Holtmann wrote:
+switch (status) {
+case 0:
+DBG(SIM not inserted);
+ofono_sim_inserted_notify(data-sim, FALSE);
+break;
+case 1:
+DBG(SIM inserted);
+/* We need to sleep a bit */
+g_timeout_add_seconds(1, sim_inserted_notify_with_timeout,
+modem);
+break;
+case 2:
+DBG(SIM inserted and PIN unlocked);
+break;
+case 3:
+DBG(SIM inserted and ready);
+break;
Why are you not handling any of case 2 or 3. Are they not also mean that
SIM is inserted. Or do they always are followed by case 1.
The states 2 and 3 never occurred it always reports only one event, which
is 1. I added the other states because the manual describes them as
something which should happen. Should I print an error or remove it?
+
+DBG(%p, modem);
+
+if (!ok) {
+g_at_chat_unref(data-chat);
+data-chat = NULL;
+return;
If I am not mistaken, then the set_powered(FALSE) call is missing here.
Did you test this code path?
You are right I did not test this code path. I just tested it with if (ok)
and the path is wrong.
I added it to the new patch.
Best regards,
Bernhard
--
Scanned by MailScanner.
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
-
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: Les Montalets- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
