RE: [PATCH] Add voicecall driver for Handsfree profile
Hi Padovan, Gustavo F. Padovan wrote: > Hi Zhenhua, > > on compiling your code I got this: > > cc1: warnings being treated as errors > drivers/hfpmodem/voicecall.c: In function 'chld_cb': > drivers/hfpmodem/voicecall.c:539: error: 'ag_mpty_feature' may be used > uninitialized in this function > make[1]: *** [drivers/hfpmodem/voicecall.o] Error 1 > make: *** [all] Error 2 > The ag_mpty_feature should be initialized as 0 in chld_cb. Thanks for your comments. I will update patch and send out later. >> >> Regards, >> Zhenhua >> >> >> ___ >> ofono mailing list >> ofono@ofono.org >> http://lists.ofono.org/listinfo/ofono Regards, Zhenhua ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] Add voicecall driver for Handsfree profile
Hi Zhenhua, 2009/10/23 Zhang, Zhenhua : > Hi, > > The first patch is to handle right bracket in at command parser. It's > identical with the previous patch I sent in the list. > > The second patch depends on the first one so I resend it again. It implements > voicecall driver for handsfree profile and use AT+CIEV indicator to notify > call > status change. A field 'struct ofono_call *call' that point to the current > call > is used to avoid searching call list each time. A boolean 'mpty_call' is to > indicate whether it is multi call or single call. The first version only > supports single call. The multicall patch will be based on this patch. > > Please review it. on compiling your code I got this: cc1: warnings being treated as errors drivers/hfpmodem/voicecall.c: In function 'chld_cb': drivers/hfpmodem/voicecall.c:539: error: 'ag_mpty_feature' may be used uninitialized in this function make[1]: *** [drivers/hfpmodem/voicecall.o] Error 1 make: *** [all] Error 2 > > Regards, > Zhenhua > > > ___ > ofono mailing list > ofono@ofono.org > http://lists.ofono.org/listinfo/ofono > > -- Gustavo F. Padovan http://padovan.org ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
[PATCH] Add voicecall driver for Handsfree profile
Hi, The first patch is to handle right bracket in at command parser. It's identical with the previous patch I sent in the list. The second patch depends on the first one so I resend it again. It implements voicecall driver for handsfree profile and use AT+CIEV indicator to notify call status change. A field 'struct ofono_call *call' that point to the current call is used to avoid searching call list each time. A boolean 'mpty_call' is to indicate whether it is multi call or single call. The first version only supports single call. The multicall patch will be based on this patch. Please review it. Regards, Zhenhua 0002-Add-voicecall-driver-for-Handsfree-profile.patch Description: 0002-Add-voicecall-driver-for-Handsfree-profile.patch 0001-Handle-right-bracket-in-g_at_result_iter_next_unquot.patch Description: 0001-Handle-right-bracket-in-g_at_result_iter_next_unquot.patch ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
