[PATCH] Replace Glib type with standard C type
Hi, Below patch is to replace Glib type with standard C type in hfpmodem.h, like guint, guint8, etc. Please review it. Regards, Zhenhua --- drivers/hfpmodem/hfpmodem.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hfpmodem/hfpmodem.h b/drivers/hfpmodem/hfpmodem.h index 6c6ab6f..c4e2a34 100644 --- a/drivers/hfpmodem/hfpmodem.h +++ b/drivers/hfpmodem/hfpmodem.h @@ -55,10 +55,10 @@ enum hfp_indicator { struct hfp_data { GAtChat *chat; - guint ag_features; - guint hf_features; - guint8 cind_pos[HFP_INDICATOR_LAST]; - gint cind_val[HFP_INDICATOR_LAST]; + unsigned int ag_features; + unsigned int hf_features; + unsigned char cind_pos[HFP_INDICATOR_LAST]; + unsigned int cind_val[HFP_INDICATOR_LAST]; }; extern void hfp_voicecall_init(); -- 1.6.1.3 ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] Replace Glib type with standard C type
On Fri, 23 Oct 2009 18:20:13 +0800, "Zhang, Zhenhua" wrote: > Below patch is to replace Glib type with standard C type in hfpmodem.h, > like guint, guint8, etc. I see I am not the only one repulsed by those silly and pointless gtypedefs :) -- Rémi Denis-Courmont ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] Replace Glib type with standard C type
Hi Zhenhua, > Hi, > > Below patch is to replace Glib type with standard C type in hfpmodem.h, > like guint, guint8, etc. > Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] Replace Glib type with standard C type
Hi Remi, > > Below patch is to replace Glib type with standard C type in hfpmodem.h, > > like guint, guint8, etc. > > I see I am not the only one repulsed by those silly and pointless gtypedefs > > :) For the most part I agree, however typing guint8 sure beats typing unsigned char. I wouldn't mind us using a shorter type definition. Perhaps we should standardize on uint8_t, uint16_t and friends from stdint.h? Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH] Replace Glib type with standard C type
Hi Denis, > > Below patch is to replace Glib type with standard C type in hfpmodem.h, > > like guint, guint8, etc. > > > > Patch has been applied. Thanks. please double check the author name is in the right format. Firstname Lastname and not Lastname, Firstname what Exchange always messes up. Git will take it literally :( Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono