Re: [PATCH] rilmodem: fix handling both of SUCCESS AND FAILURE

[Denis Kenzior]

Hi JongSeok,

On 12/16/21 04:48, JongSeok Won wrote:

Hi denis,

Here is patch for mulfunctioning when failure of RIL Command,
RIL_REQUEST_SET_UNSOL_CELL_INFO_LIST_RATE, is occurred.



I changed the commit description slightly and..


Best Regards,
JongSeok

---
  drivers/rilmodem/netmon.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/rilmodem/netmon.c b/drivers/rilmodem/netmon.c
index 9f3a1191..f7f81312 100644
--- a/drivers/rilmodem/netmon.c
+++ b/drivers/rilmodem/netmon.c
@@ -358,8 +358,10 @@ static void periodic_update_cb(struct ril_msg *message, 
gpointer user_data)
struct cb_data *cbd = user_data;
ofono_netmon_cb_t cb = cbd->cb;
  
-	if (message->error != RIL_E_SUCCESS)

+   if (message->error != RIL_E_SUCCESS){


Added a space after ')' and before '{' in line with our coding-style.txt 
document.


CALLBACK_WITH_FAILURE(cb, cbd->data);
+   return;
+   }
  
  	CALLBACK_WITH_SUCCESS(cb, cbd->data);

  }



Applied, thanks.

Regards,
-Denis
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org

[PATCH] rilmodem: fix handling both of SUCCESS AND FAILURE

[JongSeok Won]

Hi denis,

Here is patch for mulfunctioning when failure of RIL Command,
RIL_REQUEST_SET_UNSOL_CELL_INFO_LIST_RATE, is occurred.

Best Regards,
JongSeok

---
 drivers/rilmodem/netmon.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/rilmodem/netmon.c b/drivers/rilmodem/netmon.c
index 9f3a1191..f7f81312 100644
--- a/drivers/rilmodem/netmon.c
+++ b/drivers/rilmodem/netmon.c
@@ -358,8 +358,10 @@ static void periodic_update_cb(struct ril_msg *message, 
gpointer user_data)
struct cb_data *cbd = user_data;
ofono_netmon_cb_t cb = cbd->cb;
 
-   if (message->error != RIL_E_SUCCESS)
+   if (message->error != RIL_E_SUCCESS){
CALLBACK_WITH_FAILURE(cb, cbd->data);
+   return;
+   }
 
CALLBACK_WITH_SUCCESS(cb, cbd->data);
 }
-- 
2.17.1
___
ofono mailing list -- ofono@ofono.org
To unsubscribe send an email to ofono-le...@ofono.org