[PATCH 1/1] add netmask to hso gprs-context driver

2009-12-24 Thread Xu, Martin 
From 0a2f79bf4282562db1230e511b24214345689e18 Mon Sep 17 00:00:00 2001
From: Martin Xu martin...@intel.com
Date: Thu, 24 Dec 2009 12:29:56 -0500
Subject: [PATCH 1/1] add netmask to hso gprs-context driver

---
 drivers/hsomodem/gprs-context.c |4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/hsomodem/gprs-context.c b/drivers/hsomodem/gprs-context.c
index 0526fcc..721a017 100644
--- a/drivers/hsomodem/gprs-context.c
+++ b/drivers/hsomodem/gprs-context.c
@@ -47,6 +47,8 @@
 #define AUTH_BUF_LENGTH OFONO_GPRS_MAX_USERNAME_LENGTH + \
   OFONO_GPRS_MAX_PASSWORD_LENGTH + 128

+#define STATIC_IP_NETMASK 255.255.255.255
+
 static const char *none_prefix[] = { NULL };
 static const char *owandata_prefix[] = { _OWANDATA:, NULL };

@@ -274,7 +276,7 @@ static void owandata_cb(gboolean ok, GAtResult *result, 
gpointer user_data)
ofono_info(IP: %s, Gateway: %s, ip, gateway);
ofono_info(DNS: %s, %s, dns1, dns2);

-   CALLBACK_WITH_SUCCESS(gcd-up_cb, interface, TRUE, ip, NULL,
+   CALLBACK_WITH_SUCCESS(gcd-up_cb, interface, TRUE, ip, STATIC_IP_NETMASK,
  gateway, dns, gcd-cb_data);

gcd-hso_state = HSO_NONE;
--
1.6.1.3



___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: [PATCH 1/1] add netmask to hso gprs-context driver

2009-12-24 Thread Marcel Holtmann 
Hi Martin,

 diff --git a/drivers/hsomodem/gprs-context.c
 b/drivers/hsomodem/gprs-context.c
 
 index 0526fcc..721a017 100644
 
 --- a/drivers/hsomodem/gprs-context.c
 
 +++ b/drivers/hsomodem/gprs-context.c
 
 @@ -47,6 +47,8 @@
 
  #define AUTH_BUF_LENGTH OFONO_GPRS_MAX_USERNAME_LENGTH + \
 
OFONO_GPRS_MAX_PASSWORD_LENGTH + 128
 
  
 
 +#define STATIC_IP_NETMASK 255.255.255.255
 
 +
 
  static const char *none_prefix[] = { NULL };
 
  static const char *owandata_prefix[] = { _OWANDATA:, NULL };
 
  
 
 @@ -274,7 +276,7 @@ static void owandata_cb(gboolean ok, GAtResult
 *result, gpointer user_data)
 
 ofono_info(IP: %s, Gateway: %s, ip, gateway);
 
 ofono_info(DNS: %s, %s, dns1, dns2);
 
  
 
 -   CALLBACK_WITH_SUCCESS(gcd-up_cb, interface, TRUE, ip, NULL,
 
 +   CALLBACK_WITH_SUCCESS(gcd-up_cb, interface, TRUE, ip,
 STATIC_IP_NETMASK,
 
   gateway, dns, gcd-cb_data);
 

your emails are all messed up. You are using multi-part MIME messages
with messed up context. I don't know what's wrong here, but this way I
am not able to apply any of your patches. Just use git send-email and
use linux.intel.com as SMTP server. That should do the right thing.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono