Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'
Hi Denis, 2011/1/18 Denis Kenzior denk...@gmail.com: I'm fine with forced-auto, but we might want to add a new error type to ofono.h (maybe something like ManualRegistrationNotAllowed) and return that error when trying to use Scan or NetworkOperator.Register. I was reusing the __ofono_error_access_denied(), which I think came with the lockdown feature. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'
Hi Aki, snip + auto Network registration is performed +automatically. + forced-auto Network registration is performed +automatically while manual +selection is disabled. we need to discuss this a little bit. I am not sure using a mode of forced auto is the best choice here. Maybe an extra property like ManualAllowed would be better. Thoughts? Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'
Hi Marcel, 2011/1/18 Marcel Holtmann mar...@holtmann.org: + auto Network registration is performed + automatically. + forced-auto Network registration is performed + automatically while manual + selection is disabled. we need to discuss this a little bit. I am not sure using a mode of forced auto is the best choice here. Maybe an extra property like ManualAllowed would be better. Thoughts? The reason I ended up extending the Mode property was that once forced_auto is true, no other Mode than auto is anyway possible. So in a sense it is another type of Mode, which isn't to say a separate property wouldn't work equally well. I'm really open to either option. The way the code is written makes it very easy to just expose this as a separate property. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'
Hi Aki, + auto Network registration is performed +automatically. + forced-auto Network registration is performed +automatically while manual +selection is disabled. we need to discuss this a little bit. I am not sure using a mode of forced auto is the best choice here. Maybe an extra property like ManualAllowed would be better. Thoughts? The reason I ended up extending the Mode property was that once forced_auto is true, no other Mode than auto is anyway possible. So in a sense it is another type of Mode, which isn't to say a separate property wouldn't work equally well. I'm really open to either option. The way the code is written makes it very easy to just expose this as a separate property. the extra forced-auto mode feels kinda forced into this property. So that is my main concern here. However on the other hand the Mode property is actually read-only. If it would be a user changeable property then it would be pretty clear that we do not wanna intermix this here. With this in mind, it might be just fine here from a UI interaction flow point of view. Denis, what is your take on this? And while thinking about this, now I have another question. If this flag is set on the SIM card, are you allowed to deregister from the network? Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'
Hi Marcel, 2011/1/18 Marcel Holtmann mar...@holtmann.org: And while thinking about this, now I have another question. If this flag is set on the SIM card, are you allowed to deregister from the network? I suppose so. However, you know how I feel about Deregister() to begin with. I think with the Online property, it simply serves no purpose. Or is there an actual use case for intentionally leaving RF active while in limited service only? For sure, you're allowed to take the device offline. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'
Hi Aki, And while thinking about this, now I have another question. If this flag is set on the SIM card, are you allowed to deregister from the network? I suppose so. However, you know how I feel about Deregister() to begin with. I think with the Online property, it simply serves no purpose. Or is there an actual use case for intentionally leaving RF active while in limited service only? this is actually a good question. Do we still need the Deregister() since we have Online property now. I personally don't remember that we discussed this after we pushed the Online support and fixed up the majority of the modem drivers. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'
Hi Marcel, The reason I ended up extending the Mode property was that once forced_auto is true, no other Mode than auto is anyway possible. So in a sense it is another type of Mode, which isn't to say a separate property wouldn't work equally well. I'm really open to either option. The way the code is written makes it very easy to just expose this as a separate property. the extra forced-auto mode feels kinda forced into this property. So that is my main concern here. However on the other hand the Mode property is actually read-only. If it would be a user changeable property then it would be pretty clear that we do not wanna intermix this here. With this in mind, it might be just fine here from a UI interaction flow point of view. Denis, what is your take on this? I'm fine with forced-auto, but we might want to add a new error type to ofono.h (maybe something like ManualRegistrationNotAllowed) and return that error when trying to use Scan or NetworkOperator.Register. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'
Hi Aki, On 01/18/2011 02:35 PM, Aki Niemi wrote: Hi Marcel, 2011/1/18 Marcel Holtmann mar...@holtmann.org: And while thinking about this, now I have another question. If this flag is set on the SIM card, are you allowed to deregister from the network? I suppose so. However, you know how I feel about Deregister() to begin with. I think with the Online property, it simply serves no purpose. Or is there an actual use case for intentionally leaving RF active while in limited service only? I'm fine removing this one as well. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
