Re: [PATCH v2 1/2] configure: Bump glib dependecy to 2.32
Hi Daniel, On 04/26/2016 02:39 AM, Daniel Wagner wrote: On 04/26/2016 08:19 AM, John Ernberg wrote: -PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.28, dummy=yes, - AC_MSG_ERROR(GLib >= 2.28 is required)) +PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.32, dummy=yes, + AC_MSG_ERROR(GLib >= 2.32 is required)) Some time ago we had a discussion on the ConnMan mailing list doing the same thing. IIRC, 2.32 has a larger memory footprint compared to 2.28. That was an issue back than. Don't know if that is still relevant. Yes, that is a good point. Still, I don't think it makes sense to try and depend on a version from 2011. Newer glib versions are even worse. Our goal is to migrate oFono away from glib and onto ell, which is the proper solution to the footprint problem long-term. Regards, -Denis ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono
Re: [PATCH v2 1/2] configure: Bump glib dependecy to 2.32
On 04/26/2016 08:19 AM, John Ernberg wrote: > -PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.28, dummy=yes, > - AC_MSG_ERROR(GLib >= 2.28 is required)) > +PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.32, dummy=yes, > + AC_MSG_ERROR(GLib >= 2.32 is required)) Some time ago we had a discussion on the ConnMan mailing list doing the same thing. IIRC, 2.32 has a larger memory footprint compared to 2.28. That was an issue back than. Don't know if that is still relevant. cheers, daniel ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono
[PATCH v2 1/2] configure: Bump glib dependecy to 2.32
From: John Ernberg Needed to support g_queue_free_full --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index f6253e5..88ac6db 100644 --- a/configure.ac +++ b/configure.ac @@ -63,8 +63,8 @@ AC_CHECK_FUNC(signalfd, dummy=yes, AC_CHECK_LIB(dl, dlopen, dummy=yes, AC_MSG_ERROR(dynamic linking loader is required)) -PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.28, dummy=yes, - AC_MSG_ERROR(GLib >= 2.28 is required)) +PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.32, dummy=yes, + AC_MSG_ERROR(GLib >= 2.32 is required)) AC_SUBST(GLIB_CFLAGS) AC_SUBST(GLIB_LIBS) -- 1.9.1 ___ ofono mailing list ofono@ofono.org https://lists.ofono.org/mailman/listinfo/ofono
