RE: [PATCH 1/2] stk: provide access technology info
Hi Yang,
+
+unsigned int __ofono_netreg_get_tech(struct ofono_netreg *netreg) {
+ GSList *o;
+ unsigned int techs = 0;
+ struct network_operator_data *opd;
+
+ for (o = netreg-operator_list; o; o = o-next) {
+ opd = o-data;
+ techs |= opd-techs;
+ }
+
+ return techs;
+}
Is this function intended to get the current access technology?
As per the ETSI TS 102 223 specification 4.12 section, when the SAT
issues Provide Local Information proactive command with Access
Technology(0x06) as the command qualifier, we should provide the current
access technology . So, as per my understanding we need to use
netreg-technology.
void __ofono_netreg_set_base_station_name(struct ofono_netreg *netreg,
const char *name);
+unsigned int __ofono_netreg_get_tech(struct ofono_netreg *netreg);
Empty line needed between __ofono_netreg_set_base_station_name and
__ofono_netreg_get_tech
Regards,
Jeevaka
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
RE: [PATCH 1/2] stk: provide access technology info
Hi Jeevaka, As per the ETSI TS 102 223 specification 4.12 section, when the SAT issues Provide Local Information proactive command with Access Technology(0x06) as the command qualifier, we should provide the current access technology . So, as per my understanding we need to use netreg-technology. void __ofono_netreg_set_base_station_name(struct ofono_netreg *netreg, const char *name); +unsigned int __ofono_netreg_get_tech(struct ofono_netreg *netreg); Empty line needed between __ofono_netreg_set_base_station_name and __ofono_netreg_get_tech I think you're right. I'm not quite clear about the difference. Could you help me clarify several questions? Does it mean COPS only returns current available access technology, while CREG returns current connected access technology? And if netreg-technology is used, what should be returned once the multiple access technologies are requested? It seems oFono only supports one connected technology. In which situation we can connect to multiple access technologies simultaneously? Regards, -Yang ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
RE: [PATCH 1/2] stk: provide access technology info
Hi Yang, I think you're right. I'm not quite clear about the difference. Could you help me clarify several questions? Does it mean COPS only returns current available access technology, while CREG returns current connected access technology? COPS returns the currently available operators and its corresponding access technologies. CREG returns the currently registered operator's access techonology. In provide local information as Jeeva mentioned we have to include only the current registered access technology. So the logic used in +static gboolean get_tech(struct ofono_stk *stk, struct stk_response *rsp, + gboolean singleton) should also be changed apart from the +unsigned int __ofono_netreg_get_tech(struct ofono_netreg *netreg) change. And if netreg-technology is used, what should be returned once the multiple access technologies are requested? As said above, in this case only the current registered access technology should be returned and so irrespective of a platform supporting multiple technologies, the currently registered access technology will be only one type in a Single mode active case. It seems oFono only supports one connected technology. Yes, currently only Single mode active case is supported. In which situation we can connect to multiple access technologies simultaneously? In Dual Mode Dual standby case. BR, Rajesh ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
RE: [PATCH 1/2] stk: provide access technology info
Hi Rajesh Jeevaka I think you're right. I'm not quite clear about the difference. Could you help me clarify several questions? Does it mean COPS only returns current available access technology, while CREG returns current connected access technology? COPS returns the currently available operators and its corresponding access technologies. CREG returns the currently registered operator's access techonology. In provide local information as Jeeva mentioned we have to include only the current registered access technology. So the logic used in +static gboolean get_tech(struct ofono_stk *stk, struct stk_response *rsp, + gboolean singleton) should also be changed apart from the +unsigned int __ofono_netreg_get_tech(struct ofono_netreg *netreg) change. And if netreg-technology is used, what should be returned once the multiple access technologies are requested? As said above, in this case only the current registered access technology should be returned and so irrespective of a platform supporting multiple technologies, the currently registered access technology will be only one type in a Single mode active case. It seems oFono only supports one connected technology. Yes, currently only Single mode active case is supported. In which situation we can connect to multiple access technologies simultaneously? In Dual Mode Dual standby case. Thank you both for the comments and answers to help me clarify the problems, also make the code simpler than what I thought ;) Regards, -Yang ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
