RE: [PATCH 3/4] nettime: Documentation

2011-02-01 Thread Jeevaka.Badrappan
Hi Antti,

ofono-boun...@ofono.org wrote:
> ---
>  doc/network-time-api.txt |   36 
>  1 files changed, 36 insertions(+), 0 deletions(-)  create
> mode 100644 doc/network-time-api.txt
> 
> diff --git a/doc/network-time-api.txt
> b/doc/network-time-api.txt new file mode 100644 index
> 000..9133a73 --- /dev/null +++ b/doc/network-time-api.txt
> @@ -0,0 +1,36 @@
> +Network time hierarchy
> +==
> +
> +Interfacecom.meego.NetworkTime
> +Object path  [variable]
> +
> +Methods  void Notify(dict info)
> +
> + Notifies the service of current time and date
> + as notified by the cellular network.  The info
> + argument contains a dictionary with the
> + following possible keys:
> +
> + int64 UTC [optional]
> + Network time in seconds from epoch
> + normalized to device boot time.
> + Reveicing entity obtains current real
> + time by adding the value from monotonic
> + clock e.g.
> + clock_gettime(CLOCK_MONOTONIC,...).
> +
> + int32 Timezone [optional]
> + Current timezone offset in seconds from
> + UTC.
> +
> + int32 DST [optional]
> + Current daylight saving setting in
> + hours.

few hours back I delivered a patch for converting the DST from hours to
seconds in ofono driver code.
are we going to take that into consideration?

Aki??

Regards,
Jeevaka
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


RE: [PATCH 3/4] nettime: Documentation

2011-02-01 Thread Aki Niemi
Hi Jeevaka,

On Tue, 2011-02-01 at 16:54 +0200, ext jeevaka.badrap...@elektrobit.com
wrote:
> > +   int32 DST [optional]
> > +   Current daylight saving setting in
> > +   hours.
> 
> few hours back I delivered a patch for converting the DST from hours to
> seconds in ofono driver code.
> are we going to take that into consideration?

Ah, well. Might as well then change the dst to be hours. Would you mind
resubmitting those patches, plus one that fixes struct
ofono_network_time as well?

Cheers,
Aki

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 3/4] nettime: Documentation

2011-02-07 Thread Marcel Holtmann
Hi Antti,

>  doc/network-time-api.txt |   36 
>  1 files changed, 36 insertions(+), 0 deletions(-)
>  create mode 100644 doc/network-time-api.txt
> 
> diff --git a/doc/network-time-api.txt b/doc/network-time-api.txt
> new file mode 100644
> index 000..9133a73
> --- /dev/null
> +++ b/doc/network-time-api.txt
> @@ -0,0 +1,36 @@
> +Network time hierarchy
> +==
> +
> +Interfacecom.meego.NetworkTime
> +Object path  [variable]

the object path is not really variable. However this part of the
documentation should be really inside timed. Since timed is exposing
this interface in the first place.

And we are moving from com.nokia.timed towards com.meego.timed?

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono