Re: [PATCH v5b 2/3] stemodem: Create network interfaces statically

2010-11-14 Thread Sjur Brændeland 
Hi Marcel.

 -     struct conn_info *conn;
 +     struct conn_info *conn = NULL;
       GSList *l;

 why do you need the conn = NULL assignment here? I haven't even looked
 into your code flow, but I prefer clearly to not have these.

I have removed this and tried to remove some of the other
initialisations at declaration as well.
New patch set on the remaining gprs-context changes is on it's way :-)

Regards,
Sjur
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: [PATCH v5b 2/3] stemodem: Create network interfaces statically

2010-11-12 Thread Marcel Holtmann 
Hi Sjur,

  static void ste_eppsd_down_cb(gboolean ok, GAtResult *result,
 @@ -191,7 +189,7 @@ static void ste_eppsd_down_cb(gboolean ok, GAtResult 
 *result,
   ofono_gprs_context_cb_t cb = cbd-cb;
   struct ofono_gprs_context *gc = cbd-user;
   struct gprs_context_data *gcd = ofono_gprs_context_get_data(gc);
 - struct conn_info *conn;
 + struct conn_info *conn = NULL;
   GSList *l;

why do you need the conn = NULL assignment here? I haven't even looked
into your code flow, but I prefer clearly to not have these.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono