Re: [Ohrrpgce] SVN: teeemcee/4077 Rewrite inefficient looping with halirious comment in guessdefaultpals
On 1/3/2011 14:01, Mike Caron wrote: On 1/3/2011 12:56, subvers...@hamsterrepublic.com wrote: teeemcee 2011-01-03 09:56:57 -0800 (Mon, 03 Jan 2011) 299 Rewrite inefficient looping with halirious comment in guessdefaultpals Here is the amazing comment: FOR j = 0 TO gen(genMaxHero) 'I reversed the loops, because it's more efficient FOR i = 0 TO sets 'to do the file I/O in the outer loop loadherodata @her, j ... NEXT NEXT Whoops! Judging by the diff between 1188 and 1189 (when that change was made), I did that at the same time I rewrote everything to use the hero UDT instead of arrays. To be fair, the comment /is/ accurate. It simply didn't reflect reality. :) And, actually, just looking at the code now, I see the inner loop actually isn't needed at all (as you rewrote) --- U wip/common.bas ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
Re: [Ohrrpgce] SVN: teeemcee/4077 Rewrite inefficient looping with halirious comment in guessdefaultpals
On 1/3/2011 12:56, subvers...@hamsterrepublic.com wrote: teeemcee 2011-01-03 09:56:57 -0800 (Mon, 03 Jan 2011) 299 Rewrite inefficient looping with halirious comment in guessdefaultpals Here is the amazing comment: FOR j = 0 TO gen(genMaxHero) 'I reversed the loops, because it's more efficient FOR i = 0 TO sets 'to do the file I/O in the outer loop loadherodata @her, j ... NEXT NEXT Whoops! Judging by the diff between 1188 and 1189 (when that change was made), I did that at the same time I rewrote everything to use the hero UDT instead of arrays. To be fair, the comment /is/ accurate. It simply didn't reflect reality. :) --- U wip/common.bas ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
[Ohrrpgce] SVN: teeemcee/4079 Add AttackElementCondition and percent_cond_grabber (cond_grabber and pe
teeemcee 2011-01-03 10:20:29 -0800 (Mon, 03 Jan 2011) 198 Add AttackElementCondition and percent_cond_grabber (cond_grabber and percent_grabber hybrid) for editing them. Can be tested in the Conditions and More menu. The wording is a bit awkward though... --- U wip/custom.bas U wip/customsubs.bas U wip/customsubs.bi U wip/udts.bi ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
[Ohrrpgce] SVN: teeemcee/4078 Correct IMPORTANT-nightly.txt: bug 871 actually corrupted all of the dat
teeemcee 2011-01-03 10:16:44 -0800 (Mon, 03 Jan 2011) 178 Correct IMPORTANT-nightly.txt: bug 871 actually corrupted all of the data for heroes 1 and up. (It also overwrote some of the not-yet-enabled elemental damage values for hero 0) --- U wip/IMPORTANT-nightly.txt ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
Re: [Ohrrpgce] SVN: teeemcee/4077 Rewrite inefficient looping with halirious comment in guessdefaultpals
On Mon, Jan 03, 2011 at 10:05:41AM -0800, James Paige wrote: > On Mon, Jan 03, 2011 at 09:56:57AM -0800, subvers...@hamsterrepublic.com > wrote: > > teeemcee > > 2011-01-03 09:56:57 -0800 (Mon, 03 Jan 2011) > > 299 > > Rewrite inefficient looping with halirious comment in guessdefaultpals > > Here is the amazing comment: > > > > FOR j = 0 TO gen(genMaxHero) 'I reversed the loops, because it's more > > efficient > >FOR i = 0 TO sets 'to do the file I/O in the outer loop > > loadherodata @her, j > > ... > >NEXT > > NEXT > > --- > > > In my defense it wasn't me ;) > > (and in Mike's defense, it was like four years ago) > although that is TOTALLY the kind of code I am likely to write ;P --- James ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
Re: [Ohrrpgce] SVN: teeemcee/4077 Rewrite inefficient looping with halirious comment in guessdefaultpals
On Mon, Jan 03, 2011 at 09:56:57AM -0800, subvers...@hamsterrepublic.com wrote: > teeemcee > 2011-01-03 09:56:57 -0800 (Mon, 03 Jan 2011) > 299 > Rewrite inefficient looping with halirious comment in guessdefaultpals > Here is the amazing comment: > > FOR j = 0 TO gen(genMaxHero) 'I reversed the loops, because it's more > efficient >FOR i = 0 TO sets 'to do the file I/O in the outer loop > loadherodata @her, j > ... >NEXT > NEXT > --- In my defense it wasn't me ;) (and in Mike's defense, it was like four years ago) --- James ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
[Ohrrpgce] SVN: teeemcee/4077 Rewrite inefficient looping with halirious comment in guessdefaultpals
teeemcee 2011-01-03 09:56:57 -0800 (Mon, 03 Jan 2011) 299 Rewrite inefficient looping with halirious comment in guessdefaultpals Here is the amazing comment: FOR j = 0 TO gen(genMaxHero) 'I reversed the loops, because it's more efficient FOR i = 0 TO sets 'to do the file I/O in the outer loop loadherodata @her, j ... NEXT NEXT --- U wip/common.bas ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
Re: [Ohrrpgce] SVN: teeemcee/4076 Fix hero data corruption (bug 871) due to a spot I failed to change to g
On Mon, Jan 03, 2011 at 09:29:46AM -0800, subvers...@hamsterrepublic.com wrote: > teeemcee > 2011-01-03 09:29:46 -0800 (Mon, 03 Jan 2011) > 196 > Fix hero data corruption (bug 871) due to a spot I failed to change to > getbinsize. > Added clamp_value and clamp sprite related values in the hero editor, which > were causing it to crash on bad data. > --- I forced an early nightly build for this. --- James ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
[Ohrrpgce] [Bug 871] Hero Data totally corrupt on import from earlier nightly
http://rpg.hamsterrepublic.com/bugzilla/show_bug.cgi?id=871 Ralph Versteegen changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: http://rpg.hamsterrepublic.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
[Ohrrpgce] [Bug 871] Hero Data totally corrupt on import from earlier nightly
http://rpg.hamsterrepublic.com/bugzilla/show_bug.cgi?id=871 Ralph Versteegen changed: What|Removed |Added CC||teeem...@gmail.com --- Comment #1 from Ralph Versteegen 2011-01-03 09:35:19 PST --- Oh dear oh dear! That's what I get for only testing on hero 0! And I intended to grep the source for '636', but forgot. Fixed the cause of the corruption (irreversible, of course), and the cause of the hero editor crashing on the corrupted data. However there may be some other problems/crashes when editing corrupted data which I haven't noticed. -- Configure bugmail: http://rpg.hamsterrepublic.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
[Ohrrpgce] SVN: teeemcee/4076 Fix hero data corruption (bug 871) due to a spot I failed to change to g
teeemcee 2011-01-03 09:29:46 -0800 (Mon, 03 Jan 2011) 196 Fix hero data corruption (bug 871) due to a spot I failed to change to getbinsize. Added clamp_value and clamp sprite related values in the hero editor, which were causing it to crash on bad data. --- U wip/IMPORTANT-nightly.txt U wip/common.bas U wip/common.bi U wip/loading.bas U wip/subs.bas ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
[Ohrrpgce] [Bug 872] New: GAME CTDs when the end of a MIDI happens at the same time as a hero's command being input.
http://rpg.hamsterrepublic.com/bugzilla/show_bug.cgi?id=872 Summary: GAME CTDs when the end of a MIDI happens at the same time as a hero's command being input. Product: OHRRPGCE Version: Nigtly WIP (Zenzizenzic) Platform: PC OS/Version: Windows Status: NEW Severity: normal Priority: P3 Component: Music AssignedTo: ohrrpgce@lists.motherhamster.org ReportedBy: dancing_g...@hotmail.co.uk This happens nearly without fail on most games, I've tested it on several computers and can replicate it on all of them. I'm also using the default Music back-ends and have been encountering this issue since Xocolatl. If the player inputs a command for a hero at the same time as a MIDI ends then GAME becomes unresponsive then crashes. If an enemy attacks or the attack is the result of a chain and not a menu command then it behaves normally, in addition there is a sound effect stutter in conjunction with the end of a loop regardless of any player input. -- Configure bugmail: http://rpg.hamsterrepublic.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
[Ohrrpgce] [Bug 871] Hero Data totally corrupt on import from earlier nightly
http://rpg.hamsterrepublic.com/bugzilla/show_bug.cgi?id=871 Jack Iball changed: What|Removed |Added Summary|All hero data par Hero 0 is |Hero Data totally corrupt |corrupt after importing |on import from earlier |from a previous nightly CTD |nightly |when hero 2 is selected | -- Configure bugmail: http://rpg.hamsterrepublic.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
[Ohrrpgce] [Bug 871] New: All hero data par Hero 0 is corrupt after importing from a previous nightly CTD when hero 2 is selected
http://rpg.hamsterrepublic.com/bugzilla/show_bug.cgi?id=871 Summary: All hero data par Hero 0 is corrupt after importing from a previous nightly CTD when hero 2 is selected Product: OHRRPGCE Version: Nigtly WIP (Zenzizenzic) Platform: PC OS/Version: Windows Status: NEW Severity: major Priority: P3 Component: Heroes AssignedTo: ohrrpgce@lists.motherhamster.org ReportedBy: dancing_g...@hotmail.co.uk Created attachment 192 --> http://rpg.hamsterrepublic.com/bugzilla/attachment.cgi?id=192 Test case file for the bug. Found in the latest Nightly (3/01/11) after importing an RPG file from an earlier Nightly (1/12/10). When in the Hero Editor all heroes apart from Hero 0 are totally corrupt and garbage data is generated in all fields. Selecting Hero 2 in CUSTOM causes an instant CTD. If it's of any help I've attached the RPG file as a test case and I've been using FF1 Style Spells. Trash data in the Spell lists includes spells being learned at levels over 100 (for example Lv.199) and trash spell numbers with 5 digits. -- Configure bugmail: http://rpg.hamsterrepublic.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
[Ohrrpgce] SVN: teeemcee/4075 ESC key couldn't be used to exit empty menus.
teeemcee 2011-01-03 03:29:54 -0800 (Mon, 03 Jan 2011) 45 ESC key couldn't be used to exit empty menus. --- U wip/game.bas U wip/whatsnew.txt ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
