Re: [oi-dev] 1660 first release of The dcmtk package, Ask for review
On Mon, Nov 14, 2011 at 07:46:58PM -0500, Josef 'Jeff' Sipek wrote: On Mon, Nov 14, 2011 at 06:55:39PM +0100, Paolo Marcheschi wrote: Yes it installs and works fine, I tried a few command with man pages and it works. Cool. Looks good to me. Alright. All committed now with a couple of tweaks - use GCC only for the component instead of all of them, and get rid of two silly lint warnings. (Yes, in my infinite wisdom, I forgot to add the Reviewed by and Approved by lines, sorry guys. :( ) Jeff. -- Research, n.: Consider Columbus: He didn't know where he was going. When he got there he didn't know where he was. When he got back he didn't know where he had been. And he did it all on someone else's money. ___ oi-dev mailing list oi-dev@openindiana.org http://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] 1660 first release of The dcmtk package, Ask for review
Thank you I fixed the configuration file and the source issue. I think it is ready Paolo Marcheschi On 11/ 3/11 04:21 PM, Guido Berhoerster wrote: Hello, * Paolo Marcheschipaolo.marches...@ftgm.it [2011-10-31 19:49]: This another contribution, I'm asking for a review, dcmtk: DCMTK is a collection of libraries and applications implementing large parts the DICOM standard. It includes software for examining, constructing and converting DICOM image files, handling offline media, sending and receiving images over a network connection, as well as demonstrative image storage and worklist servers. DCMTK is is written in a mixture of ANSI C and C++. It comes in complete source code and is made available as open source software. http://dicom.offis.de/dcmtk https://bitbucket.org/paolo_marcheschi/oi-build The oi-build tools fail to download the package from ftp, I added the file. the configuration files are installed in the wrong place (/usr/etc/dcmtk/), that should be /etc/dcmtk. For autoconf/autotools projects you can usually pass --sysconfdir=/etc to configure to specify that location, I'm not sure whether userland has any predefined macros to take care of that. Please don't inline source files, if it cannot be downloaded from the upstream servers I'm sure we can arrange to mirror it from dlc.openindiana.org. ___ oi-dev mailing list oi-dev@openindiana.org http://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] 1660 first release of The dcmtk package, Ask for review
Hi I removed the lines and add the configure options. But it seems to put the binaries in /usr/local/bin btw I commited in this way. Paolo On 11/14/11 12:53 PM, Guido Berhoerster wrote: Hello, * Paolo Marcheschipaolo.marches...@ftgm.it [2011-11-14 12:01]: Thank you I fixed the configuration file and the source issue. yes, that's better. Please remove CONFIGURE_OPTIONS += --bindir=/usr/bin CONFIGURE_OPTIONS += --mandir=/usr/man these are set by userland automatically and /usr/man is not correct anyway (it's only a compatibility symlink to /usr/share/man). I would also suggest changing CONFIGURE_OPTIONS += --docdir=/usr/share/dcmtk/doc to CONFIGURE_OPTIONS += --docdir=$(CONFIGURE_PREFIX)/share/doc/dcmtk ___ oi-dev mailing list oi-dev@openindiana.org http://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] 1660 first release of The dcmtk package, Ask for review
* Paolo Marcheschi paolo.marches...@ftgm.it [2011-11-14 15:29]: Hi I removed the lines and add the configure options. But it seems to put the binaries in /usr/local/bin Change the CONFIGURE_OPTIONS = --sysconfdir=/etc to CONFIGURE_OPTIONS += --sysconfdir=/etc The CONFIGURE_OPTIONS macro is already defined with default values for mandir/bindir/libdir etc. in configure.mk so you should not override it but only add to it. -- Guido Berhoerster ___ oi-dev mailing list oi-dev@openindiana.org http://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] 1660 first release of The dcmtk package, Ask for review
Hi Thank you Very Much. I did it. Paolo On 11/14/11 04:04 PM, Guido Berhoerster wrote: * Paolo Marcheschipaolo.marches...@ftgm.it [2011-11-14 15:29]: Hi I removed the lines and add the configure options. But it seems to put the binaries in /usr/local/bin Change the CONFIGURE_OPTIONS = --sysconfdir=/etc to CONFIGURE_OPTIONS += --sysconfdir=/etc The CONFIGURE_OPTIONS macro is already defined with default values for mandir/bindir/libdir etc. in configure.mk so you should not override it but only add to it. ___ oi-dev mailing list oi-dev@openindiana.org http://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] 1660 first release of The dcmtk package, Ask for review
* Paolo Marcheschi paolo.marches...@ftgm.it [2011-11-14 16:33]: Hi Thank you Very Much. I did it. Looks good now, have you tested the resulting package? -- Guido Berhoerster ___ oi-dev mailing list oi-dev@openindiana.org http://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] 1660 first release of The dcmtk package, Ask for review
Yes it installs and works fine, I tried a few command with man pages and it works. Paolo On 11/14/11 05:02 PM, Guido Berhoerster wrote: * Paolo Marcheschipaolo.marches...@ftgm.it [2011-11-14 16:33]: Hi Thank you Very Much. I did it. Looks good now, have you tested the resulting package? ___ oi-dev mailing list oi-dev@openindiana.org http://openindiana.org/mailman/listinfo/oi-dev
Re: [oi-dev] 1660 first release of The dcmtk package, Ask for review
On Mon, Nov 14, 2011 at 06:55:39PM +0100, Paolo Marcheschi wrote: Yes it installs and works fine, I tried a few command with man pages and it works. Cool. Looks good to me. Jeff. Paolo On 11/14/11 05:02 PM, Guido Berhoerster wrote: * Paolo Marcheschipaolo.marches...@ftgm.it [2011-11-14 16:33]: Hi Thank you Very Much. I did it. Looks good now, have you tested the resulting package? ___ oi-dev mailing list oi-dev@openindiana.org http://openindiana.org/mailman/listinfo/oi-dev -- NT is to UNIX what a doughnut is to a particle accelerator. ___ oi-dev mailing list oi-dev@openindiana.org http://openindiana.org/mailman/listinfo/oi-dev
