[oi-dev] 2324 bring unrar changes from userland-gate

2012-10-01 Thread Adam Števko
Hi,

URL: https://www.illumos.org/issues/2324
Changeset: 
https://bitbucket.org/xenol/oi-build-2324/changeset/e4324e058d735b541e1603ba97840b49cc407d9c

To sum up, oracle removed one patch, which was accepted by upstream. Package 
can be compiled by studio and works.

Any feedback welcome.

Cheers,
Adam
___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev


Re: [oi-dev] 2324 bring unrar changes from userland-gate

2012-10-01 Thread Alasdair Lumsden

Hi Adam,

On 10/ 1/12 07:42 PM, Adam Števko wrote:

URL: https://www.illumos.org/issues/2324
Changeset: 
https://bitbucket.org/xenol/oi-build-2324/changeset/e4324e058d735b541e1603ba97840b49cc407d9c

To sum up, oracle removed one patch, which was accepted by upstream. Package 
can be compiled by studio and works.

Any feedback welcome.


Looks good! Only one comment and it looks like the Oracle copyright 
lines were removed rather than just added to. Since they were the 
original author we need to keep those - would you mind adding them back?


Otherwise, +1!



___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev


Re: [oi-dev] 2324 bring unrar changes from userland-gate

2012-10-01 Thread Adam Števko
Hi Alasdair.

On Oct 1, 2012, at 9:18 PM, Alasdair Lumsden alasdai...@gmail.com wrote:

 Hi Adam,
 
 On 10/ 1/12 07:42 PM, Adam Števko wrote:
 URL: https://www.illumos.org/issues/2324
 Changeset: 
 https://bitbucket.org/xenol/oi-build-2324/changeset/e4324e058d735b541e1603ba97840b49cc407d9c
 
 To sum up, oracle removed one patch, which was accepted by upstream. Package 
 can be compiled by studio and works.
 
 Any feedback welcome.
 
 Looks good! Only one comment and it looks like the Oracle copyright lines 
 were removed rather than just added to. Since they were the original author 
 we need to keep those - would you mind adding them back?
 
 Otherwise, +1!

I restored the original CDDL license for Makefile. As p5m file was fully 
recreated, I left illumos CDDL version.

Changeset: 
https://bitbucket.org/xenol/oi-build-2324/changeset/7bc51366b2e8945f43f6bfc72a38d7614d613d11

Adam


___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev