Re: [oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

2011-11-23 Thread Josef 'Jeff' Sipek 
On Sun, Nov 20, 2011 at 11:45:28AM +, Colin Ellis wrote:
 I'm tidying up the files as requested.  I've run a make test, which passes.
 I haven't found any DTrace patches for the 1.9 series of ruby.  The SFE
 build of 1.9.0 doesn't have any applied.
 I'd suggest having two ruby packages in the repo: ruby19 with latest code
 and ruby18 with dtrace.

Well, it feels like a regression to have a newer version without DTrace
support.  Or did I miss the memo and DTrace got mainlined?

Agreed on the nitpicks that Alasdair pointed out.

Jeff.

-- 
UNIX is user-friendly ... it's just selective about who its friends are

___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev

Re: [oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

2011-11-20 Thread Colin Ellis 
I'm tidying up the files as requested.  I've run a make test, which passes.
I haven't found any DTrace patches for the 1.9 series of ruby.  The SFE
build of 1.9.0 doesn't have any applied.
I'd suggest having two ruby packages in the repo: ruby19 with latest code
and ruby18 with dtrace.

Any thoughts?

On Sat, Nov 19, 2011 at 10:35 PM, Alasdair Lumsden alasdai...@gmail.comwrote:

 Hi Colin,

 Great stuff! Only minor nitpicks:

 On the Makefile, you've got multiple configure options per
 CONFIGURE_OPTION, and the indentation of the macros is a bit iffy. But if
 you like I can tidy these up when we commit, saving you the bother.

 Did you have any luck finding out about the DTrace patches? Also did you
 give make test a go?

 Cheers,

 Alasdair


 On 11/19/11 09:54 PM, Colin Ellis wrote:

 https://bitbucket.org/cellis_**oidev/oi-build/changeset/**4c13f4869651https://bitbucket.org/cellis_oidev/oi-build/changeset/4c13f4869651

 On Tue, Nov 15, 2011 at 9:32 AM, Guido Berhoerster g...@openindiana.org
 mailto:g...@openindiana.org wrote:

* Colin Ellis panamaya...@gmail.com mailto:panamaya...@gmail.com**

[2011-11-12 19:40]:
  Fixes are here:
 
  https://bitbucket.org/cellis_**oidev/oi-build/changeset/**
 5bb1edf68a1dhttps://bitbucket.org/cellis_oidev/oi-build/changeset/5bb1edf68a1d

Have you looked through the ruby 1.8 patches and checked which
are still applicable? At least the DTrace changes should probably
be ported over.
Have you checked the built ruby interpeter? Running make test
on the source tree after building should be an easy way to catch
any issues.
--
Guido Berhoerster

__**_
oi-dev mailing list
oi-dev@openindiana.org mailto:oi-dev@openindiana.org**

 http://openindiana.org/**mailman/listinfo/oi-devhttp://openindiana.org/mailman/listinfo/oi-dev





 __**_
 oi-dev mailing list
 oi-dev@openindiana.org
 http://openindiana.org/**mailman/listinfo/oi-devhttp://openindiana.org/mailman/listinfo/oi-dev



 __**_
 oi-dev mailing list
 oi-dev@openindiana.org
 http://openindiana.org/**mailman/listinfo/oi-devhttp://openindiana.org/mailman/listinfo/oi-dev

___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev

Re: [oi-dev] Feature #1744 add ruby 1.9.3 to oi-build

2011-11-19 Thread Colin Ellis 
https://bitbucket.org/cellis_oidev/oi-build/changeset/4c13f4869651

On Tue, Nov 15, 2011 at 9:32 AM, Guido Berhoerster g...@openindiana.orgwrote:

 * Colin Ellis panamaya...@gmail.com [2011-11-12 19:40]:
  Fixes are here:
 
  https://bitbucket.org/cellis_oidev/oi-build/changeset/5bb1edf68a1d

 Have you looked through the ruby 1.8 patches and checked which
 are still applicable? At least the DTrace changes should probably
 be ported over.
 Have you checked the built ruby interpeter? Running make test
 on the source tree after building should be an easy way to catch
 any issues.
 --
 Guido Berhoerster

 ___
 oi-dev mailing list
 oi-dev@openindiana.org
 http://openindiana.org/mailman/listinfo/oi-dev

___
oi-dev mailing list
oi-dev@openindiana.org
http://openindiana.org/mailman/listinfo/oi-dev