Re: [oi-dev] Fwd: [bugs] [illumos gate - Feature #15916] bhyve upstream sync 2023 September

2023-12-23 Thread Stephan Althaus

On 12/23/23 13:19, Till Wegmueller wrote:

Hi, Stephan

The bHyve components are directly copied into illumos-gate and the 
repository you mentioned is just the UEFI Firmware/Bootloader where we 
seem to be up to date. All bHyve related parts get compiled with 
illumos-gate


-Till

On 23.12.2023 09:59, Stephan Althaus wrote:

Hello!


The OI bhyve firmware package seems to be outdated.

The related github has no more recent version, so it seems github has 
to be updated beforehand... (?)



$ pkg info system/bhyve/firmware
  Name: system/bhyve/firmware
   Summary: UEFI-EDK2(+CSM) firmware for bhyve
  Category: System/Core
 State: Installed
 Publisher: openindiana.org
   Version: 20210201
    Branch: 2022.0.0.2
    Packaging Date: March 25, 2022 at 06:39:30 AM
Last Install Time: December 23, 2023 at 08:13:52 AM
  Size: 7.88 MB
  FMRI: 
pkg://openindiana.org/system/bhyve/firmware@20210201-2022.0.0.2:20220325T063930Z

   Project URL: https://github.com/illumos/uefi-edk2
    Source URL: 
https://github.com/illumos/uefi-edk2/releases/download/il-udk2014.sp1-3/uefi-edk2-il-udk2014.sp1-3.tar.xz



GitHub:

https://github.com/illumos/uefi-edk2/releases


Regards,

Stephan



 Forwarded Message 
Subject: [bugs] [illumos gate - Feature #15916] bhyve upstream 
sync 2023 September

Date: Fri, 22 Dec 2023 22:10:32 +
From: illumos project via illumos-bugs 
Reply-To: illumos-bugs 



Issue #15916 has been updated by Andy Fiddaman.


The changes in the associated Gerrit review have been integrated in 
OmniOS bloody for a few weeks, and tested with a wide range of 
different VMs -- including illumos, FreeBSD, Windows and Linux -- in 
a range of configurations including pass-through of USB hubs, NICs 
and GPUs (many thanks due to Jorge Schrauen and Marco van Wieringen 
for helping out here).


Although this change includes new code to load ACPI tables into the 
guest via a fwcfg interface, this is not enabled by default. Enabling 
this appears to work but dumping ACPI tables from a guest running the 
old and new bits produces the same output in both cases.




Feature #15916: bhyve upstream sync 2023 September
https://www.illumos.org/issues/15916#change-43755

* Author: Andy Fiddaman
* Status: In Progress
* Priority: Low
* Assignee: Andy Fiddaman
* Category: bhyve
* Difficulty: Medium
* Gerrit CR: 3044

This is a set of merges from bhyve in FreeBSD, summarised in the 
following table.


There is very little change to the kernel components, we already had 
several of the fixes there.

The biggest set of changes are around:
- ACPI table generation and loading them into the guest via the fwctl 
interfaces;

- A basic emulated E820 device;
- TPM pass-through.

Each line is prefixed by a set of flags showing which action was 
taken. The key for these is:



S - skipped
U - updated to match upstream
~ - partially taken
* - merged
F - only freebsd-specific code changed
A - already had



* 1 bhyve: Avoid triggering false -Wfree-nonheap-object warnings.
* 2 bhyve: Remove vmctx argument from PCI device model methods.
*F 3 bhyve: Fix a global buffer overread in the PCI hda device model.
*F 4 bhyve: Fix a buffer overread in the PCI hda device model.
S 5 vmm: take exclusive mem_segs_lock when (un)assigning ppt dev
S 6 vmm: take exclusive mem_segs_lock in vm_cleanup()
S 7 vmm: fix use after free in ppt_detach()
S 8 vm: centralize VM_BATCHQUEUE_SIZE definition
* 9 53545967642d850eee4f2dd9fa27cae52ae981b9 vtd: Increase 
DRHD_MAX_UNITS

S 10 vmm: avoid spurious rendezvous
S 11 vmm: purge EOL release compatibility
S 12 vmm: Collapse identical case statements in 
vlapic_icrlo_write_handler()

S 13 vmm: Remove an unneeded initialization of "retu"
S 14 vmm: Fix AP startup compatibility for old bhyve executables
* 15 bhyve: add helper struct for acpi device handling
* 16 bhyve: add helper func to add acpi resources
* 17 bhyve: add helper func to write a dsdt entry
* 18 bhyve: maintain a list of acpi devices
* 19 bhyve: add basic qemu fwcfg implementation
* 20 bhyve: add emulation for the qemu fwcfg selector port
* 21 bhyve: add emulation for qemu's fwcfg data port
* 22 bhyve: add helper to add fwcfg items
* 23 bhyve: add common fwcfg items
S 24 vmm: fix restore of TSC offset
S 25 bhyve: fix restore of kernel structs
S 26 bhyve: fix resume for vms with guest_ncpus > 1
* 27 bhyve: remove redundant variable
* 28 bhyve: Remove useless return at the end of void function
* 29 bhyvectl: Address compiler warnings and bump WARNS
S 30 bhyvectl: do not return garbage from send_message
S 31 bhyvectl: correct socket_fd closing in send_message
S 32 bhyvectl: don't leak nvlist in send_message
S 33 libvmm: add missing ioctl's to vm_ioctl_cmds
S 34 bhyve: don't flush readonly device at blockif_pause
S 35 bhyve: add cap limits for ipc socket
S 36 

Re: [oi-dev] Fwd: [bugs] [illumos gate - Feature #15916] bhyve upstream sync 2023 September

2023-12-23 Thread Till Wegmueller

Hi, Stephan

The bHyve components are directly copied into illumos-gate and the 
repository you mentioned is just the UEFI Firmware/Bootloader where we 
seem to be up to date. All bHyve related parts get compiled with 
illumos-gate


-Till

On 23.12.2023 09:59, Stephan Althaus wrote:

Hello!


The OI bhyve firmware package seems to be outdated.

The related github has no more recent version, so it seems github has to 
be updated beforehand... (?)



$ pkg info system/bhyve/firmware
  Name: system/bhyve/firmware
   Summary: UEFI-EDK2(+CSM) firmware for bhyve
  Category: System/Core
     State: Installed
     Publisher: openindiana.org
   Version: 20210201
    Branch: 2022.0.0.2
    Packaging Date: March 25, 2022 at 06:39:30 AM
Last Install Time: December 23, 2023 at 08:13:52 AM
  Size: 7.88 MB
  FMRI: 
pkg://openindiana.org/system/bhyve/firmware@20210201-2022.0.0.2:20220325T063930Z

   Project URL: https://github.com/illumos/uefi-edk2
    Source URL: 
https://github.com/illumos/uefi-edk2/releases/download/il-udk2014.sp1-3/uefi-edk2-il-udk2014.sp1-3.tar.xz



GitHub:

https://github.com/illumos/uefi-edk2/releases


Regards,

Stephan



 Forwarded Message 
Subject: 	[bugs] [illumos gate - Feature #15916] bhyve upstream sync 
2023 September

Date:   Fri, 22 Dec 2023 22:10:32 +
From:   illumos project via illumos-bugs 
Reply-To:   illumos-bugs 



Issue #15916 has been updated by Andy Fiddaman.


The changes in the associated Gerrit review have been integrated in 
OmniOS bloody for a few weeks, and tested with a wide range of different 
VMs -- including illumos, FreeBSD, Windows and Linux -- in a range of 
configurations including pass-through of USB hubs, NICs and GPUs (many 
thanks due to Jorge Schrauen and Marco van Wieringen for helping out here).


Although this change includes new code to load ACPI tables into the 
guest via a fwcfg interface, this is not enabled by default. Enabling 
this appears to work but dumping ACPI tables from a guest running the 
old and new bits produces the same output in both cases.




Feature #15916: bhyve upstream sync 2023 September
https://www.illumos.org/issues/15916#change-43755

* Author: Andy Fiddaman
* Status: In Progress
* Priority: Low
* Assignee: Andy Fiddaman
* Category: bhyve
* Difficulty: Medium
* Gerrit CR: 3044

This is a set of merges from bhyve in FreeBSD, summarised in the 
following table.


There is very little change to the kernel components, we already had 
several of the fixes there.

The biggest set of changes are around:
- ACPI table generation and loading them into the guest via the fwctl 
interfaces;

- A basic emulated E820 device;
- TPM pass-through.

Each line is prefixed by a set of flags showing which action was taken. 
The key for these is:



S - skipped
U - updated to match upstream
~ - partially taken
* - merged
F - only freebsd-specific code changed
A - already had



* 1 bhyve: Avoid triggering false -Wfree-nonheap-object warnings.
* 2 bhyve: Remove vmctx argument from PCI device model methods.
*F 3 bhyve: Fix a global buffer overread in the PCI hda device model.
*F 4 bhyve: Fix a buffer overread in the PCI hda device model.
S 5 vmm: take exclusive mem_segs_lock when (un)assigning ppt dev
S 6 vmm: take exclusive mem_segs_lock in vm_cleanup()
S 7 vmm: fix use after free in ppt_detach()
S 8 vm: centralize VM_BATCHQUEUE_SIZE definition
* 9 53545967642d850eee4f2dd9fa27cae52ae981b9 vtd: Increase DRHD_MAX_UNITS
S 10 vmm: avoid spurious rendezvous
S 11 vmm: purge EOL release compatibility
S 12 vmm: Collapse identical case statements in vlapic_icrlo_write_handler()
S 13 vmm: Remove an unneeded initialization of "retu"
S 14 vmm: Fix AP startup compatibility for old bhyve executables
* 15 bhyve: add helper struct for acpi device handling
* 16 bhyve: add helper func to add acpi resources
* 17 bhyve: add helper func to write a dsdt entry
* 18 bhyve: maintain a list of acpi devices
* 19 bhyve: add basic qemu fwcfg implementation
* 20 bhyve: add emulation for the qemu fwcfg selector port
* 21 bhyve: add emulation for qemu's fwcfg data port
* 22 bhyve: add helper to add fwcfg items
* 23 bhyve: add common fwcfg items
S 24 vmm: fix restore of TSC offset
S 25 bhyve: fix restore of kernel structs
S 26 bhyve: fix resume for vms with guest_ncpus > 1
* 27 bhyve: remove redundant variable
* 28 bhyve: Remove useless return at the end of void function
* 29 bhyvectl: Address compiler warnings and bump WARNS
S 30 bhyvectl: do not return garbage from send_message
S 31 bhyvectl: correct socket_fd closing in send_message
S 32 bhyvectl: don't leak nvlist in send_message
S 33 libvmm: add missing ioctl's to vm_ioctl_cmds
S 34 bhyve: don't flush readonly device at blockif_pause
S 35 bhyve: add cap limits for ipc socket
S 36 bhyve: exit with EX_OSERR if init checkpoint or restore 

[oi-dev] Fwd: [bugs] [illumos gate - Feature #15916] bhyve upstream sync 2023 September

2023-12-23 Thread Stephan Althaus

Hello!


The OI bhyve firmware package seems to be outdated.

The related github has no more recent version, so it seems github has to 
be updated beforehand... (?)



$ pkg info system/bhyve/firmware
 Name: system/bhyve/firmware
  Summary: UEFI-EDK2(+CSM) firmware for bhyve
 Category: System/Core
    State: Installed
    Publisher: openindiana.org
  Version: 20210201
   Branch: 2022.0.0.2
   Packaging Date: March 25, 2022 at 06:39:30 AM
Last Install Time: December 23, 2023 at 08:13:52 AM
 Size: 7.88 MB
 FMRI: 
pkg://openindiana.org/system/bhyve/firmware@20210201-2022.0.0.2:20220325T063930Z

  Project URL: https://github.com/illumos/uefi-edk2
   Source URL: 
https://github.com/illumos/uefi-edk2/releases/download/il-udk2014.sp1-3/uefi-edk2-il-udk2014.sp1-3.tar.xz



GitHub:

https://github.com/illumos/uefi-edk2/releases


Regards,

Stephan



 Forwarded Message 
Subject: 	[bugs] [illumos gate - Feature #15916] bhyve upstream sync 
2023 September

Date:   Fri, 22 Dec 2023 22:10:32 +
From:   illumos project via illumos-bugs 
Reply-To:   illumos-bugs 



Issue #15916 has been updated by Andy Fiddaman.


The changes in the associated Gerrit review have been integrated in 
OmniOS bloody for a few weeks, and tested with a wide range of different 
VMs -- including illumos, FreeBSD, Windows and Linux -- in a range of 
configurations including pass-through of USB hubs, NICs and GPUs (many 
thanks due to Jorge Schrauen and Marco van Wieringen for helping out here).


Although this change includes new code to load ACPI tables into the 
guest via a fwcfg interface, this is not enabled by default. Enabling 
this appears to work but dumping ACPI tables from a guest running the 
old and new bits produces the same output in both cases.




Feature #15916: bhyve upstream sync 2023 September
https://www.illumos.org/issues/15916#change-43755

* Author: Andy Fiddaman
* Status: In Progress
* Priority: Low
* Assignee: Andy Fiddaman
* Category: bhyve
* Difficulty: Medium
* Gerrit CR: 3044

This is a set of merges from bhyve in FreeBSD, summarised in the 
following table.


There is very little change to the kernel components, we already had 
several of the fixes there.

The biggest set of changes are around:
- ACPI table generation and loading them into the guest via the fwctl 
interfaces;

- A basic emulated E820 device;
- TPM pass-through.

Each line is prefixed by a set of flags showing which action was taken. 
The key for these is:



S - skipped
U - updated to match upstream
~ - partially taken
* - merged
F - only freebsd-specific code changed
A - already had



* 1 bhyve: Avoid triggering false -Wfree-nonheap-object warnings.
* 2 bhyve: Remove vmctx argument from PCI device model methods.
*F 3 bhyve: Fix a global buffer overread in the PCI hda device model.
*F 4 bhyve: Fix a buffer overread in the PCI hda device model.
S 5 vmm: take exclusive mem_segs_lock when (un)assigning ppt dev
S 6 vmm: take exclusive mem_segs_lock in vm_cleanup()
S 7 vmm: fix use after free in ppt_detach()
S 8 vm: centralize VM_BATCHQUEUE_SIZE definition
* 9 53545967642d850eee4f2dd9fa27cae52ae981b9 vtd: Increase DRHD_MAX_UNITS
S 10 vmm: avoid spurious rendezvous
S 11 vmm: purge EOL release compatibility
S 12 vmm: Collapse identical case statements in vlapic_icrlo_write_handler()
S 13 vmm: Remove an unneeded initialization of "retu"
S 14 vmm: Fix AP startup compatibility for old bhyve executables
* 15 bhyve: add helper struct for acpi device handling
* 16 bhyve: add helper func to add acpi resources
* 17 bhyve: add helper func to write a dsdt entry
* 18 bhyve: maintain a list of acpi devices
* 19 bhyve: add basic qemu fwcfg implementation
* 20 bhyve: add emulation for the qemu fwcfg selector port
* 21 bhyve: add emulation for qemu's fwcfg data port
* 22 bhyve: add helper to add fwcfg items
* 23 bhyve: add common fwcfg items
S 24 vmm: fix restore of TSC offset
S 25 bhyve: fix restore of kernel structs
S 26 bhyve: fix resume for vms with guest_ncpus > 1
* 27 bhyve: remove redundant variable
* 28 bhyve: Remove useless return at the end of void function
* 29 bhyvectl: Address compiler warnings and bump WARNS
S 30 bhyvectl: do not return garbage from send_message
S 31 bhyvectl: correct socket_fd closing in send_message
S 32 bhyvectl: don't leak nvlist in send_message
S 33 libvmm: add missing ioctl's to vm_ioctl_cmds
S 34 bhyve: don't flush readonly device at blockif_pause
S 35 bhyve: add cap limits for ipc socket
S 36 bhyve: exit with EX_OSERR if init checkpoint or restore time failed
S 37 bhyve: init checkput before caph_enter
S 38 bhyvectl: don't permit using --suspend and --checkpoint at same time
S 39 bhyve: Move libcasper dependecy to lib9p
* 40 bhyve: Remove trailing semicolon
* 41 bhyve: add helper for adding fwcfg files
* 42 bhyve: add cmdline option to