[Okular-devel] pan mouse icon fix
Hey,
Here's the fix for the pan icon showing up on a double click. Seems to me
the timer may last a bit too long though. Yeah? No? Anyway, criticism
is certainly appreciated.
I also noticed what seems to be a bug with pop up notes. When my zoom is
at 100% the whole of my document fits in the window. Great. Pop up notes
seem to behave normally.
However if I'm zoomed in enough that I'm able to scroll around in my
document (or perhaps if a document just has more than one page), that's
when I see a problem. If I open a pop up note and move it around a bit, I
get this strangeness:
http://www.cs.ucr.edu/~gkaukola/okularbug.png
I'll see if I can't pin things down further.
Cheers,
Glen KaukolaIndex: okular/ui/pageview.cpp
===
--- okular/ui/pageview.cpp (revision 1107218)
+++ okular/ui/pageview.cpp (working copy)
@@ -145,6 +145,9 @@
QPoint dragScrollVector;
QTimer dragScrollTimer;
+// left click depress
+QTimer leftClickTimer;
+
// actions
KAction * aRotateClockwise;
KAction * aRotateCounterClockwise;
@@ -302,6 +305,7 @@
connect(horizontalScrollBar(), SIGNAL(valueChanged(int)), this, SLOT(slotRequestVisiblePixmaps(int)));
connect(verticalScrollBar(), SIGNAL(valueChanged(int)), this, SLOT(slotRequestVisiblePixmaps(int)));
connect( &d->dragScrollTimer, SIGNAL(timeout()), this, SLOT(slotDragScroll()) );
+connect( &d->leftClickTimer, SIGNAL(timeout()), this, SLOT(slotShowSizeAllCursor()) );
// set a corner button to resize the view to the page size
//QPushButton * resizeButton = new QPushButton( viewport() );
@@ -1652,7 +1656,7 @@
{
d->mouseGrabPos = d->mouseOnRect ? QPoint() : d->mousePressPos;
if ( !d->mouseOnRect )
-setCursor( Qt::SizeAllCursor );
+d->leftClickTimer.start(QApplication::doubleClickInterval() + 10);
}
}
else if ( rightButton )
@@ -1713,6 +1717,8 @@
// stop the drag scrolling
d->dragScrollTimer.stop();
+d->leftClickTimer.stop();
+
// don't perform any mouse action when no document is shown..
if ( d->items.isEmpty() )
{
@@ -3272,6 +3278,11 @@
d->messageWindow->display( i18n( "Welcome" ), PageViewMessage::Info, 2000 );
}
+void PageView::slotShowSizeAllCursor()
+{
+setCursor( Qt::SizeAllCursor );
+}
+
void PageView::slotZoom()
{
setFocus();
Index: okular/ui/pageview.h
===
--- okular/ui/pageview.h (revision 1107218)
+++ okular/ui/pageview.h (working copy)
@@ -190,6 +190,8 @@
void slotDragScroll();
// show the welcome message
void slotShowWelcome();
+// activated by left click timer
+void slotShowSizeAllCursor();
// connected to local actions (toolbar, menu, ..)
void slotZoom();___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 232027] dvi search latex texmarker
https://bugs.kde.org/show_bug.cgi?id=232027 --- Comment #6 from Carlos Macapuna 2010-03-25 01:07:43 --- Hum .. do not remember! Sorry! :( But it's possible! -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 232027] dvi search latex texmarker
https://bugs.kde.org/show_bug.cgi?id=232027 --- Comment #5 from Albert Astals Cid 2010-03-24 22:54:40 --- You've still not answered one of the questions, i´ll post it again. It is possible that the document was being reloaded while you were searching? -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 232027] dvi search latex texmarker
https://bugs.kde.org/show_bug.cgi?id=232027 --- Comment #4 from Carlos Macapuna 2010-03-24 21:41:46 --- No. It occurred only once. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 232027] dvi search latex texmarker
https://bugs.kde.org/show_bug.cgi?id=232027 --- Comment #3 from Albert Astals Cid 2010-03-24 21:24:52 --- Can you answer my other question please? Also can you reproduce the crash each time you do that? -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 232027] dvi search latex texmarker
https://bugs.kde.org/show_bug.cgi?id=232027 --- Comment #2 from Carlos Macapuna 2010-03-24 21:15:00 --- I was using TeXMaker in Kubuntu. When viewing the document by TeXMaker (F3) it opens the program. I tried a search word, then the program closed. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 232027] dvi search latex texmarker
https://bugs.kde.org/show_bug.cgi?id=232027 --- Comment #1 from Albert Astals Cid 2010-03-24 20:45:47 --- Can you please clarify the title, what is "dvi search latex texmarker" to mean? Also, i understand you were trying to search text in a dvi file and it crashed? It is possible that the document was being reloaded while you were searching? -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 160628] Constant resizing loop
https://bugs.kde.org/show_bug.cgi?id=160628 --- Comment #11 from Albert Astals Cid 2010-03-24 20:48:00 --- Yeah it seems to be happening again, it would be bug 227153 so no need to reopen this again. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 232027] New: dvi search latex texmarker
https://bugs.kde.org/show_bug.cgi?id=232027 Summary: dvi search latex texmarker Product: okular Version: unspecified Platform: Unlisted Binaries OS/Version: Linux Status: UNCONFIRMED Severity: crash Priority: NOR Component: general AssignedTo: okular-devel@kde.org ReportedBy: carlosmacap...@gmail.com Application that crashed: okular Version of the application: 0.9.2 KDE Version: 4.3.2 (KDE 4.3.2) Qt Version: 4.5.2 Operating System: Linux 2.6.31-20-generic x86_64 Distribution: Ubuntu 9.10 What I was doing when the application crashed: I was making search, and close down... -- Backtrace: Application: Okular (okular), signal: Segmentation fault [Current thread is 1 (Thread 0x7f7250dbe750 (LWP 8050))] Thread 2 (Thread 0x7f7241a24910 (LWP 8105)): #0 0x7f724e214412 in select () from /lib/libc.so.6 #1 0x7f724f491b28 in qt_native_select (fdread=0x7f7241a22f00, fdwrite=0x7f7241a22e80, timeout=-1) at io/qprocess_unix.cpp:936 #2 0x7f724f491cc7 in QProcessPrivate::waitForFinished (this=0x2905ce0, msecs=-1) at io/qprocess_unix.cpp:1158 #3 0x7f724f45581a in QProcess::waitForFinished (this=0x7f7241a23020, msecs=-1) at io/qprocess.cpp:1318 #4 0x7f724f459528 in QProcess::execute (program=..., arguments=...) at io/qprocess.cpp:1701 #5 0x7f724fb3ce70 in KToolInvocation::startKdeinit () at ../../kdecore/kernel/ktoolinvocation.cpp:382 #6 0x7f724fb3e18f in KToolInvocation::klauncher () at ../../kdecore/kernel/ktoolinvocation.cpp:63 #7 0x7f724fbf863f in KSycocaPrivate::checkDatabase (this=0x2a03fd0, ifNotFound=) at ../../kdecore/sycoca/ksycoca.cpp:427 #8 0x7f724fbf9855 in KSycoca::findFactory (this=0x29188c0, id=KST_KMimeTypeFactory) at ../../kdecore/sycoca/ksycoca.cpp:455 #9 0x7f724fbfcc1f in KSycocaFactory (this=0x2a22a70, factory_id=KST_KMimeTypeFactory) at ../../kdecore/sycoca/ksycocafactory.cpp:50 #10 0x7f724fb438db in KMimeTypeFactory (this=0x400) at ../../kdecore/services/kmimetypefactory.cpp:35 #11 0x7f724fb43e5a in KSycocaFactorySingleton::self () at ../../kdecore/sycoca/ksycocafactory.h:200 #12 KMimeTypeFactory::self () at ../../kdecore/services/kmimetypefactory.cpp:88 #13 0x7f724fb4b72f in KMimeType::findByFileContent (fileName=..., accuracy=0x0) at ../../kdecore/services/kmimetype.cpp:458 #14 0x7f7243059368 in ?? () from /usr/lib/kde4/okularGenerator_dvi.so #15 0x7f724305eedd in ?? () from /usr/lib/kde4/okularGenerator_dvi.so #16 0x7f7243051537 in ?? () from /usr/lib/kde4/okularGenerator_dvi.so #17 0x7f724305237e in ?? () from /usr/lib/kde4/okularGenerator_dvi.so #18 0x7f724304ee30 in ?? () from /usr/lib/kde4/okularGenerator_dvi.so #19 0x7f7243049cff in ?? () from /usr/lib/kde4/okularGenerator_dvi.so #20 0x7f72461f5cc8 in ?? () from /usr/lib/libokularcore.so.1 #21 0x7f724f3cd445 in QThreadPrivate::start (arg=0x28ba150) at thread/qthread_unix.cpp:188 #22 0x7f724ab27a04 in start_thread (arg=) at pthread_create.c:300 #23 0x7f724e21b80d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:112 #24 0x in ?? () Thread 1 (Thread 0x7f7250dbe750 (LWP 8050)): [KCrash Handler] #5 0x7f72461f6f36 in Okular::Page::setTextPage(Okular::TextPage*) () from /usr/lib/libokularcore.so.1 #6 0x7f72461f441d in ?? () from /usr/lib/libokularcore.so.1 #7 0x7f72461f4c86 in Okular::Generator::qt_metacall(QMetaObject::Call, int, void**) () from /usr/lib/libokularcore.so.1 #8 0x7f724f4c30f9 in QObject::event (this=0x232f980, e=0x2e9d240) at kernel/qobject.cpp: #9 0x7f724e95befc in QApplicationPrivate::notify_helper (this=0x22b4d40, receiver=0x232f980, e=0x2e9d240) at kernel/qapplication.cpp:4056 #10 0x7f724e9631ce in QApplication::notify (this=0x7fff6878fc20, receiver=0x232f980, e=0x2e9d240) at kernel/qapplication.cpp:4021 #11 0x7f72500c7ab6 in KApplication::notify (this=0x7fff6878fc20, receiver=0x232f980, event=0x2e9d240) at ../../kdeui/kernel/kapplication.cpp:302 #12 0x7f724f4b3c2c in QCoreApplication::notifyInternal (this=0x7fff6878fc20, receiver=0x232f980, event=0x2e9d240) at kernel/qcoreapplication.cpp:610 #13 0x7f724f4b480a in QCoreApplication::sendEvent (receiver=0x0, event_type=, data=0x229c4d0) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:213 #14 QCoreApplicationPrivate::sendPostedEvents (receiver=0x0, event_type=, data=0x229c4d0) at kernel/qcoreapplication.cpp:1247 #15 0x7f724f4dc533 in QCoreApplication::sendPostedEvents (s=) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:218 #16 postEventSourceDispatch (s=) at kernel/qeventdispatcher_glib.cpp:210 #17 0x7f724ad78bce in g_main_context_dispatch () from /lib/libglib-2.0.so.0 #18 0x7f724ad7c598 in ?? () from /lib/libglib-2.0.so.0 #19 0x7f724ad7c6c0 in g_main_context_iteration () from /lib/libglib-2.0.so.0 #20 0x7f724f4dc1a6 in QEventDispatcherGlib::pro
[Okular-devel] [Bug 231880] left side of the printout is cut off
https://bugs.kde.org/show_bug.cgi?id=231880 --- Comment #7 from Attila 2010-03-24 15:41:43 --- Hello! The result of the printout is depending on the position of the "picture" in the PDF-Document. A higher position of the "picture" in the document means more cut off. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 160628] Constant resizing loop
https://bugs.kde.org/show_bug.cgi?id=160628 Jeffery MacEachern changed: What|Removed |Added CC||j.maceach...@gmail.com --- Comment #10 from Jeffery MacEachern 2010-03-24 03:23:17 --- I'm experiencing exactly this in Okular 0.10.1, from KDE SC 4.4.1 (Chakra Builds), although I've never noticed it before in previous versions. Maybe a regression? I'm not reopening this myself because I'm unsure of policy in this case, but the issue definitely still exists, under the same circumstances. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 231880] left side of the printout is cut off
https://bugs.kde.org/show_bug.cgi?id=231880 --- Comment #6 from Attila 2010-03-24 15:33:52 --- Created an attachment (id=42233) --> (http://bugs.kde.org/attachment.cgi?id=42233) Result for PDF-Document2 This is the printout for PDF-Document2 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 231880] left side of the printout is cut off
https://bugs.kde.org/show_bug.cgi?id=231880 --- Comment #5 from Attila 2010-03-24 15:32:56 --- Created an attachment (id=42232) --> (http://bugs.kde.org/attachment.cgi?id=42232) PDF-Document2 to print Try to print this Document in landscape mode. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 231880] left side of the printout is cut off
https://bugs.kde.org/show_bug.cgi?id=231880 --- Comment #4 from Attila 2010-03-24 15:30:53 --- Created an attachment (id=42231) --> (http://bugs.kde.org/attachment.cgi?id=42231) Result for PDF-Document1 This is the printout for PDF-Document1 -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [Bug 231880] left side of the printout is cut off
https://bugs.kde.org/show_bug.cgi?id=231880 --- Comment #3 from Attila 2010-03-24 15:27:51 --- Created an attachment (id=42230) --> (http://bugs.kde.org/attachment.cgi?id=42230) PDF-Document1 to print Try to print this Document in landscape mode. Here my printer: HP LaserJet 4100mfp, HP LaserJet 9050 and HP Color LaserJet 9500. The result is always the same (see next attachment). -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
